From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>,
dev@dpdk.org, Chenbo Xia <chenbox@nvidia.com>,
Jay Zhou <jianjay.zhou@huawei.com>,
Fan Zhang <fanzhang.oss@gmail.com>
Cc: anoobj@marvell.com, Akhil Goyal <gakhil@marvell.com>, stable@dpdk.org
Subject: Re: [v5 1/5] vhost: skip crypto op fetch before vring init
Date: Tue, 25 Feb 2025 17:17:53 +0100 [thread overview]
Message-ID: <00e98b7d-a240-4f8f-a06a-a28712e5ef95@redhat.com> (raw)
In-Reply-To: <c1aa7cdd5e1d58a6f484fcd45bbbe0f115c7b521.1740390893.git.gmuthukrishn@marvell.com>
On 2/24/25 11:35 AM, Gowrishankar Muthukrishnan wrote:
> Until virtio avail ring is initialized (by VHOST_USER_SET_VRING_ADDR),
> worker thread should not try to fetch crypto op, which would lead to
> memory fault.
>
> Fixes: 939066d96563 ("vhost/crypto: add public function implementation")
> Cc: stable@dpdk.org
>
> Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
> Acked-by: Akhil Goyal <gakhil@marvell.com>
> ---
> lib/vhost/vhost_crypto.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/lib/vhost/vhost_crypto.c b/lib/vhost/vhost_crypto.c
> index 3dc41a3bd5..55ea24710e 100644
> --- a/lib/vhost/vhost_crypto.c
> +++ b/lib/vhost/vhost_crypto.c
> @@ -1580,6 +1580,16 @@ rte_vhost_crypto_fetch_requests(int vid, uint32_t qid,
>
> vq = dev->virtqueue[qid];
>
> + if (unlikely(vq == NULL)) {
> + VC_LOG_ERR("Invalid virtqueue %u", qid);
> + return 0;
> + }
> +
> + if (unlikely(vq->avail == NULL)) {
> + VC_LOG_DBG("Virtqueue ring not yet initialized %u", qid);
> + return 0;
> + }
> +
I think the proper fix to:
1. acquire the access_lock as reader
2. check whether vq is enabled
3. acquire the iotlb lock as a reader
4. check vq's access_ok
You can have a look at rte_vhost_dequeue_burst for example.
> avail_idx = *((volatile uint16_t *)&vq->avail->idx);
> start_idx = vq->last_used_idx;
> count = avail_idx - start_idx;
next prev parent reply other threads:[~2025-02-25 16:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1740390893.git.gmuthukrishn@marvell.com>
2025-02-24 10:35 ` Gowrishankar Muthukrishnan
2025-02-25 16:17 ` Maxime Coquelin [this message]
2025-02-26 17:40 ` [EXTERNAL] " Gowrishankar Muthukrishnan
2025-02-24 10:35 ` [v5 3/5] examples/vhost_crypto: fix user callbacks Gowrishankar Muthukrishnan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00e98b7d-a240-4f8f-a06a-a28712e5ef95@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=anoobj@marvell.com \
--cc=chenbox@nvidia.com \
--cc=dev@dpdk.org \
--cc=fanzhang.oss@gmail.com \
--cc=gakhil@marvell.com \
--cc=gmuthukrishn@marvell.com \
--cc=jianjay.zhou@huawei.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).