From: "Guo, Jia" <jia.guo@intel.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix link down and negotiation issue
Date: Fri, 21 Jul 2017 02:56:18 +0000 [thread overview]
Message-ID: <01BA8470C017D6468C8290E4B9C5E1E83B245AED@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <9BB6961774997848B5B42BEC655768F810DCD3C2@SHSMSX103.ccr.corp.intel.com>
Yes, I have already use cpu_to_le32 to translator, but I agree first defend it as uint32_t might be better to read . I will send v2 , thanks for review.
Best regards,
Jeff Guo
-----Original Message-----
From: Wu, Jingjing
Sent: Friday, July 21, 2017 10:26 AM
To: Guo, Jia <jia.guo@intel.com>; Xing, Beilei <beilei.xing@intel.com>
Cc: dev@dpdk.org
Subject: RE: [PATCH] net/i40e: fix link down and negotiation issue
> -----Original Message-----
> From: Guo, Jia
> Sent: Thursday, July 20, 2017 4:45 PM
> To: Xing, Beilei <beilei.xing@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>
> Cc: dev@dpdk.org; Guo, Jia <jia.guo@intel.com>
> Subject: [PATCH] net/i40e: fix link down and negotiation issue
>
> Enable the functions set link down and set link up in i40e by check
> phy_type, and fix the issue of auto negotiation failed in XXV710 when
> bind kernel driver after unbind from dpdk driver by modify the speed
> setting distinguish from set link up and down. With this fix, if
> unbind dpdk to bind kernel driver, no need to set auto negotiation and ifconfi up anymore, remove the part from doc.
>
> Fixes: ca7e599d4506 ("net/i40e: fix link management")
> Fixes: 2f1e22817420 ("i40e: skip link control as firmware workaround")
> Fixes: 6e145fcc754b ("6e145fcc754b5e79167")
What is this? Need to add title.
How about to CC stable@dpdk.org?
> enum i40e_status_code status;
> struct i40e_aq_get_phy_abilities_resp phy_ab;
> struct i40e_aq_set_phy_config phy_conf;
> + enum i40e_aq_phy_type cnt;
> + __le32 phy_type_mask = 0;
Please define it as unit32_t, and use cpu_to_le32 when assigning,
next prev parent reply other threads:[~2017-07-21 2:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-20 8:45 Jeff Guo
2017-07-21 2:25 ` Wu, Jingjing
2017-07-21 2:56 ` Guo, Jia [this message]
2017-07-21 3:07 ` [dpdk-dev] [PATCH v2] " Jeff Guo
2017-07-21 6:33 ` Wu, Jingjing
2017-07-21 9:06 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01BA8470C017D6468C8290E4B9C5E1E83B245AED@shsmsx102.ccr.corp.intel.com \
--to=jia.guo@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).