From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Nirmoy Das <ndas@suse.de>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] kni: fix build on SLE12 SP3
Date: Fri, 18 Aug 2017 17:13:11 +0100 [thread overview]
Message-ID: <025e34de-65e8-a65c-53eb-bd2feb9e528c@intel.com> (raw)
In-Reply-To: <20170815095801.24988-1-ndas@suse.de>
Hi Nirmoy,
On 8/15/2017 10:58 AM, Nirmoy Das wrote:
> compilation error:
> build/lib/librte_eal/linuxapp/kni/kni_net.c:215:5: error: ‘struct net_device’ has no member named ‘trans_start’
Commit log is too long, can you please break this line.
> dev->trans_start = jiffies;
>
> Signed-off-by: Nirmoy Das <ndas@suse.de>
> ---
> lib/librte_eal/linuxapp/kni/compat.h | 32 +++++++++++++++++++++++++++++++-
> 1 file changed, 31 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/linuxapp/kni/compat.h b/lib/librte_eal/linuxapp/kni/compat.h
> index 6a1587b4e..81a4a5704 100644
> --- a/lib/librte_eal/linuxapp/kni/compat.h
> +++ b/lib/librte_eal/linuxapp/kni/compat.h
> @@ -8,6 +8,34 @@
> #define RHEL_RELEASE_VERSION(a, b) (((a) << 8) + (b))
> #endif
>
> +/* SuSE version macro is the same as Linux kernel version */
> +#ifndef SLE_VERSION
> +#define SLE_VERSION(a,b,c) KERNEL_VERSION(a,b,c)
> +#endif
> +#ifdef CONFIG_SUSE_KERNEL
> +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4, 4, 57))
> +/* SLES12SP3 is at least 4.4.57+ based */
> +#define SLE_VERSION_CODE SLE_VERSION(12, 3, 0)
> +#elif ( LINUX_VERSION_CODE >= KERNEL_VERSION(3,12,28) )
There are checkpach warnings [1], can you please send a new version with
them fixes?
[1]
ERROR:SPACING
For spaces after, before the parenthesis and for missing space after ","
in args list..
> +/* SLES12 is at least 3.12.28+ based */
> +#define SLE_VERSION_CODE SLE_VERSION(12,0,0)
> +#elif ((LINUX_VERSION_CODE >= KERNEL_VERSION(3,0,61)) && \
> + (LINUX_VERSION_CODE < KERNEL_VERSION(3,1,0)))
> +/* SLES11 SP3 is at least 3.0.61+ based */
> +#define SLE_VERSION_CODE SLE_VERSION(11,3,0)
> +#elif ( LINUX_VERSION_CODE == KERNEL_VERSION(2,6,32) )
> +/* SLES11 SP1 is 2.6.32 based */
> +#define SLE_VERSION_CODE SLE_VERSION(11,1,0)
> +#elif ( LINUX_VERSION_CODE == KERNEL_VERSION(2,6,27) )
> +/* SLES11 GA is 2.6.27 based */
> +#define SLE_VERSION_CODE SLE_VERSION(11,0,0)
> +#endif /* LINUX_VERSION_CODE == KERNEL_VERSION(x,y,z) */
> +#endif /* CONFIG_SUSE_KERNEL */
> +#ifndef SLE_VERSION_CODE
> +#define SLE_VERSION_CODE 0
> +#endif /* SLE_VERSION_CODE */
<...>
prev parent reply other threads:[~2017-08-18 16:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-15 9:58 Nirmoy Das
2017-08-18 16:13 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=025e34de-65e8-a65c-53eb-bd2feb9e528c@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=ndas@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).