From: gowrishankar muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
To: Chao Zhu <chaozhu@linux.vnet.ibm.com>, dev@dpdk.org
Cc: "'Bruce Richardson'" <bruce.richardson@intel.com>,
"'Konstantin Ananyev'" <konstantin.ananyev@intel.com>,
"'Thomas Monjalon'" <thomas.monjalon@6wind.com>,
"'Cristian Dumitrescu'" <cristian.dumitrescu@intel.com>,
"'Pradeep'" <pradeep@us.ibm.com>
Subject: Re: [dpdk-dev] [PATCH v4 3/6] ip_pipeline: fix lcore mapping for varying SMT threads as in ppc64
Date: Tue, 9 Aug 2016 16:43:38 +0530 [thread overview]
Message-ID: <02d3d480-85cf-619f-eb92-630adb5881c3@linux.vnet.ibm.com> (raw)
In-Reply-To: <000101d1f21d$82985610$87c90230$@linux.vnet.ibm.com>
Hi Chao,
Sure. Please find below one.
This patch fixes ip_pipeline panic in app_init_core_map while preparing cpu
core map in powerpc with SMT off. cpu_core_map_compute_linux currently
prepares
core mapping based on file existence in sysfs ie.
/sys/devices/system/cpu/cpu<LCORE_NUM>/topology/physical_package_id
/sys/devices/system/cpu/cpu<LCORE_NUM>/topology/core_id
These files do not exist for lcores which are offline for any reason (as in
powerpc, while SMT is off). In this situation, this function should further
continue preparing map for other online lcores instead of returning with -1
for a first unavailable lcore.
Also, in SMT=off scenario for powerpc, lcore ids can not be always
indexed from
0 upto 'number of cores present' (/sys/devices/system/cpu/present). For
eg, for
an online lcore 32, core_id returned in sysfs is 112 where online lcores are
10 (as in one configuration), hence sysfs lcore id can not be checked with
indexing lcore number before positioning lcore map array.
Thanks,
Gowrishankar
On Tuesday 09 August 2016 02:37 PM, Chao Zhu wrote:
> Gowrishankar,
>
> Can you give more description about this patch?
> Thank you!
>
> -----Original Message-----
> From: Gowrishankar Muthukrishnan [mailto:gowrishankar.m@linux.vnet.ibm.com]
> Sent: 2016年8月6日 20:33
> To: dev@dpdk.org
> Cc: Chao Zhu <chaozhu@linux.vnet.ibm.com>; Bruce Richardson
> <bruce.richardson@intel.com>; Konstantin Ananyev
> <konstantin.ananyev@intel.com>; Thomas Monjalon <thomas.monjalon@6wind.com>;
> Cristian Dumitrescu <cristian.dumitrescu@intel.com>; Pradeep
> <pradeep@us.ibm.com>; gowrishankar <gowrishankar.m@linux.vnet.ibm.com>
> Subject: [PATCH v4 3/6] ip_pipeline: fix lcore mapping for varying SMT
> threads as in ppc64
>
> From: gowrishankar <gowrishankar.m@linux.vnet.ibm.com>
>
> offline lcore would still refer to original core id and this has to be
> considered while creating cpu core mask.
>
> Signed-off-by: Gowrishankar <gowrishankar.m@linux.vnet.ibm.com>
> ---
> config/defconfig_ppc_64-power8-linuxapp-gcc | 3 ---
> examples/ip_pipeline/cpu_core_map.c | 12 +-----------
> examples/ip_pipeline/init.c | 4 ++++
> 3 files changed, 5 insertions(+), 14 deletions(-)
>
> diff --git a/config/defconfig_ppc_64-power8-linuxapp-gcc
> b/config/defconfig_ppc_64-power8-linuxapp-gcc
> index dede34f..a084672 100644
> --- a/config/defconfig_ppc_64-power8-linuxapp-gcc
> +++ b/config/defconfig_ppc_64-power8-linuxapp-gcc
> @@ -58,6 +58,3 @@ CONFIG_RTE_LIBRTE_FM10K_PMD=n
>
> # This following libraries are not available on Power. So they're turned
> off.
> CONFIG_RTE_LIBRTE_SCHED=n
> -CONFIG_RTE_LIBRTE_PORT=n
> -CONFIG_RTE_LIBRTE_TABLE=n
> -CONFIG_RTE_LIBRTE_PIPELINE=n
> diff --git a/examples/ip_pipeline/cpu_core_map.c
> b/examples/ip_pipeline/cpu_core_map.c
> index cb088b1..482e68e 100644
> --- a/examples/ip_pipeline/cpu_core_map.c
> +++ b/examples/ip_pipeline/cpu_core_map.c
> @@ -351,9 +351,6 @@ cpu_core_map_compute_linux(struct cpu_core_map *map)
> int lcore_socket_id =
> cpu_core_map_get_socket_id_linux(lcore_id);
>
> - if (lcore_socket_id < 0)
> - return -1;
> -
> if (((uint32_t) lcore_socket_id) == socket_id)
> n_detected++;
> }
> @@ -368,18 +365,11 @@ cpu_core_map_compute_linux(struct cpu_core_map *map)
> cpu_core_map_get_socket_id_linux(
> lcore_id);
>
> - if (lcore_socket_id < 0)
> - return -1;
> -
> Why to remove the lcore_socket_id check?
>
> int lcore_core_id =
> cpu_core_map_get_core_id_linux(
> lcore_id);
>
> - if (lcore_core_id < 0)
> - return -1;
> -
> - if (((uint32_t) lcore_socket_id ==
> socket_id) &&
> - ((uint32_t) lcore_core_id ==
> core_id)) {
> + if ((uint32_t) lcore_socket_id == socket_id)
> {
> uint32_t pos = cpu_core_map_pos(map,
> socket_id,
> core_id_contig,
> diff --git a/examples/ip_pipeline/init.c b/examples/ip_pipeline/init.c index
> cd167f6..60c931f 100644
> --- a/examples/ip_pipeline/init.c
> +++ b/examples/ip_pipeline/init.c
> @@ -61,7 +61,11 @@ static void
> app_init_core_map(struct app_params *app) {
> APP_LOG(app, HIGH, "Initializing CPU core map ...");
> +#if defined(RTE_ARCH_PPC_64)
> + app->core_map = cpu_core_map_init(2, 5, 1, 0); #else
>
> This value seems quite strange. Can you give more detail?
>
> app->core_map = cpu_core_map_init(4, 32, 4, 0);
> +#endif
>
> if (app->core_map == NULL)
> rte_panic("Cannot create CPU core map\n");
> --
> 1.9.1
>
>
>
next prev parent reply other threads:[~2016-08-09 11:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-06 12:32 [dpdk-dev] [PATCH v4 0/6] enable lpm, acl and other missing libraries in ppc64le Gowrishankar Muthukrishnan
2016-08-06 12:32 ` [dpdk-dev] [PATCH v4 1/6] lpm: add altivec intrinsics for dpdk lpm on ppc_64 Gowrishankar Muthukrishnan
2016-08-06 12:32 ` [dpdk-dev] [PATCH v4 2/6] acl: add altivec intrinsics for dpdk acl " Gowrishankar Muthukrishnan
2016-08-06 12:32 ` [dpdk-dev] [PATCH v4 3/6] ip_pipeline: fix lcore mapping for varying SMT threads as in ppc64 Gowrishankar Muthukrishnan
2016-08-09 9:07 ` Chao Zhu
2016-08-09 11:13 ` gowrishankar muthukrishnan [this message]
2016-08-11 10:29 ` Chao Zhu
2016-08-11 12:01 ` gowrishankar muthukrishnan
2016-08-12 8:44 ` Chao Zhu
2016-08-12 8:59 ` gowrishankar muthukrishnan
2016-08-12 10:15 ` Chao Zhu
2016-08-12 10:34 ` gowrishankar muthukrishnan
2016-08-12 12:05 ` gowrishankar muthukrishnan
2016-08-06 12:32 ` [dpdk-dev] [PATCH v4 4/6] table: cache align rte_bucket_4_8 Gowrishankar Muthukrishnan
2016-08-06 12:32 ` [dpdk-dev] [PATCH v4 5/6] sched: enable sched library for ppc64le Gowrishankar Muthukrishnan
2016-08-06 12:32 ` [dpdk-dev] [PATCH v4 6/6] l3fwd: add altivec support for em_hash_key Gowrishankar Muthukrishnan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02d3d480-85cf-619f-eb92-630adb5881c3@linux.vnet.ibm.com \
--to=gowrishankar.m@linux.vnet.ibm.com \
--cc=bruce.richardson@intel.com \
--cc=chaozhu@linux.vnet.ibm.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=pradeep@us.ibm.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).