From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: Jianbo Liu <jianbo.liu@linaro.org>,
Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Zhang, Helin" <helin.zhang@intel.com>,
Jerin Jacob <jerin.jacob@caviumnetworks.com>,
"Chao Zhu" <chaozhu@linux.vnet.ibm.com>
Subject: Re: [dpdk-dev] [PATCH v7 0/3] net/i40e: configurable PTYPE mapping
Date: Wed, 5 Apr 2017 06:01:56 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E7061153087EF9@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <CAP4Qi39=oRMu0OEi_sEm-3cgAe_cTPQzCmcBwdgfb1r=AihxZg@mail.gmail.com>
> -----Original Message-----
> From: Jianbo Liu [mailto:jianbo.liu@linaro.org]
> Sent: Wednesday, April 5, 2017 1:46 PM
> To: Thomas Monjalon <thomas.monjalon@6wind.com>
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; dev@dpdk.org; Yigit, Ferruh
> <ferruh.yigit@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Zhang,
> Helin <helin.zhang@intel.com>; Jerin Jacob
> <jerin.jacob@caviumnetworks.com>; Chao Zhu
> <chaozhu@linux.vnet.ibm.com>
> Subject: Re: [dpdk-dev] [PATCH v7 0/3] net/i40e: configurable PTYPE
> mapping
>
> On 5 April 2017 at 04:22, Thomas Monjalon <thomas.monjalon@6wind.com>
> wrote:
> > 2017-04-04 10:30, Ferruh Yigit:
> >> On 4/4/2017 2:55 AM, Qi Zhang wrote:
> >> > The patch set create new APIs that help to change the mapping from
> >> > hardware defined packet type to software defined packet type for i40e
> NICs.
> >> > Keep these APIs private is because currently they are only
> >> > meaningful for devices that support dynamic PTYPE configuration,
> >> > which may not be a general device feature.
> > [...]
> >> > Qi Zhang (3):
> >> > net/i40e: enable per dev PTYPE mapping table
> >> > net/i40e: configurable PTYPE mapping
> >> > app/testpmd: add CL for ptype mapping configure
> >>
> >> Series applied to dpdk-next-net/master, thanks.
> >
> > It does not compile for ARM (not tested for POWER):
> > drivers/net/i40e/i40e_rxtx_vec_neon.c: In function
> '_recv_raw_pkts_vec':
> > 229:2: error: unknown type name 'uint32'
> > uint32 *ptype_tbl = rxq->vsi->adapter->ptype_tbl;
> >
>
> It must be uint32_t.
>
> > Given that
> > - it changes NEON and Altivec code
> > - it does not compile on ARM
> > - there is no Ack from NEON or Altivec maintainers (they were
> > not Cc'ed) I really doubt it has been tested.
> > That's why it won't be in RC1.
> >
> > If NEON and Altivec maintainers agree, we can give it a chance for RC2.
> >
>
> Other than the above error on ARM:
> Acked-by: Jianbo Liu <jianbo.liu@linaro.org>
Thanks Jianbo.
I will rebase to RC1 and send v8.
Sorry for the inconvenient.
>
> > PS: please use --in-reply-to to let us check the discussion history.
next prev parent reply other threads:[~2017-04-05 6:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 1:55 Qi Zhang
2017-04-04 1:55 ` [dpdk-dev] [PATCH v7 1/3] net/i40e: enable per dev PTYPE mapping table Qi Zhang
2017-04-04 1:55 ` [dpdk-dev] [PATCH v7 2/3] net/i40e: configurable PTYPE mapping Qi Zhang
2017-04-04 1:55 ` [dpdk-dev] [PATCH v7 3/3] app/testpmd: add CL for ptype mapping configure Qi Zhang
2017-04-04 9:30 ` [dpdk-dev] [PATCH v7 0/3] net/i40e: configurable PTYPE mapping Ferruh Yigit
2017-04-04 20:22 ` Thomas Monjalon
2017-04-05 5:45 ` Jianbo Liu
2017-04-05 6:01 ` Zhang, Qi Z [this message]
2017-04-07 3:25 ` [dpdk-dev] [PATCH v8 " Qi Zhang
2017-04-07 3:25 ` [dpdk-dev] [PATCH v8 1/3] net/i40e: enable per dev PTYPE mapping table Qi Zhang
2017-04-07 2:36 ` Zhang, Qi Z
2017-04-12 2:13 ` Zhang, Qi Z
2017-04-07 3:25 ` [dpdk-dev] [PATCH v8 2/3] net/i40e: configurable PTYPE mapping Qi Zhang
2017-04-12 8:36 ` Ferruh Yigit
2017-04-07 3:25 ` [dpdk-dev] [PATCH v8 3/3] app/testpmd: add CL for ptype mapping configure Qi Zhang
2017-04-12 13:55 ` [dpdk-dev] [PATCH v9 0/3] net/i40e: configurable PTYPE mapping Qi Zhang
2017-04-12 13:55 ` [dpdk-dev] [PATCH v9 1/3] net/i40e: enable per dev PTYPE mapping table Qi Zhang
2017-04-12 13:55 ` [dpdk-dev] [PATCH v9 2/3] net/i40e: configurable PTYPE mapping Qi Zhang
2017-04-12 13:55 ` [dpdk-dev] [PATCH v9 3/3] app/testpmd: add CL for ptype mapping configure Qi Zhang
2017-04-13 9:50 ` [dpdk-dev] [PATCH v9 0/3] net/i40e: configurable PTYPE mapping Chao Zhu
2017-04-13 10:46 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E7061153087EF9@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=chaozhu@linux.vnet.ibm.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=helin.zhang@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=jianbo.liu@linaro.org \
--cc=jingjing.wu@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).