From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "gaetan.rivet@6wind.com" <gaetan.rivet@6wind.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>,
"Mcnamara, John" <john.mcnamara@intel.com>
Subject: Re: [dpdk-dev] [PATCH] ethdev: add roughly match pattern
Date: Thu, 1 Jun 2017 01:44:56 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E70611530A69E6@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20170531075129.GP14914@bidouze.vm.6wind.com>
> -----Original Message-----
> From: Gaëtan Rivet [mailto:gaetan.rivet@6wind.com]
> Sent: Wednesday, May 31, 2017 3:52 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; dev@dpdk.org
> Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>; Mcnamara, John
> <john.mcnamara@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] ethdev: add roughly match pattern
>
> On Tue, May 30, 2017 at 02:46:30PM +0200, Adrien Mazarguil wrote:
> >Hi Zhang,
> >
> >You should cram "flow API" somewhere in the title of such commits.
> >
> >On Tue, May 23, 2017 at 07:28:54PM -0400, Qi Zhang wrote:
> >> Add new meta pattern item RTE_FLOW_TYPE_ITEM_ROUGHLY.
> >>
> >> This is for device that support no-perfect match option.
> >> Usually a no-perfect match is fast but the cost is accuracy.
> >> i.e. Signature Match only match pattern's hash value, but it is
> >> possible two different patterns have the same hash value.
> >>
> >> Matching accuracy level can be configure by subfield threshold.
> >> Driver can divide the range of threshold and map to different
> >> accuracy levels that device support.
> >>
> >> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> >
> >While I really like the "roughly" pattern item name since it perfectly
> >describes its intended purpose in my opinion, perhaps some may not find
> >this name appropriate. I would like to hear other people's opinion on
> >the matter and not be the only one to ack this patch.
>
> "no-perfect" has been used a few times in the documentation. How about
> "IMPERFECT" as item name?
>
"Imperfect" looks better for me,
If no other objection, I will use this in V2.
Thanks
Qi
> --
> Gaëtan Rivet
> 6WIND
next prev parent reply other threads:[~2017-06-01 1:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 23:28 Qi Zhang
2017-05-30 12:46 ` Adrien Mazarguil
2017-05-31 7:51 ` Gaëtan Rivet
2017-06-01 1:44 ` Zhang, Qi Z [this message]
2017-06-01 14:44 ` Adrien Mazarguil
2017-06-07 22:21 ` [dpdk-dev] [PATCH v2] ethdev: add fuzzy " Qi Zhang
2017-06-08 7:19 ` Thomas Monjalon
2017-06-12 15:38 ` Adrien Mazarguil
2017-06-13 6:03 ` Zhang, Qi Z
2017-06-13 3:07 ` [dpdk-dev] [PATCH v3] ethdev: add fuzzy match in flow API Qi Zhang
2017-07-05 16:06 ` Ferruh Yigit
2017-07-05 17:55 ` Thomas Monjalon
2017-06-21 19:07 ` [dpdk-dev] [PATCH v3 0/3] net/ixgbe: enable signature match and ipv6 for consistent API Qi Zhang
2017-06-21 19:07 ` [dpdk-dev] [PATCH v3 1/3] net/ixgbe: replace macro with inline function Qi Zhang
2017-06-21 19:07 ` [dpdk-dev] [PATCH v3 2/3] net/ixgbe: enable signature match for consistent API Qi Zhang
2017-06-21 19:07 ` [dpdk-dev] [PATCH v3 3/3] net/ixgbe: enable IPv6 " Qi Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E70611530A69E6@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=john.mcnamara@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).