From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Xing, Beilei" <beilei.xing@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Zhang, Helin" <helin.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/i40e: exclude internal packet's byte count
Date: Fri, 2 Jun 2017 00:23:13 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E70611530A7156@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <94479800C636CB44BD422CB454846E0131FBF93D@SHSMSX101.ccr.corp.intel.com>
> -----Original Message-----
> From: Xing, Beilei
> Sent: Thursday, June 1, 2017 5:13 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Zhang, Helin <helin.zhang@intel.com>
> Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; stable@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] net/i40e: exclude internal packet's byte
> count
>
> Hi Qi,
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qi Zhang
> > Sent: Thursday, June 1, 2017 6:53 AM
> > To: Wu, Jingjing <jingjing.wu@intel.com>; Zhang, Helin
> > <helin.zhang@intel.com>
> > Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; stable@dpdk.org
> > Subject: [dpdk-dev] [PATCH] net/i40e: exclude internal packet's byte
> > count
> >
> > Tx/Rx byte counts of internal managed packet should be exluded from
> > the total rx/tx bytes.
> >
> > Fixes: 9aace75fc82e ("i40e: fix statistics")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> > ---
> > drivers/net/i40e/i40e_ethdev.c | 13 +++++++++++--
> > drivers/net/i40e/i40e_ethdev.h | 5 +++++
> > 2 files changed, 16 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/i40e/i40e_ethdev.c
> > b/drivers/net/i40e/i40e_ethdev.c index 4c49673..c8802f2 100644
> > --- a/drivers/net/i40e/i40e_ethdev.c
> > +++ b/drivers/net/i40e/i40e_ethdev.c
> > @@ -2379,6 +2379,15 @@ i40e_read_stats_registers(struct i40e_pf *pf,
> > struct i40e_hw *hw)
> > struct i40e_hw_port_stats *ns = &pf->stats; /* new stats */
> > struct i40e_hw_port_stats *os = &pf->stats_offset; /* old stats */
> >
> > + /* Get rx/tx bytes of internal transfer packets */
> > + i40e_stat_update_48(hw, I40E_GLV_GORCH(hw->port),
> > I40E_GLV_GORCL(hw->port),
> > + pf->offset_loaded, &pf->internal_rx_bytes_offset,
> > + &pf->internal_rx_bytes);
> > +
> > + i40e_stat_update_48(hw, I40E_GLV_GOTCH(hw->port),
> > I40E_GLV_GOTCL(hw->port),
> > + pf->offset_loaded, &pf->internal_tx_bytes_offset,
> > + &pf->internal_tx_bytes);
> > +
> > /* Get statistics of struct i40e_eth_stats */
> > i40e_stat_update_48(hw, I40E_GLPRT_GORCH(hw->port),
> > I40E_GLPRT_GORCL(hw->port),
> > @@ -2400,7 +2409,7 @@ i40e_read_stats_registers(struct i40e_pf *pf,
> > struct i40e_hw *hw)
> > * so subtract ETHER_CRC_LEN from the byte counter for each rx
> > packet.
> > */
> > ns->eth.rx_bytes -= (ns->eth.rx_unicast + ns->eth.rx_multicast +
> > - ns->eth.rx_broadcast) * ETHER_CRC_LEN;
> > + ns->eth.rx_broadcast) * ETHER_CRC_LEN + pf-
> > >internal_rx_bytes;
> >
> > i40e_stat_update_32(hw, I40E_GLPRT_RDPC(hw->port),
> > pf->offset_loaded, &os->eth.rx_discards, @@ -
> > 2428,7 +2437,7 @@ i40e_read_stats_registers(struct i40e_pf *pf, struct
> > i40e_hw *hw)
> > pf->offset_loaded, &os->eth.tx_broadcast,
> > &ns->eth.tx_broadcast);
> > ns->eth.tx_bytes -= (ns->eth.tx_unicast + ns->eth.tx_multicast +
> > - ns->eth.tx_broadcast) * ETHER_CRC_LEN;
> > + ns->eth.tx_broadcast) * ETHER_CRC_LEN + pf-
> > >internal_tx_bytes;
> > /* GLPRT_TEPC not supported */
> >
> > /* additional port specific stats */ diff --git
> > a/drivers/net/i40e/i40e_ethdev.h b/drivers/net/i40e/i40e_ethdev.h
> > index 2ff8282..b0d963c 100644
> > --- a/drivers/net/i40e/i40e_ethdev.h
> > +++ b/drivers/net/i40e/i40e_ethdev.h
> > @@ -639,6 +639,11 @@ struct i40e_pf {
> >
> > struct i40e_hw_port_stats stats_offset;
> > struct i40e_hw_port_stats stats;
> > + /* internal packet byte count, it should be excluded from the total */
> > + uint64_t internal_rx_bytes;
> > + uint64_t internal_tx_bytes;
> > + uint64_t internal_rx_bytes_offset;
> > + uint64_t internal_tx_bytes_offset;
> > bool offset_loaded;
> >
> > struct rte_eth_dev_data *dev_data; /* Pointer to the device data */
> > --
> > 2.7.4
>
> Do we need to clear the two new stats counters in i40e_pf_setup function?
> Just like clear pf->stats and pf->stats_offset.
Yes, it should be reset as other stats
Thanks for capture this.
Qi
prev parent reply other threads:[~2017-06-02 0:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 22:53 [dpdk-stable] " Qi Zhang
2017-06-01 9:12 ` [dpdk-stable] [dpdk-dev] " Xing, Beilei
2017-06-02 0:23 ` Zhang, Qi Z [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E70611530A7156@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=jingjing.wu@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).