From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: zhouyangchao <zhouyates@gmail.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/fm10k: remove RSS restriction with num of queues
Date: Tue, 5 Dec 2017 01:51:30 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E7061153119185@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <889ce4b6-5f2e-4830-a750-4c75ee0c7749@zyc-PC.local>
> -----Original Message-----
> From: zhouyangchao [mailto:zhouyates@gmail.com]
> Sent: Monday, December 4, 2017 2:38 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: [PATCH] net/fm10k: remove RSS restriction with num of queues
>
> FM10K HW does not have such restrictions.
>
> Enabling RSS with single queue is not used to distribute flow but to compute
> a RSS hash value.
> It can reduce cpu cycles of computing a hash value with five tuples.
> In addition, there is an explicit method to disable RSS instead of an obscure
> way.
>
> Signed-off-by: Yangchao Zhou <zhouyates@gmail.com>
> ---
> drivers/net/fm10k/fm10k_ethdev.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/fm10k/fm10k_ethdev.c
> b/drivers/net/fm10k/fm10k_ethdev.c
> index 2d05a46..403f6c5 100644
> --- a/drivers/net/fm10k/fm10k_ethdev.c
> +++ b/drivers/net/fm10k/fm10k_ethdev.c
> @@ -533,9 +533,8 @@ fm10k_dev_rss_configure(struct rte_eth_dev *dev)
> 0x6A, 0x42, 0xB7, 0x3B, 0xBE, 0xAC, 0x01, 0xFA,
> };
>
> - if (dev->data->nb_rx_queues == 1 ||
> - dev_conf->rxmode.mq_mode != ETH_MQ_RX_RSS ||
> - dev_conf->rx_adv_conf.rss_conf.rss_hf == 0) {
> + if (dev_conf->rxmode.mq_mode != ETH_MQ_RX_RSS ||
> + dev_conf->rx_adv_conf.rss_conf.rss_hf == 0) {
> FM10K_WRITE_REG(hw, FM10K_MRQC(0), 0);
> return;
> }
> --
> 2.9.0.windows.1
>
>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Regards
Qi
next parent reply other threads:[~2017-12-05 1:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <889ce4b6-5f2e-4830-a750-4c75ee0c7749@zyc-PC.local>
2017-12-05 1:51 ` Zhang, Qi Z [this message]
2017-12-04 6:38 zhouyangchao
2017-12-20 6:40 ` Zhang, Helin
[not found] <d51a98a0-33f0-44e8-a0e0-a90008f856ad@zyc-PC.local>
2017-11-29 6:54 ` Zhang, Qi Z
-- strict thread matches above, loose matches on Subject: below --
2017-11-29 6:12 zhouyangchao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E7061153119185@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=zhouyates@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).