From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Zhao1, Wei" <wei.zhao1@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix parsing fdir nvgre issue
Date: Fri, 22 Dec 2017 06:31:57 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E7061153123E91@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20171222054559.54207-1-wei.zhao1@intel.com>
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Friday, December 22, 2017 1:46 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [PATCH v2] net/ixgbe: fix parsing fdir nvgre issue
>
> There is some wrong of mask check in nvgre parser for flow API.
>
> Fixes: 11777435c727 ("net/ixgbe: parse flow director filter")
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
>
> ---
>
> V2:
> -change c_k_s_rsvd0_ver mask check to 0xFFFF.
> ---
> drivers/net/ixgbe/ixgbe_flow.c | 22 +++++++++++++++++++---
> 1 file changed, 19 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c
> index 19c2d47..887d933 100644
> --- a/drivers/net/ixgbe/ixgbe_flow.c
> +++ b/drivers/net/ixgbe/ixgbe_flow.c
> @@ -2466,8 +2466,7 @@ ixgbe_parse_fdir_filter_tunnel(const struct
> rte_flow_attr *attr,
> item, "Not supported by fdir filter");
> return -rte_errno;
> }
> - if (nvgre_mask->c_k_s_rsvd0_ver !=
> - rte_cpu_to_be_16(0x3000) ||
> + if (nvgre_mask->protocol &&
> nvgre_mask->protocol != 0xFFFF) {
> memset(rule, 0, sizeof(struct ixgbe_fdir_rule));
> rte_flow_error_set(error, EINVAL,
> @@ -2475,6 +2474,15 @@ ixgbe_parse_fdir_filter_tunnel(const struct
> rte_flow_attr *attr,
> item, "Not supported by fdir filter");
> return -rte_errno;
> }
> + if (nvgre_mask->c_k_s_rsvd0_ver &&
> + nvgre_mask->c_k_s_rsvd0_ver !=
> + rte_cpu_to_be_16(0xFFFF)) {
> + memset(rule, 0, sizeof(struct ixgbe_fdir_rule));
> + rte_flow_error_set(error, EINVAL,
> + RTE_FLOW_ERROR_TYPE_ITEM,
> + item, "Not supported by fdir filter");
> + return -rte_errno;
> + }
> /* TNI must be totally masked or not. */
> if (nvgre_mask->tni[0] &&
> ((nvgre_mask->tni[0] != 0xFF) ||
> @@ -2496,7 +2504,15 @@ ixgbe_parse_fdir_filter_tunnel(const struct
> rte_flow_attr *attr,
> nvgre_spec =
> (const struct rte_flow_item_nvgre *)item->spec;
> if (nvgre_spec->c_k_s_rsvd0_ver !=
> - rte_cpu_to_be_16(0x2000) ||
> + rte_cpu_to_be_16(0x2000) &&
> + nvgre_mask->c_k_s_rsvd0_ver) {
It's not necessary to && with a 0xffff, why not just keep consistent with how you handle the protocol field.
BTW, I missed the issue on the i40e patch, its better if you can also capture it.
Regards
Qi
> + memset(rule, 0, sizeof(struct ixgbe_fdir_rule));
> + rte_flow_error_set(error, EINVAL,
> + RTE_FLOW_ERROR_TYPE_ITEM,
> + item, "Not supported by fdir filter");
> + return -rte_errno;
> + }
> + if (nvgre_mask->protocol &&
> nvgre_spec->protocol !=
> rte_cpu_to_be_16(NVGRE_PROTOCOL)) {
> memset(rule, 0, sizeof(struct ixgbe_fdir_rule));
> --
> 2.9.3
next prev parent reply other threads:[~2017-12-22 6:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 5:51 [dpdk-dev] [PATCH] " Wei Zhao
2017-12-22 5:06 ` [dpdk-dev] [PATCH v2] " Wei Zhao
2017-12-22 5:45 ` Wei Zhao
2017-12-22 6:31 ` Zhang, Qi Z [this message]
2017-12-22 7:02 ` Zhang, Qi Z
2017-12-22 7:05 ` Zhang, Qi Z
2018-01-04 8:40 ` Lu, Wenzhuo
2018-01-09 6:54 ` Zhang, Helin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E7061153123E91@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=wei.zhao1@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).