From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Tan, Jianfeng" <jianfeng.tan@intel.com>,
'Maxime Coquelin' <maxime.coquelin@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>,
"santosh.shukla@caviumnetworks.com"
<santosh.shukla@caviumnetworks.com>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"stephen@networkplumber.org" <stephen@networkplumber.org>
Cc: "peterx@redhat.com" <peterx@redhat.com>
Subject: Re: [dpdk-stable] [PATCH v2] bus/pci: forbid VA as IOVA mode if IOMMU address width too small
Date: Fri, 12 Jan 2018 03:28:03 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E706115312BA1A@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <ED26CBA2FAD1BF48A8719AEF02201E36513B8177@SHSMSX103.ccr.corp.intel.com>
> -----Original Message-----
> From: Tan, Jianfeng
> Sent: Friday, January 12, 2018 11:01 AM
> To: 'Maxime Coquelin' <maxime.coquelin@redhat.com>; dev@dpdk.org;
> stable@dpdk.org; santosh.shukla@caviumnetworks.com; Burakov, Anatoly
> <anatoly.burakov@intel.com>; thomas@monjalon.net;
> stephen@networkplumber.org
> Cc: peterx@redhat.com; Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: RE: [PATCH v2] bus/pci: forbid VA as IOVA mode if IOMMU address
> width too small
>
>
>
> > -----Original Message-----
> > From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]
> > Sent: Tuesday, January 9, 2018 9:18 PM
> > To: dev@dpdk.org; stable@dpdk.org; Tan, Jianfeng;
> > santosh.shukla@caviumnetworks.com; Burakov, Anatoly;
> > thomas@monjalon.net; stephen@networkplumber.org
> > Cc: peterx@redhat.com; Maxime Coquelin
> > Subject: [PATCH v2] bus/pci: forbid VA as IOVA mode if IOMMU address
> > width too small
> >
> > Intel VT-d supports different address widths for the IOVAs, from
> > 39 bits to 56 bits.
> >
> > While recent processors support at least 48 bits, VT-d emulation
> > currently only supports 39 bits. It makes DMA mapping to fail in this
> > case when using VA as IOVA mode, as user-space virtual addresses uses
> > up to 47 bits (see kernel's Documentation/x86/x86_64/mm.txt).
> >
> > This patch parses VT-d CAP register value available in sysfs, and
> > forbid VA as IOVA mode if the GAW is 39 bits or unknown.
> >
> > Fixes: f37dfab21c98 ("drivers/net: enable IOVA mode for Intel PMDs")
> >
> > Cc: stable@dpdk.org
> > Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>
> I don't have strong objection on this patch. Plus, this patch has been verified
> with --no-huge, and Intel low-end processors (with the help of Zhang Qi).
Sorry, my bad, I just found it is tested with igb_uio.
re-tested it with vfio, seems VA width is no decoded correctly
I have sagaw = 4, which means 48b VA address, but the real device is 39, so IOVA is not disabled, still see that failure.
Thanks
Qi
>
> Tested-by: Jianfeng Tan <jianfeng.tan@intel.com>
>
> > ---
> >
> > Changes in v2:
> > ==============
> > - Rework pci_one_device_iommu_support_va #ifdefery (Stephen)
> > - Don't inline introduced functions (Stephen)
> >
> > drivers/bus/pci/linux/pci.c | 108
> > ++++++++++++++++++++++++++++++++++++++++----
> > 1 file changed, 99 insertions(+), 9 deletions(-)
> >
> > diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c
> > index 25f907e04..0a43c4b89 100644
> > --- a/drivers/bus/pci/linux/pci.c
> > +++ b/drivers/bus/pci/linux/pci.c
> > @@ -547,6 +547,100 @@ pci_one_device_has_iova_va(void)
> > return 0;
> > }
> >
> > +#if defined(RTE_ARCH_X86)
> > +static bool
> > +pci_one_device_iommu_support_va(struct rte_pci_device *dev) {
> > +#define VTD_CAP_SAGAW_SHIFT 8
> > +#define VTD_CAP_SAGAW_MASK (0x1fULL <<
> > VTD_CAP_SAGAW_SHIFT)
> > +#define X86_VA_WIDTH 47 /* From Documentation/x86/x86_64/mm.txt
> */
> > + struct rte_pci_addr *addr = &dev->addr;
> > + char filename[PATH_MAX];
> > + FILE *fp;
> > + uint64_t sagaw, vtd_cap_reg = 0;
> > + int guest_addr_width = 0;
> > +
> > + snprintf(filename, sizeof(filename),
> > + "%s/" PCI_PRI_FMT "/iommu/intel-iommu/cap",
> > + rte_pci_get_sysfs_path(), addr->domain, addr->bus, addr-
> > >devid,
> > + addr->function);
> > + if (access(filename, F_OK) == -1) {
> > + /* We don't have an Intel IOMMU, assume VA supported*/
>
> A nitpick: missed a space between "supported" and "*/"
>
> Thanks,
> Jianfeng
next prev parent reply other threads:[~2018-01-12 3:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 13:18 Maxime Coquelin
2018-01-11 20:19 ` Maxime Coquelin
2018-01-12 1:15 ` Tan, Jianfeng
2018-01-12 3:00 ` Tan, Jianfeng
2018-01-12 3:28 ` Zhang, Qi Z [this message]
2018-01-12 3:56 ` [dpdk-stable] [dpdk-dev] " Zhang, Qi Z
2018-01-12 8:21 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E706115312BA1A@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=jianfeng.tan@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=peterx@redhat.com \
--cc=santosh.shukla@caviumnetworks.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).