From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Yang, Zhiyong" <zhiyong.yang@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Zhao1, Wei" <wei.zhao1@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix bug in RSS flow action parser
Date: Thu, 25 Jan 2018 07:49:45 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E706115313392B@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <E182254E98A5DA4EB1E657AC7CB9BD2A8B02C7C3@BGSMSX101.gar.corp.intel.com>
> -----Original Message-----
> From: Yang, Zhiyong
> Sent: Thursday, January 25, 2018 2:03 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Xing, Beilei <beilei.xing@intel.com>
> Cc: dev@dpdk.org; Zhao1, Wei <wei.zhao1@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Subject: RE: [dpdk-dev] [PATCH] net/i40e: fix bug in RSS flow action parser
>
> Hi Qi,
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qi Zhang
> > Sent: Thursday, January 25, 2018 1:11 PM
> > To: Xing, Beilei <beilei.xing@intel.com>
> > Cc: dev@dpdk.org; Zhao1, Wei <wei.zhao1@intel.com>; Zhang, Qi Z
> > <qi.z.zhang@intel.com>
> > Subject: [dpdk-dev] [PATCH] net/i40e: fix bug in RSS flow action
> > parser
> >
> > Parameter action_flag is not used correctly in i40e_flow_parse_rss_action.
> > Also change it from point type to value type since it is not an output
> > parameter.
> >
> > Fixes: ecad87d22383e ("net/i40e: move RSS to flow API")
> >
> > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> > ---
> > drivers/net/i40e/i40e_flow.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/i40e/i40e_flow.c
> > b/drivers/net/i40e/i40e_flow.c index a74fa08ab..74708f168 100644
> > --- a/drivers/net/i40e/i40e_flow.c
> > +++ b/drivers/net/i40e/i40e_flow.c
> > @@ -4188,7 +4188,7 @@ static int
> > i40e_flow_parse_rss_action(struct rte_eth_dev *dev,
> > const struct rte_flow_action *actions,
> > struct rte_flow_error *error,
> > - uint8_t *action_flag,
> > + uint8_t action_flag,
> > struct i40e_queue_regions *conf_info,
> > union i40e_filter_t *filter)
> > {
> > @@ -4378,7 +4378,7 @@ i40e_parse_rss_filter(struct rte_eth_dev *dev,
> > return ret;
> >
> > ret = i40e_flow_parse_rss_action(dev, actions, error,
> > - &action_flag, &info, filter);
> > + action_flag, &info, filter);
>
> I wonder if action_flag == ture targets to handle only the case
> RTE_FLOW_ITEM_TYPE_ETH ?
Base on Zhao Wei's current design, action_flag is the flag to distinguish if queue region RSS is based on specific flow type ( when it is true) or based on vlan priority (when it is false)
Action_flag is decide by the pattern sequence eth only => 1, or eth +vlan | vlan only => 0
Regards
Qi
>
> Thanks
> Zhiyong
>
> > if (ret)
> > return ret;
> >
> > --
> > 2.13.6
>
next prev parent reply other threads:[~2018-01-25 7:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-25 5:10 Qi Zhang
2018-01-25 5:16 ` Zhao1, Wei
2018-01-26 9:51 ` Zhang, Helin
2018-01-25 5:28 ` Yang, Zhiyong
2018-01-25 6:02 ` Yang, Zhiyong
2018-01-25 7:49 ` Zhang, Qi Z [this message]
2018-01-25 8:01 ` Yang, Zhiyong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E706115313392B@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=wei.zhao1@intel.com \
--cc=zhiyong.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).