DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Wu, Yanglong" <yanglong.wu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Dai, Wei" <wei.dai@intel.com>, "Xing, Beilei" <beilei.xing@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/i40e: convert to new Rx offloads API
Date: Tue, 27 Mar 2018 12:41:08 +0000	[thread overview]
Message-ID: <039ED4275CED7440929022BC67E7061153174AA9@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20180327083103.163441-1-yanglong.wu@intel.com>

> +static int
> +i40e_check_rx_queue_offloads(struct rte_eth_dev *dev, uint64_t
> +requested) {
> +	struct rte_eth_dev_info dev_info;
> +	uint64_t mandatory = dev->data->dev_conf.rxmode.offloads;
> +	uint64_t supported; /* All per port offloads */
> +
> +	dev->dev_ops->dev_infos_get(dev, &dev_info);
> +	supported = dev_info.rx_offload_capa ^
> dev_info.rx_queue_offload_capa;
> +	if ((requested & dev_info.rx_queue_offload_capa) != requested)

Should be dev_info.rx_offload_capa here but not dev_info.rx_queue_offload_capa.

> +		return 0;
> +	return !((mandatory ^ requested) & supported); }
> +

  reply	other threads:[~2018-03-27 12:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-02  8:20 [dpdk-dev] [DPDK] " Yanglong Wu
2018-03-19  6:12 ` Zhang, Qi Z
2018-03-27  8:31 ` [dpdk-dev] [PATCH v2 1/2] " Yanglong Wu
2018-03-27 12:41   ` Zhang, Qi Z [this message]
2018-03-02  9:05 [dpdk-dev] [DPDK] net/i40e: convert to new Tx " Yanglong Wu
2018-03-27  8:49 ` [dpdk-dev] [PATCH v2 1/2] net/i40e: convert to new Rx " Yanglong Wu
2018-03-28  2:04 ` Yanglong Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=039ED4275CED7440929022BC67E7061153174AA9@SHSMSX103.ccr.corp.intel.com \
    --to=qi.z.zhang@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=wei.dai@intel.com \
    --cc=yanglong.wu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).