From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Zhao1, Wei" <wei.zhao1@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v4] net/i40e: add flow RSS queue index check
Date: Wed, 4 Apr 2018 13:25:40 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E706115318273D@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1522829163-63066-1-git-send-email-wei.zhao1@intel.com>
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Wednesday, April 4, 2018 4:06 PM
> To: dev@dpdk.org; stable@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [PATCH v4] net/i40e: add flow RSS queue index check
tile start with fix.
>
> There need a queue index check for RSS queue region in order to aviod error
> from configuration.
>
> Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> Tested-by: Peng Yuan <yuan.peng@intel.com>
Should be Tested-by: Yuan Peng <yuan.peng@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
>
> ---
>
> Changes in v2:
>
> move check code out from the big loop.
>
> change in v3:
>
> delete unnecessary dash in comment.
>
> change in v4:
>
> add more parameters check code.
> ---
> drivers/net/i40e/i40e_flow.c | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c index
> f3e8c5f..f4d08bb 100644
> --- a/drivers/net/i40e/i40e_flow.c
> +++ b/drivers/net/i40e/i40e_flow.c
> @@ -4216,6 +4216,32 @@ i40e_flow_parse_rss_action(struct rte_eth_dev
> *dev,
> }
> }
>
> + if (conf_info->queue_region_number) {
> + for (i = 0; i < rss->num; i++) {
> + for (j = 0; j < rss_info->num; j++) {
> + if (rss->queue[i] == rss_info->queue[j])
> + break;
> + }
> + if (j == rss_info->num) {
> + rte_flow_error_set(error, EINVAL,
> + RTE_FLOW_ERROR_TYPE_ACTION,
> + act,
> + "no valid queues");
> + return -rte_errno;
> + }
> + }
> +
> + for (i = 0; i < rss->num - 1; i++) {
> + if (rss->queue[i + 1] != rss->queue[i] + 1) {
> + rte_flow_error_set(error, EINVAL,
> + RTE_FLOW_ERROR_TYPE_ACTION,
> + act,
> + "no valid queues");
> + return -rte_errno;
> + }
> + }
> + }
> +
> for (n = 0; n < conf_info->queue_region_number; n++) {
> if (conf_info->region[n].user_priority_num ||
> conf_info->region[n].flowtype_num) {
> --
> 2.7.5
next prev parent reply other threads:[~2018-04-04 13:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 3:18 [dpdk-stable] [PATCH] " Wei Zhao
2018-04-04 3:59 ` Zhang, Qi Z
2018-04-04 4:02 ` Zhao1, Wei
2018-04-04 5:12 ` Zhao1, Wei
2018-04-04 5:00 ` [dpdk-stable] [PATCH v2] " Wei Zhao
2018-04-04 5:06 ` [dpdk-stable] [PATCH v3] " Wei Zhao
2018-04-04 8:06 ` [dpdk-stable] [PATCH v4] " Wei Zhao
2018-04-04 13:25 ` Zhang, Qi Z [this message]
2018-04-06 8:30 ` Zhang, Helin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E706115318273D@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=wei.zhao1@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).