From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Zhao1, Wei" <wei.zhao1@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] net/i40e: fix flow RSS queue index check error
Date: Mon, 9 Apr 2018 07:18:09 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E706115318CDA6@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1523165844-5362-1-git-send-email-wei.zhao1@intel.com>
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Sunday, April 8, 2018 1:37 PM
> To: dev@dpdk.org; stable@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [PATCH] net/i40e: fix flow RSS queue index check error
>
> Ther is a error in queue index check for RSS queue region configuration.
What is the error?
Would you explain more and please add this in commit log?
Regards
Qi
>
> Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> Tested-by: Peng Yuan <yuan.peng@intel.com>
> ---
> drivers/net/i40e/i40e_flow.c | 19 ++++++++-----------
> 1 file changed, 8 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c index
> f4d08bb..fb7ad51 100644
> --- a/drivers/net/i40e/i40e_flow.c
> +++ b/drivers/net/i40e/i40e_flow.c
> @@ -4240,6 +4240,14 @@ i40e_flow_parse_rss_action(struct rte_eth_dev
> *dev,
> return -rte_errno;
> }
> }
> +
> + if (rss_info->num < rss->num) {
> + rte_flow_error_set(error, EINVAL,
> + RTE_FLOW_ERROR_TYPE_ACTION,
> + act,
> + "no valid queues");
> + return -rte_errno;
> + }
> }
>
> for (n = 0; n < conf_info->queue_region_number; n++) { @@ -4264,17
> +4272,6 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev,
> return -rte_errno;
> }
>
> - if (rss_info->num < rss->num ||
> - rss->queue[0] < rss_info->queue[0] ||
> - (rss->queue[0] + rss->num >
> - rss_info->num + rss_info->queue[0])) {
> - rte_flow_error_set(error, EINVAL,
> - RTE_FLOW_ERROR_TYPE_ACTION,
> - act,
> - "no valid queues");
> - return -rte_errno;
> - }
> -
> for (i = 0; i < info->queue_region_number; i++) {
> if (info->region[i].queue_num == rss->num &&
> info->region[i].queue_start_index ==
> --
> 2.7.5
next prev parent reply other threads:[~2018-04-09 7:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-08 5:37 Wei Zhao
2018-04-09 7:18 ` Zhang, Qi Z [this message]
2018-04-09 8:37 ` [dpdk-stable] [PATCH v2] " Wei Zhao
2018-04-09 13:57 ` Zhang, Qi Z
2018-04-10 1:54 ` Zhao1, Wei
2018-04-10 2:19 ` Zhao1, Wei
2018-04-10 10:45 ` Zhang, Qi Z
2018-04-11 2:53 ` Zhao1, Wei
2018-04-11 3:24 ` [dpdk-stable] [PATCH v3] net/i40e: add comment and clean code for flow RSS Wei Zhao
2018-04-11 12:30 ` Zhang, Qi Z
2018-04-12 0:12 ` [dpdk-stable] [dpdk-dev] " Zhang, Helin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E706115318CDA6@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=wei.zhao1@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).