From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Wu, Yanglong" <yanglong.wu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Wang, Dong1" <dong1.wang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3] net/ixgbe: fix ixgbevf link status
Date: Thu, 26 Jul 2018 05:17:38 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E70611532602D9@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20180726022449.108272-1-yanglong.wu@intel.com>
> -----Original Message-----
> From: Wu, Yanglong
> Sent: Thursday, July 26, 2018 10:25 AM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Wang, Dong1
> <dong1.wang@intel.com>; Wu, Yanglong <yanglong.wu@intel.com>
> Subject: [PATCH v3] net/ixgbe: fix ixgbevf link status
>
> ixgbevf can't get right link status unless it check PF link status in wait mode.
>
> Fixes: dc66e5fd01b9 ("net/ixgbe: improve link state check on VF")
>
> Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
> ---
> v3:
> change to wait mode in ixgbevf
> ---
> v2:
> no need to set link status again
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index 26b192737..b90b352e3 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -4006,7 +4006,8 @@ ixgbe_dev_link_update_share(struct rte_eth_dev
> *dev,
> wait = 0;
>
> if (vf)
> - diag = ixgbevf_check_link(hw, &link_speed, &link_up, wait);
> + /* ixgbevf need to wait to get link status */
> + diag = ixgbevf_check_link(hw, &link_speed, &link_up, 1);
Sorry, I mislead you in our offline talk.
I think to implement a no_wait ops with a wait method may confuse the user, because an application may call rte_eth_link_get_nowait in the data path, we should not do any time consume tasks.
So maybe the reasonable way is return -ENOTSUP for a nowait request since ixgbevf can't support this due to hardware limitation.
And also the parameter " wait_to_complete" can be omitted in ixgbevf_check_link, since the nowait implementation is not correct and should be removed.
> else
> diag = ixgbe_check_link(hw, &link_speed, &link_up, wait);
>
> --
> 2.11.0
prev parent reply other threads:[~2018-07-26 5:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 3:05 [dpdk-dev] [PATCH] net/ixgbe: fix link status when link is NACK Yanglong Wu
2018-07-24 7:30 ` [dpdk-dev] [PATCH v2] " Yanglong Wu
2018-07-25 6:02 ` Zhang, Qi Z
2018-07-26 2:24 ` [dpdk-dev] [PATCH v3] net/ixgbe: fix ixgbevf link status Yanglong Wu
2018-07-26 2:49 ` Wang, Dong1
2018-07-26 5:17 ` Zhang, Qi Z [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E70611532602D9@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=dong1.wang@intel.com \
--cc=yanglong.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).