From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Xing, Beilei" <beilei.xing@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Stillwell Jr, Paul M" <paul.m.stillwell.jr@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v2] net/i40e: fix device arguments parsing error
Date: Thu, 26 Jul 2018 06:16:00 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E706115326036C@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1532571555-122490-1-git-send-email-beilei.xing@intel.com>
> -----Original Message-----
> From: Xing, Beilei
> Sent: Thursday, July 26, 2018 10:19 AM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; Stillwell Jr, Paul M <paul.m.stillwell.jr@intel.com>;
> stable@dpdk.org
> Subject: [PATCH v2] net/i40e: fix device arguments parsing error
>
> There's parsing error when using device argument support-multi-driver or
> queue-num-per-vf or both.
> Error log is "PMD: Error parsing device, invalid key <support-multi-driver>" and
> "PMD: Error parsing device, invalid key <queue-num-per-vf>". The root cause
> is that device argument will be parsed in different parsing functions with local
> valid key .
It seems the error log is hidden from the screen after some other patches,
but it's good to fix this to only record those real invalid parameters.
> This patch fixes the issue by combine all supported arguments's valid keys.
>
> Fixes: cfdfca493cae ("net/i40e: fix multiple driver support")
> Fixes: ee653bd80044 ("net/i40e: determine number of queues per VF at run
> time")
> Cc: stable@dpdk.org
>
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel
Thanks!
Qi
prev parent reply other threads:[~2018-07-26 6:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 6:36 [dpdk-stable] [PATCH] net/i40e: fix multiple " Beilei Xing
2018-07-25 12:43 ` Zhang, Qi Z
2018-07-26 2:19 ` [dpdk-stable] [PATCH v2] net/i40e: fix " Beilei Xing
2018-07-26 6:16 ` Zhang, Qi Z [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E706115326036C@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=paul.m.stillwell.jr@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).