From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Coyle, David" <david.coyle@intel.com>,
"Van Haaren, Harry" <harry.van.haaren@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Richardson, Bruce" <bruce.richardson@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"Xing, Beilei" <beilei.xing@intel.com>
Subject: Re: [dpdk-stable] [PATCH v2] net/i40e: fix avx2 driver check for rx rearm
Date: Wed, 1 Aug 2018 00:42:34 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E7061153262339@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <6CC82E0EC574F343969147E75534348B1D908C77@IRSMSX103.ger.corp.intel.com>
> -----Original Message-----
> From: Coyle, David
> Sent: Tuesday, July 31, 2018 10:25 PM
> To: Van Haaren, Harry <harry.van.haaren@intel.com>; dev@dpdk.org
> Cc: Richardson, Bruce <bruce.richardson@intel.com>; stable@dpdk.org;
> thomas@monjalon.net; Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Subject: RE: [PATCH v2] net/i40e: fix avx2 driver check for rx rearm
>
>
>
> -----Original Message-----
> From: Van Haaren, Harry
> Sent: Monday, July 30, 2018 6:34 PM
> To: dev@dpdk.org
> Cc: Van Haaren, Harry <harry.van.haaren@intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; stable@dpdk.org; thomas@monjalon.net;
> Coyle, David <david.coyle@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: [PATCH v2] net/i40e: fix avx2 driver check for rx rearm
>
> This commit fixes an infinite loop bug that could occur if the i40e AVX2 driver
> is used, and high traffic rates cause the mempool from which the rxq pulls
> mbufs to become empty.
>
> The result would be an infinite loop of checking if we should perform an rx
> rearm, calling the function and an error return due the the mempool being
> emtpy.
>
> The fix is to align the code in the AVX2 driver with the SSE driver, where an if()
> is used instead of a while(), allowing the thread to return from i40e rx
> function even if the mempool is empty.
>
> Fixes: dafadd73762e ("net/i40e: add AVX2 Rx function")
> Cc: bruce.richardson@intel.com
> Cc: stable@dpdk.org
>
> Reported-by: David Coyle <david.coyle@intel.com>
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> Acked-by: Brendan Ryan <brendan.ryan@intel.com>
> Tested-by: David Coyle <david.coyle@intel.com>
Applied to dpdk-next-net-intel.
Thanks!
Qi
prev parent reply other threads:[~2018-08-01 0:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 17:30 [dpdk-stable] [PATCH] " Harry van Haaren
2018-07-30 17:34 ` [dpdk-stable] [PATCH v2] " Harry van Haaren
2018-07-31 14:24 ` Coyle, David
2018-08-01 0:42 ` Zhang, Qi Z [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E7061153262339@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=david.coyle@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).