From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Yan, Zhirun" <zhirun.yan@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Wang, Haiyue" <haiyue.wang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3 1/2] net/i40e: support VF request more queues
Date: Thu, 13 Dec 2018 10:49:06 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E70611532FE60E@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20181213140505.14578-2-zhirun.yan@intel.com>
> -----Original Message-----
> From: Yan, Zhirun
> Sent: Thursday, December 13, 2018 10:05 PM
> To: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: Yan, Zhirun <zhirun.yan@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>
> Subject: [PATCH v3 1/2] net/i40e: support VF request more queues
>
> Before this patch, VF gets a default number of queues from the PF.
> This patch enables VF to request a different number. When VF configures more
> queues, it will send VIRTCHNL_OP_REQUEST_QUEUES to PF to request more
> queues, if success, PF will reset the VF.
>
> User can run "port stop all", "port config port_id rxq/txq queue_num"
> and "port start all" to reconfigure queue number.
>
> Signed-off-by: Zhirun Yan <zhirun.yan@intel.com>
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> ---
> drivers/net/i40e/i40e_ethdev_vf.c | 56 ++++++++++++++++++++++++++++---
> 1 file changed, 52 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
> b/drivers/net/i40e/i40e_ethdev_vf.c
> index cecedc91f..50e3f1f4f 100644
> --- a/drivers/net/i40e/i40e_ethdev_vf.c
> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
> @@ -343,6 +343,7 @@ i40evf_execute_vf_cmd(struct rte_eth_dev *dev, struct
> vf_cmd_info *args)
> err = 0;
> break;
> case VIRTCHNL_OP_VERSION:
> + case VIRTCHNL_OP_REQUEST_QUEUES:
> case VIRTCHNL_OP_GET_VF_RESOURCES:
> /* for init adminq commands, need to poll the response */
> err = -1;
> @@ -350,8 +351,15 @@ i40evf_execute_vf_cmd(struct rte_eth_dev *dev, struct
> vf_cmd_info *args)
> ret = i40evf_read_pfmsg(dev, &info);
> vf->cmd_retval = info.result;
> if (ret == I40EVF_MSG_CMD) {
> - err = 0;
> + if (info.ops != VIRTCHNL_OP_REQUEST_QUEUES)
> + err = 0;
> break;
> + } else if (ret == I40EVF_MSG_SYS) {
> + if (args->ops == VIRTCHNL_OP_REQUEST_QUEUES &&
OK, for VIRTCHNL_OP_REQUEST_QUEUES, we will ignore async reply (I40EVF_MSG_CMD) but only wait for system message (I40EVF_MSG_SYS)
I think it's better to create new branch for case VIRTCHNL_OP_REQUEST_QUEUES to make code more readable.
> + vf->vf_reset) {
> + err = 0;
> + break;
> + }
> } else if (ret == I40EVF_MSG_ERR)
> break;
> rte_delay_ms(ASQ_DELAY_MS);
next prev parent reply other threads:[~2018-12-13 10:49 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 16:58 [dpdk-dev] [PATCH v2 0/2] Support " Zhirun Yan
2018-11-28 16:58 ` [dpdk-dev] [PATCH v2 1/2] net/i40e: support VF " Zhirun Yan
2018-11-28 16:58 ` [dpdk-dev] [PATCH v2 2/2] net/i40e: support PF respond " Zhirun Yan
2018-12-13 14:05 ` [dpdk-dev] [PATCH v3 0/2] Support " Zhirun Yan
2018-12-13 14:05 ` [dpdk-dev] [PATCH v3 1/2] net/i40e: support VF " Zhirun Yan
2018-12-13 8:26 ` David Marchand
2018-12-14 3:17 ` Yan, Zhirun
2018-12-13 10:49 ` Zhang, Qi Z [this message]
2018-12-14 3:22 ` Yan, Zhirun
2018-12-13 14:05 ` [dpdk-dev] [PATCH v3 2/2] net/i40e: support PF respond " Zhirun Yan
2018-12-14 14:37 ` [dpdk-dev] [PATCH v4 0/2] Support " Zhirun Yan
2018-12-14 14:37 ` [dpdk-dev] [PATCH v4 1/2] net/i40e: support VF " Zhirun Yan
2018-12-14 11:59 ` Zhang, Qi Z
2018-12-17 3:12 ` Yan, Zhirun
2018-12-14 14:37 ` [dpdk-dev] [PATCH v4 2/2] net/i40e: support PF respond " Zhirun Yan
2018-12-17 11:10 ` [dpdk-dev] [PATCH v5 0/2] Support " Zhirun Yan
2018-12-17 5:31 ` Zhang, Qi Z
2018-12-17 11:10 ` [dpdk-dev] [PATCH v5 1/2] net/i40e: support VF " Zhirun Yan
2018-12-17 14:28 ` Ferruh Yigit
2018-12-18 1:44 ` Zhang, Qi Z
2018-12-17 14:31 ` Ferruh Yigit
2018-12-17 11:10 ` [dpdk-dev] [PATCH v5 2/2] net/i40e: support PF respond " Zhirun Yan
2018-12-17 14:26 ` Ferruh Yigit
2018-12-18 16:09 ` [dpdk-dev] [PATCH v6 0/3] Support " Zhirun Yan
2018-12-18 16:09 ` [dpdk-dev] [PATCH v6 1/3] net/i40e: support VF " Zhirun Yan
2018-12-18 12:44 ` Zhang, Qi Z
2018-12-19 1:34 ` Yan, Zhirun
2018-12-18 16:09 ` [dpdk-dev] [PATCH v6 2/3] net/i40e: support PF respond " Zhirun Yan
2018-12-18 16:09 ` [dpdk-dev] [PATCH v6 3/3] doc: update queue number per vf for i40e Zhirun Yan
2018-12-18 12:59 ` Zhang, Qi Z
2018-12-19 1:33 ` Yan, Zhirun
2018-12-19 13:08 ` [dpdk-dev] [PATCH v7 0/3] Support request more queues Zhirun Yan
2018-12-19 13:08 ` [dpdk-dev] [PATCH v7 1/3] net/i40e: support VF " Zhirun Yan
2018-12-19 13:08 ` [dpdk-dev] [PATCH v7 2/3] net/i40e: support PF respond " Zhirun Yan
2018-12-19 13:08 ` [dpdk-dev] [PATCH v7 3/3] doc: update queue number per vf for i40e Zhirun Yan
2018-12-19 13:37 ` [dpdk-dev] [PATCH v8 0/3] Support request more queues Zhirun Yan
2018-12-19 13:37 ` [dpdk-dev] [PATCH v8 1/3] net/i40e: support VF " Zhirun Yan
2018-12-19 13:37 ` [dpdk-dev] [PATCH v8 2/3] net/i40e: support PF respond " Zhirun Yan
2018-12-19 13:37 ` [dpdk-dev] [PATCH v8 3/3] doc: update queue number per vf for i40e Zhirun Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E70611532FE60E@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=haiyue.wang@intel.com \
--cc=zhirun.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).