From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: Leonid Myravjev <asm@asm.pp.ru>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/e1000: xstat RXERRC statictic register added.
Date: Thu, 13 Dec 2018 12:06:29 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E70611532FE69B@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20181205123514.7104-1-asm@asm.pp.ru>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Leonid Myravjev
> Sent: Wednesday, December 5, 2018 8:35 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Cc: dev@dpdk.org; Leonid Myravjev <asm@asm.pp.ru>
> Subject: [dpdk-dev] [PATCH] net/e1000: xstat RXERRC statictic register added.
>
> Signed-off-by: Leonid Myravjev <asm@asm.pp.ru>
> ---
> drivers/net/e1000/igb_ethdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
> index d9d29d22f..ebc242cd9 100644
> --- a/drivers/net/e1000/igb_ethdev.c
> +++ b/drivers/net/e1000/igb_ethdev.c
> @@ -458,6 +458,7 @@ struct rte_igb_xstats_name_off { static const struct
> rte_igb_xstats_name_off rte_igb_stats_strings[] = {
> {"rx_crc_errors", offsetof(struct e1000_hw_stats, crcerrs)},
> {"rx_align_errors", offsetof(struct e1000_hw_stats, algnerrc)},
> + {"rx_rx_errors", offsetof(struct e1000_hw_stats, rxerrc)},
I have no objection for this change, I just feel add all missing field (that be read from register in igb_read_stats_registers) in this array makes the patch complete.
Would do you think?
> {"rx_symbol_errors", offsetof(struct e1000_hw_stats, symerrs)},
> {"rx_missed_packets", offsetof(struct e1000_hw_stats, mpc)},
> {"tx_single_collision_packets", offsetof(struct e1000_hw_stats, scc)},
> --
> 2.17.1
prev parent reply other threads:[~2018-12-13 12:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 12:35 Leonid Myravjev
2018-12-13 12:06 ` Zhang, Qi Z [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E70611532FE69B@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=asm@asm.pp.ru \
--cc=dev@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).