From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Zhao1, Wei" <wei.zhao1@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Peng, Yuan" <yuan.peng@intel.com>
Subject: Re: [dpdk-stable] [PATCH v2 1/2] net/ixgbe: enable x550 flexible byte filter
Date: Wed, 2 Jan 2019 01:19:00 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E706115331096D@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1545716688-34608-2-git-send-email-wei.zhao1@intel.com>
HI Wei:
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Tuesday, December 25, 2018 1:45 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Peng, Yuan <yuan.peng@intel.com>; Zhao1, Wei
> <wei.zhao1@intel.com>
> Subject: [PATCH v2 1/2] net/ixgbe: enable x550 flexible byte filter
>
> There is need for users to use flexible byte filter on x550.
> x550 support IP mode and tunnel mode flexible byte filter.
> tunnel mode flexible byte filter is used for vxlan packets and so on. It can be
> used combined with FDIR tunnel filter.
> By now, ixgbe PMD flow parer code do not support tunnel mode flexible byte
> filter for x550, So I have to enable it in function ixgbe_parse_fdir_filter_tunnel().
> Although IP mode flexible byte filter parser is support in function
> ixgbe_parse_fdir_filter_normal(), but some flow like "flow create 0 ingress
> pattern raw pattern is 0xab / end actions queue index 3 / end" need to be
> support, so parser code also need change a little.
> This patch enable all of these feature.
I would suggest to divide this patch into 3 patches
1. more accurate input set mask setup (include all changes in ixgbe_fdir.c)
2. support flexbyte without IP layer (include changes in ixgbe_parse_fdir_filter_normal)
3. support flexbyte in tunnel mode (include changes in ixgbe_parse_fdir_flilter_tunnel)
Btw, please make sure to sync the acceptable flow pattern/action description above function ixgbe_parse_fdir_filter_xxxxx to their new behaviors
Thanks
Qi
next prev parent reply other threads:[~2019-01-02 1:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 5:53 [dpdk-stable] [PATCH] " Zhao Wei
2018-12-17 6:19 ` Zhao1, Wei
2018-12-24 12:13 ` Zhang, Qi Z
2018-12-25 2:04 ` Zhao1, Wei
2018-12-25 5:44 ` [dpdk-stable] [PATCH v2 0/2] " Wei Zhao
2018-12-25 5:44 ` [dpdk-stable] [PATCH v2 1/2] net/ixgbe: " Wei Zhao
2019-01-02 1:19 ` Zhang, Qi Z [this message]
2019-01-02 1:53 ` Zhao1, Wei
2019-01-02 2:25 ` Zhang, Qi Z
2018-12-25 5:44 ` [dpdk-stable] [PATCH v2 2/2] app/testpmd: add support of hex string parser for flow API Wei Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E706115331096D@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=wei.zhao1@intel.com \
--cc=wenzhuo.lu@intel.com \
--cc=yuan.peng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).