DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Zhao1, Wei" <wei.zhao1@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/ice: fix item number when pattern has ETH
Date: Tue, 16 Jul 2019 01:13:31 +0000	[thread overview]
Message-ID: <039ED4275CED7440929022BC67E7061153D67568@SHSMSX105.ccr.corp.intel.com> (raw)
In-Reply-To: <1563181362-29513-1-git-send-email-wei.zhao1@intel.com>



> -----Original Message-----
> From: Zhao1, Wei
> Sent: Monday, July 15, 2019 5:03 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [PATCH] net/ice: fix item number when pattern has ETH
> 
> When pattern has ETH, maybe it will contain MAC and ethertype two kinds of
> lookup parameters, so add more item number for memory malloc.
> 
> Signed-off-by: wei zhao <wei.zhao1@intel.com>
> ---
>  drivers/net/ice/ice_switch_filter.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ice/ice_switch_filter.c
> b/drivers/net/ice/ice_switch_filter.c
> index 5424223..6ec50fb 100644
> --- a/drivers/net/ice/ice_switch_filter.c
> +++ b/drivers/net/ice/ice_switch_filter.c
> @@ -435,6 +435,8 @@ ice_create_switch_filter(struct ice_pf *pf,
>  			tun_type = ICE_SW_TUN_VXLAN;
>  		if (item->type == RTE_FLOW_ITEM_TYPE_NVGRE)
>  			tun_type = ICE_SW_TUN_NVGRE;
> +		if (item->type == RTE_FLOW_ITEM_TYPE_ETH)

I would suggest add some comment here like 
"reserve one more slot for ETH which may consume 2 lookup items" 
to help others easy to understand.

> +			item_num++;
>  	}
>  	rule_info.tun_type = tun_type;
> 
> --
> 2.7.5


  reply	other threads:[~2019-07-16  1:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-15  9:02 Wei Zhao
2019-07-16  1:13 ` Zhang, Qi Z [this message]
2019-07-16  2:08 ` [dpdk-dev] [PATCH v2] " Wei Zhao
2019-07-16  2:36   ` [dpdk-dev] [PATCH v3] " Wei Zhao
2019-07-16  7:30     ` Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=039ED4275CED7440929022BC67E7061153D67568@SHSMSX105.ccr.corp.intel.com \
    --to=qi.z.zhang@intel.com \
    --cc=dev@dpdk.org \
    --cc=wei.zhao1@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).