From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Rong, Leyi" <leyi.rong@intel.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Ye, Xiaolong" <xiaolong.ye@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/iavf: set CMD bit2 to 1 in Tx Desc of AVX Tx path
Date: Tue, 12 Nov 2019 01:55:59 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E7061153DC7CBA@SHSMSX105.ccr.corp.intel.com> (raw)
In-Reply-To: <20191107052144.78380-1-leyi.rong@intel.com>
> -----Original Message-----
> From: Rong, Leyi <leyi.rong@intel.com>
> Sent: Thursday, November 7, 2019 1:22 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Ye, Xiaolong <xiaolong.ye@intel.com>
> Cc: dev@dpdk.org; Rong, Leyi <leyi.rong@intel.com>
> Subject: [PATCH] net/iavf: set CMD bit2 to 1 in Tx Desc of AVX Tx path
>
> Fix iavf vf_checksum_sw case fail in X710/XXV710, set bit2 to 1 of CMD field in
> Tx descriptor of AVX Tx path according to Spec.
>
> Fixes: af0c246a3800 ("net/iavf: enable AVX2 for iavf")
>
> Signed-off-by: Leyi Rong <leyi.rong@intel.com>
> ---
> drivers/net/iavf/iavf_rxtx_vec_avx2.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/iavf/iavf_rxtx_vec_avx2.c
> b/drivers/net/iavf/iavf_rxtx_vec_avx2.c
> index f0c00be56..2c7375576 100644
> --- a/drivers/net/iavf/iavf_rxtx_vec_avx2.c
> +++ b/drivers/net/iavf/iavf_rxtx_vec_avx2.c
> @@ -785,8 +785,9 @@ iavf_xmit_fixed_burst_vec_avx2(void *tx_queue,
> struct rte_mbuf **tx_pkts,
> volatile struct iavf_tx_desc *txdp;
> struct iavf_tx_entry *txep;
> uint16_t n, nb_commit, tx_id;
> - uint64_t flags = IAVF_TX_DESC_CMD_EOP;
> - uint64_t rs = IAVF_TX_DESC_CMD_RS | IAVF_TX_DESC_CMD_EOP;
> + /* bit2 is reserved and must be set to 1 according to Spec */
> + uint64_t flags = IAVF_TX_DESC_CMD_EOP | 0x04;
Better to use macro IAVF_TX_DESC_CMD_ICRC to replace 0x4
> + uint64_t rs = IAVF_TX_DESC_CMD_RS | flags;
>
> /* cross rx_thresh boundary is not allowed */
> nb_pkts = RTE_MIN(nb_pkts, txq->rs_thresh);
> --
> 2.17.1
next prev parent reply other threads:[~2019-11-12 1:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 5:21 Leyi Rong
2019-11-12 1:55 ` Zhang, Qi Z [this message]
2019-11-12 2:42 ` [dpdk-dev] [PATCH v2] " Leyi Rong
2019-11-12 3:00 ` Zhang, Qi Z
2019-11-13 2:28 ` Ye Xiaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E7061153DC7CBA@SHSMSX105.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=leyi.rong@intel.com \
--cc=wenzhuo.lu@intel.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).