From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: "Vargas, Hernan" <hernan.vargas@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"gakhil@marvell.com" <gakhil@marvell.com>,
"Rix, Tom" <trix@redhat.com>
Cc: "Chautru, Nicolas" <nicolas.chautru@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>
Subject: Re: [PATCH v1 08/13] test/bbdev: extend support for large TB
Date: Mon, 20 Feb 2023 16:40:25 +0100 [thread overview]
Message-ID: <05a63c31-04cd-6aba-29b2-708987de9432@redhat.com> (raw)
In-Reply-To: <DM6PR11MB36609F0E42A0B3052EEA9A89EFDD9@DM6PR11MB3660.namprd11.prod.outlook.com>
On 2/13/23 21:20, Vargas, Hernan wrote:
> Hi Maxime,
>
>> -----Original Message-----
>> From: Maxime Coquelin <maxime.coquelin@redhat.com>
>> Sent: Tuesday, January 31, 2023 5:29 AM
>> To: Vargas, Hernan <hernan.vargas@intel.com>; dev@dpdk.org;
>> gakhil@marvell.com; Rix, Tom <trix@redhat.com>
>> Cc: Chautru, Nicolas <nicolas.chautru@intel.com>; Zhang, Qi Z
>> <qi.z.zhang@intel.com>
>> Subject: Re: [PATCH v1 08/13] test/bbdev: extend support for large TB
>>
>>
>>
>> On 1/17/23 17:50, Hernan Vargas wrote:
>>> Add support for large TB when it cannot fit into a true mbuf.
>>>
>>> Signed-off-by: Hernan Vargas <hernan.vargas@intel.com>
>>> ---
>>> app/test-bbdev/test_bbdev_perf.c | 21 ++++++++++++---------
>>> 1 file changed, 12 insertions(+), 9 deletions(-)
>>>
>>> diff --git a/app/test-bbdev/test_bbdev_perf.c
>>> b/app/test-bbdev/test_bbdev_perf.c
>>> index 69b86cdeb1..fdf7a28ba2 100644
>>> --- a/app/test-bbdev/test_bbdev_perf.c
>>> +++ b/app/test-bbdev/test_bbdev_perf.c
>>> @@ -1072,8 +1072,6 @@ init_op_data_objs(struct rte_bbdev_op_data
>> *bufs,
>>> * Special case when DPDK mbuf cannot handle
>>> * the required input size
>>> */
>>> - printf("Warning: Larger input size than DPDK mbuf
>> %d\n",
>>> - seg->length);
>>> large_input = true;
>>> }
>>> bufs[i].data = m_head;
>>> @@ -2030,6 +2028,7 @@ validate_op_chain(struct rte_bbdev_op_data
>> *op,
>>> struct rte_mbuf *m = op->data;
>>> uint8_t nb_dst_segments = orig_op->nb_segments;
>>> uint32_t total_data_size = 0;
>>> + bool ignore_mbuf = false; /* ignore mbuf limitations */
>>>
>>> TEST_ASSERT(nb_dst_segments == m->nb_segs,
>>> "Number of segments differ in original (%u) and filled
>> (%u) op",
>>> @@ -2042,21 +2041,25 @@ validate_op_chain(struct rte_bbdev_op_data
>> *op,
>>> uint16_t data_len = rte_pktmbuf_data_len(m) - offset;
>>> total_data_size += orig_op->segments[i].length;
>>>
>>> - TEST_ASSERT(orig_op->segments[i].length == data_len,
>>> - "Length of segment differ in original (%u) and
>> filled (%u) op",
>>> - orig_op->segments[i].length, data_len);
>>> + if (orig_op->segments[i].length >
>> RTE_BBDEV_LDPC_E_MAX_MBUF)
>>> + ignore_mbuf = true;
>>> + if (!ignore_mbuf)
>>> + TEST_ASSERT(orig_op->segments[i].length ==
>> data_len,
>>> + "Length of segment differ in original
>> (%u) and filled (%u) op",
>>> + orig_op->segments[i].length,
>> data_len);
>>> TEST_ASSERT_BUFFERS_ARE_EQUAL(orig_op-
>>> segments[i].addr,
>>> rte_pktmbuf_mtod_offset(m, uint32_t *,
>> offset),
>>> - data_len,
>>> + orig_op->segments[i].length,
>>
>> Isn't it ending up in performing out of bounds access in the mbuf?
>
> No, in the case when ignore_mbuf is set to true, we use a "fake" mbuf allocated in memory with rte_malloc.
> The size allocated is segments[i].length.
Ok.
Thanks,
Maxime
> Thanks
>
>>> "Output buffers (CB=%u) are not equal", i);
>>> m = m->next;
>>> }
>>>
>>> /* Validate total mbuf pkt length */
>>> uint32_t pkt_len = rte_pktmbuf_pkt_len(op->data) - op->offset;
>>> - TEST_ASSERT(total_data_size == pkt_len,
>>> - "Length of data differ in original (%u) and filled (%u)
>> op",
>>> - total_data_size, pkt_len);
>>> + if (!ignore_mbuf)
>>> + TEST_ASSERT(total_data_size == pkt_len,
>>> + "Length of data differ in original (%u) and
>> filled (%u) op",
>>> + total_data_size, pkt_len);
>>>
>>> return TEST_SUCCESS;
>>> }
>
next prev parent reply other threads:[~2023-02-20 15:40 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 16:50 [PATCH v1 00/13] test/bbdev: changes for 23.03 Hernan Vargas
2023-01-17 16:50 ` [PATCH v1 01/13] test/bbdev: fix seg fault for non supported HARQ len Hernan Vargas
2023-01-31 9:20 ` Maxime Coquelin
2023-01-17 16:50 ` [PATCH v1 02/13] test/bbdev: refactor TB throughput report Hernan Vargas
2023-01-31 9:48 ` Maxime Coquelin
2023-01-17 16:50 ` [PATCH v1 03/13] test/bbdev: add timeout for latency tests Hernan Vargas
2023-01-31 10:02 ` Maxime Coquelin
2023-01-17 16:50 ` [PATCH v1 04/13] test/bbdev: early termination not explicit set Hernan Vargas
2023-01-31 10:04 ` Maxime Coquelin
2023-02-10 17:15 ` Vargas, Hernan
2023-02-20 15:38 ` Maxime Coquelin
2023-01-17 16:50 ` [PATCH v1 05/13] test/bbdev: report device status in bbdev-test Hernan Vargas
2023-01-31 10:05 ` Maxime Coquelin
2023-01-17 16:50 ` [PATCH v1 06/13] test/bbdev: log capture from queue stop Hernan Vargas
2023-01-31 10:07 ` Maxime Coquelin
2023-01-17 16:50 ` [PATCH v1 07/13] test/bbdev: add support for BLER for 4G Hernan Vargas
2023-01-31 10:20 ` Maxime Coquelin
2023-02-13 20:59 ` Vargas, Hernan
2023-02-20 15:43 ` Maxime Coquelin
2023-02-22 21:55 ` Vargas, Hernan
2023-02-23 8:26 ` Maxime Coquelin
2023-01-17 16:50 ` [PATCH v1 08/13] test/bbdev: extend support for large TB Hernan Vargas
2023-01-31 11:29 ` Maxime Coquelin
2023-02-13 20:20 ` Vargas, Hernan
2023-02-20 15:40 ` Maxime Coquelin [this message]
2023-01-17 16:50 ` [PATCH v1 09/13] test/bbdev: bbdev-test cannot compare some scenarios Hernan Vargas
2023-01-31 12:15 ` Maxime Coquelin
2023-02-13 19:40 ` Chautru, Nicolas
2023-01-17 16:50 ` [PATCH v1 10/13] test/bbdev: adjustment for soft output Hernan Vargas
2023-01-31 12:25 ` Maxime Coquelin
2023-01-17 16:50 ` [PATCH v1 11/13] test/bbdev: expose warning counters Hernan Vargas
2023-01-31 12:26 ` Maxime Coquelin
2023-01-17 16:50 ` [PATCH v1 12/13] test/bbdev: remove check for invalid opaque data Hernan Vargas
2023-01-31 12:33 ` Maxime Coquelin
2023-01-17 16:50 ` [PATCH v1 13/13] test/bbdev: remove iteration count check Hernan Vargas
2023-01-31 12:35 ` Maxime Coquelin
2023-02-08 20:38 ` Vargas, Hernan
2023-02-09 9:10 ` Maxime Coquelin
2023-02-09 16:59 ` Chautru, Nicolas
2023-02-10 14:01 ` Maxime Coquelin
2023-02-10 18:11 ` Chautru, Nicolas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05a63c31-04cd-6aba-29b2-708987de9432@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=hernan.vargas@intel.com \
--cc=nicolas.chautru@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).