From: "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>
To: Akhil Goyal <akhil.goyal@nxp.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Trahe, Fiona" <fiona.trahe@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 2/3] crypto/qat: fix message for CCM when setting unused counter
Date: Fri, 14 Dec 2018 14:39:47 +0000 [thread overview]
Message-ID: <06EE24DD0B19E248B53F6DC8657831551B1104EC@hasmsx109.ger.corp.intel.com> (raw)
In-Reply-To: <2931ba83-50ed-6f3e-b22c-69946a4ce06c@nxp.com>
Hi Akhil,
> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Friday, December 14, 2018 3:23 PM
> To: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Cc: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 2/3] crypto/qat: fix message for CCM when
> setting unused counter
>
>
>
> On 12/13/2018 1:29 AM, Arek Kusztal wrote:
> > AES-CCM algo does not to set counter flag so it should be zeroed.
> >
> > Fixes: ab56c4d9ed9a ("crypto/qat: support AES-CCM")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> > ---
> > drivers/crypto/qat/qat_sym_session.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/crypto/qat/qat_sym_session.c
> b/drivers/crypto/qat/qat_sym_session.c
> > index 272177f..d8cc702 100644
> > --- a/drivers/crypto/qat/qat_sym_session.c
> > +++ b/drivers/crypto/qat/qat_sym_session.c
> > @@ -1488,6 +1488,7 @@ int
> qat_sym_session_aead_create_cd_auth(struct qat_sym_session *cdesc,
> > || cdesc->qat_hash_alg ==
> ICP_QAT_HW_AUTH_ALGO_KASUMI_F9
> > || cdesc->qat_hash_alg ==
> ICP_QAT_HW_AUTH_ALGO_ZUC_3G_128_EIA3
> > || cdesc->qat_hash_alg ==
> ICP_QAT_HW_AUTH_ALGO_AES_XCBC_MAC
> > + || cdesc->qat_hash_alg ==
> ICP_QAT_HW_AUTH_ALGO_AES_CBC_MAC
> > )
> > hash->auth_counter.counter = 0;
> > else {
> title and code change do not match.
> AES-CCM or AES-CBC??
CCM is AEAD mode where Counter for cipher and CBC-MAC for hash is used. Hence CBC-MAC for hash. Ref. RFC 3610, SP800-38C.
Thanks,
Arek
next prev parent reply other threads:[~2018-12-14 14:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181212195904.8160-1-arkadiuszx.kusztal@intel.com>
2018-12-12 19:59 ` [dpdk-stable] [PATCH 1/3] crypto/qat: handle error msg of block size properly Arek Kusztal
2018-12-17 12:12 ` [dpdk-stable] [dpdk-dev] " Kovacevic, Marko
2018-12-12 19:59 ` [dpdk-stable] [PATCH 2/3] crypto/qat: fix message for CCM when setting unused counter Arek Kusztal
2018-12-14 14:23 ` [dpdk-stable] [dpdk-dev] " Akhil Goyal
2018-12-14 14:39 ` Kusztal, ArkadiuszX [this message]
2018-12-17 12:16 ` Kovacevic, Marko
2018-12-12 19:59 ` [dpdk-stable] [PATCH 3/3] crypto/qat: fix message for NULL algo " Arek Kusztal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06EE24DD0B19E248B53F6DC8657831551B1104EC@hasmsx109.ger.corp.intel.com \
--to=arkadiuszx.kusztal@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).