From: "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>
To: Akhil Goyal <akhil.goyal@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Trahe, Fiona" <fiona.trahe@intel.com>
Subject: Re: [dpdk-dev] [PATCH v5 2/4] crypto/qat: add asymmetric cryptography PMD
Date: Wed, 3 Apr 2019 09:05:40 +0000 [thread overview]
Message-ID: <06EE24DD0B19E248B53F6DC8657831551B14F762@hasmsx109.ger.corp.intel.com> (raw)
In-Reply-To: <687a0c64-f267-188b-9a87-de74449fcf0d@nxp.com>
Hi Akhil,
Thanks a lot for that, let me know if anything else is needed.
> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Wednesday, April 3, 2019 10:42 AM
> To: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; dev@dpdk.org
> Cc: Trahe, Fiona <fiona.trahe@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v5 2/4] crypto/qat: add asymmetric
> cryptography PMD
>
> Hi Arek,
>
> On 3/28/2019 7:07 PM, Arek Kusztal wrote:
> > This patch adds Poll Mode Driver for asymmetric crypto functions of
> > Intel QuickAssist Technology hardware.
> >
> > It contains plain driver with no functions implmented, specific
> > algorithms will be introduced in separate patches.
> >
> > This patch depends on a QAT PF driver for device initialization. See
> > the file docs/guides/cryptodevs/qat.rst for configuration details.
> >
> > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> > ---
> > config/common_base | 1 +
> > doc/guides/cryptodevs/qat.rst | 7 +
> > drivers/common/qat/Makefile | 8 +
> > drivers/common/qat/qat_device.h | 12 +-
> > drivers/common/qat/qat_qp.c | 8 +
> > drivers/crypto/qat/meson.build | 5 +-
> > drivers/crypto/qat/qat_asym.c | 236 ++++++++++++++++++++++
> > drivers/crypto/qat/qat_asym.h | 97 +++++++++
> > drivers/crypto/qat/qat_asym_capabilities.h | 10 +
> > drivers/crypto/qat/qat_asym_pmd.c | 308
> +++++++++++++++++++++++++++++
> > drivers/crypto/qat/qat_asym_pmd.h | 50 +++++
> > drivers/crypto/qat/qat_sym_pmd.c | 1 -
> > drivers/crypto/qat/qat_sym_pmd.h | 3 +-
> > mk/rte.app.mk | 1 +
> > 14 files changed, 742 insertions(+), 5 deletions(-)
> > create mode 100644 drivers/crypto/qat/qat_asym.c
> > create mode 100644 drivers/crypto/qat/qat_asym.h
> > create mode 100644 drivers/crypto/qat/qat_asym_capabilities.h
> > create mode 100644 drivers/crypto/qat/qat_asym_pmd.c
> > create mode 100644 drivers/crypto/qat/qat_asym_pmd.h
> >
> > diff --git a/config/common_base b/config/common_base index
> > 0b09a93..d1dd66a 100644
> > --- a/config/common_base
> > +++ b/config/common_base
> > @@ -545,6 +545,7 @@ CONFIG_RTE_LIBRTE_PMD_OCTEONTX_CRYPTO=y
> > #
> > CONFIG_RTE_LIBRTE_PMD_QAT=y
> > CONFIG_RTE_LIBRTE_PMD_QAT_SYM=n
> > +CONFIG_RTE_LIBRTE_PMD_QAT_ASYM=n
> > #
> > # Max. number of QuickAssist devices, which can be detected and
> attached
> > #
> > diff --git a/doc/guides/cryptodevs/qat.rst
> > b/doc/guides/cryptodevs/qat.rst index da9655c..53a8d61 100644
> > --- a/doc/guides/cryptodevs/qat.rst
> > +++ b/doc/guides/cryptodevs/qat.rst
> > @@ -101,7 +101,13 @@ of all the items described above, including the
> padding at the end.
> > Also, offset of data to authenticate "op.sym.auth.data.offset"
> > must be such that points at the start of the COUNT bytes.
> >
> > +Asymmetric Crypto Service on QAT
> > +-------------------------------
>
> doc/guides/cryptodevs/qat.rst:105: WARNING: Title underline too short.
>
>
> here one '-' is less. I corrected this while applying the patch.
>
> > +
> > +The QAT Asym PMD has support for:
> >
> > +Limitations
> > +~~~~~~~~~~~
> >
next prev parent reply other threads:[~2019-04-03 9:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-28 13:36 [dpdk-dev] [PATCH v5 0/4] Add PMD for asymmetric cryptography operations using Intel QuickAssist Technology devices Arek Kusztal
2019-03-28 13:36 ` Arek Kusztal
2019-03-28 13:37 ` [dpdk-dev] [PATCH v5 1/4] common/qat: add headers for asymmetric crypto Arek Kusztal
2019-03-28 13:37 ` Arek Kusztal
2019-03-28 13:37 ` [dpdk-dev] [PATCH v5 2/4] crypto/qat: add asymmetric cryptography PMD Arek Kusztal
2019-03-28 13:37 ` Arek Kusztal
2019-04-03 8:42 ` Akhil Goyal
2019-04-03 8:42 ` Akhil Goyal
2019-04-03 9:05 ` Kusztal, ArkadiuszX [this message]
2019-04-03 9:05 ` Kusztal, ArkadiuszX
2019-03-28 13:37 ` [dpdk-dev] [PATCH v5 3/4] crypto/qat: add modular exponentiation to qat asym pmd Arek Kusztal
2019-03-28 13:37 ` Arek Kusztal
2019-03-28 13:37 ` [dpdk-dev] [PATCH v5 4/4] crypto/qat: add modular inverse " Arek Kusztal
2019-03-28 13:37 ` Arek Kusztal
2019-03-28 13:57 ` [dpdk-dev] [PATCH v5 0/4] Add PMD for asymmetric cryptography operations using Intel QuickAssist Technology devices Trahe, Fiona
2019-03-28 13:57 ` Trahe, Fiona
2019-03-29 14:27 ` Akhil Goyal
2019-03-29 14:27 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06EE24DD0B19E248B53F6DC8657831551B14F762@hasmsx109.ger.corp.intel.com \
--to=arkadiuszx.kusztal@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).