DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: "Ding, Xuan" <xuan.ding@intel.com>, "Xia, Chenbo" <chenbo.xia@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Hu, Jiayu" <jiayu.hu@intel.com>,
	"He, Xingguang" <xingguang.he@intel.com>,
	"Yang, YvonneX" <yvonnex.yang@intel.com>,
	"Jiang, Cheng1" <cheng1.jiang@intel.com>
Subject: Re: [PATCH] vhost: fix unnecessary dirty page logging
Date: Fri, 8 Jul 2022 09:57:56 +0200	[thread overview]
Message-ID: <070ac224-e3f1-9bb4-d526-b1c5096b1924@redhat.com> (raw)
In-Reply-To: <BN9PR11MB5513860CFAB99E4C09D710C3E7829@BN9PR11MB5513.namprd11.prod.outlook.com>

Hi,

On 7/8/22 09:04, Ding, Xuan wrote:
> Hi,
> 
>> -----Original Message-----
>> From: Maxime Coquelin <maxime.coquelin@redhat.com>
>> Sent: 2022年7月7日 19:31
>> To: Xia, Chenbo <chenbo.xia@intel.com>; Ding, Xuan <xuan.ding@intel.com>
>> Cc: dev@dpdk.org; Hu, Jiayu <jiayu.hu@intel.com>; He, Xingguang
>> <xingguang.he@intel.com>; Yang, YvonneX <yvonnex.yang@intel.com>; Jiang,
>> Cheng1 <cheng1.jiang@intel.com>
>> Subject: Re: [PATCH] vhost: fix unnecessary dirty page logging
>>
>>
>>
>> On 7/7/22 11:51, Xia, Chenbo wrote:
>>>> -----Original Message-----
>>>> From: Ding, Xuan <xuan.ding@intel.com>
>>>> Sent: Thursday, July 7, 2022 2:55 PM
>>>> To: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>
>>>> Cc: dev@dpdk.org; Hu, Jiayu <jiayu.hu@intel.com>; He, Xingguang
>>>> <xingguang.he@intel.com>; Yang, YvonneX <yvonnex.yang@intel.com>;
>>>> Jiang,
>>>> Cheng1 <cheng1.jiang@intel.com>; Ding, Xuan <xuan.ding@intel.com>
>>>> Subject: [PATCH] vhost: fix unnecessary dirty page logging
>>>>
>>>> From: Xuan Ding <xuan.ding@intel.com>
>>>>
>>>> The dirty page logging is only required in vhost enqueue direction
>>>> for live migration. This patch removes the unnecessary dirty page
>>>> logging in vhost dequeue direction. Otherwise, it will result in a
>>>> performance drop. Some if-else judgements are also optimized to improve
>> performance.
>>>>
>>>> Fixes: 6d823bb302c7 ("vhost: prepare sync for descriptor to mbuf
>>>> refactoring")
>>>> Fixes: b6eee3e83402 ("vhost: fix sync dequeue offload")
>>>>
>>>> Signed-off-by: Xuan Ding <xuan.ding@intel.com>
>>>> ---
>>>
>>> Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
>>>
>>> Although it's late in release, we can consider to merge this as I see
>>> it impacts the performance by 5%:
>>>
>> http://inbox.dpdk.org/dev/BYAPR11MB2711F13CDA2B0A4535A6591EFE839@B
>> YAPR
>>> 11MB2711.namprd11.prod.outlook.com/T/#t
>>
>> Yes, I raised we need it in -rc4 at today's Release status meeting.
>> I'll review it today.
>>
>>> But also, it will be good to know the performance issue is solved by
>>> sharing the test results.
>>
>> Yes, Intel performance results would be appreciated.
> 
> This fix patch is for the issue reported at 22.07-rc3. The refactoring patch brings a 3%~5% perf drop in vhost sync path.
> With fix patch, the perf drop introduced by refactoring is solved.

Good.

> However, the testing result shows there still exists ~5% packed ring perf drop compared with 22.03.
> We find the improving checksum offload patch series in 22.07 may contribute to the packed ring perf drop.
> Because we always do checksum checks in PMD.
> 
> Could you help to double check this patch series, is it as expected?
> Your assistance is really appreciated.

I will look again, but if your analysis is right, there's not much we
can do. The series is filling gaps in the checksum offload support.

I will not have time to work on it for v22.07, we're too late in the
cycle. What surprises me is that only packed ring is impacted.

Regards,
Maxime

> 
> Regards,
> Xuan
> 
>>
>>> Thanks,
>>> Chenbo
>>>
>>
>> Thanks,
>> Maxime
> 


  parent reply	other threads:[~2022-07-08  7:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-07  6:55 xuan.ding
2022-07-07  8:23 ` Hu, Jiayu
2022-07-07  9:51 ` Xia, Chenbo
2022-07-07 11:30   ` Maxime Coquelin
2022-07-08  7:04     ` Ding, Xuan
2022-07-08  7:53       ` He, Xingguang
2022-07-08  8:13         ` He, Xingguang
2022-07-08  7:57       ` Maxime Coquelin [this message]
2022-07-08  8:09         ` Ding, Xuan
2022-07-11  8:09           ` He, Xingguang
2022-07-07 12:04 ` Maxime Coquelin
2022-07-08  9:11 ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=070ac224-e3f1-9bb4-d526-b1c5096b1924@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=chenbo.xia@intel.com \
    --cc=cheng1.jiang@intel.com \
    --cc=dev@dpdk.org \
    --cc=jiayu.hu@intel.com \
    --cc=xingguang.he@intel.com \
    --cc=xuan.ding@intel.com \
    --cc=yvonnex.yang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).