From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, <dev@dpdk.org>
Cc: Chas Williams <chas3@att.com>
Subject: Re: [dpdk-dev] [PATCH] net/af_packet: fix build failure because of unused parameter
Date: Mon, 25 Sep 2017 12:04:20 +0300 [thread overview]
Message-ID: <080aa50a-14bc-c298-9a49-d83e026c53ab@solarflare.com> (raw)
In-Reply-To: <535fdb9a-f892-afcd-77e5-4f87e68e2024@intel.com>
On 09/25/2017 11:42 AM, Ferruh Yigit wrote:
> On 9/25/2017 7:50 AM, Andrew Rybchenko wrote:
>> Failure happens on build using:
>> gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-4)
> Yes, that case is missed. What do you think about following one:
>
> @@ -561,7 +561,7 @@ rte_pmd_init_internals(struct rte_vdev_device *dev,
> unsigned int blockcnt,
> unsigned int framesize,
> unsigned int framecnt,
> - unsigned int qdisc_bypass,
> + unsigned int qdisc_bypass __rte_unused,
> struct pmd_internals **internals,
> struct rte_eth_dev **eth_dev,
> struct rte_kvargs *kvlist)
It is OK for me as well, but I've not chosen it since it could be treated as
always unused.
>> Fixes: 0d16c17ae7a4 ("net/af_packet: make qdisc bypass configurable")
>>
>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
>> ---
>> May be the right solution in fact remove PACKET_QDISC_BYPASS conditional
>> completely. If below solution is accepted, feel free to squash it into
>> the original patch.
> It is a little to late for this, I already sent a pull-request with this
> patch. So fix will need to be a separate patch.
Sad, if it means that the build will be broken in main DPDK repo as well.
Not critical, but a bit inconvenient.
> <...>
next prev parent reply other threads:[~2017-09-25 9:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 6:50 Andrew Rybchenko
2017-09-25 8:42 ` Ferruh Yigit
2017-09-25 9:04 ` Andrew Rybchenko [this message]
2017-09-25 9:40 ` Bruce Richardson
2017-09-25 9:53 ` Ferruh Yigit
2017-09-25 10:06 ` Ferruh Yigit
2017-09-25 12:49 ` Ferruh Yigit
2017-09-25 14:24 ` Thomas Monjalon
2017-09-25 12:52 ` Ferruh Yigit
2017-09-25 12:53 ` Ferruh Yigit
2017-10-05 18:05 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=080aa50a-14bc-c298-9a49-d83e026c53ab@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=chas3@att.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).