From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Bruce Richardson <bruce.richardson@intel.com>,
dev@dpdk.org, thomas@monjalon.net
Subject: Re: [dpdk-dev] [PATCH v2 0/5] consolidate testing apps to app dir
Date: Wed, 20 Feb 2019 11:47:05 +0000 [thread overview]
Message-ID: <089a7d55-c827-d4a9-2820-a5a160d0e2a6@intel.com> (raw)
In-Reply-To: <20190219145308.65668-1-bruce.richardson@intel.com>
On 2/19/2019 2:53 PM, Bruce Richardson wrote:
> The apps for testing are split between the "test" and "app" directories,
> with a not-very-clear distinction between the two (at least to my mind).
>
> Given how the apps are being built, the easiest path to having
> cmdline_test, test-acl and test-pipeline build using meson is to
> consolidate all these apps back into the app folder and use the logic
> there. The bpf folder doesn't contain an actual application, but
> rather example bpf code which can be loaded into testpmd. That is
> possibly best moved to the examples folder, but I'm open to feedback
> on the best place for it.
>
> With these changes, the "test" folder then becomes the location for
> unit tests only. However, we can simplify things a little by moving
> that too to the app folder, eliminating the need for the separate
> "test-build" make target, and aligning the output folder for the
> binary from "make test-build" with the source file location in app.
I agree distinction between the "test" and "app" is not very clear, my
motivation to split them was make building test code optional.
But when split them we have a few cases that tests broken but not recognized for
a while, since we don't have continuous integration that verifies tests perhaps
it can be better to force developers to build them each time to detect issues.
And as far as I understand this split is causing complications for adding meson
support, if this will make easy to extend meson support overall patchset looks
good to me.
Thanks,
ferruh
>
> ---
> V2: * Following some discussion with Thomas, moved the autotests to the
> app folder too.
> * Updated maintainers file appropriately in each patch.
>
> Bruce Richardson (5):
> test/cmdline_test: move to app directory
> test/test-acl: move to app directory
> test/test-pipeline: move to app directory
> test/bpf: move to examples folder
> test/test: move to app folder
next prev parent reply other threads:[~2019-02-20 11:47 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 20:26 [dpdk-dev] [PATCH 0/4] RFC: " Bruce Richardson
2019-01-25 20:26 ` [dpdk-dev] [PATCH 1/4] test/cmdline_test: move to app directory Bruce Richardson
2019-01-25 20:26 ` [dpdk-dev] [PATCH 2/4] test/test-acl: " Bruce Richardson
2019-01-25 20:26 ` [dpdk-dev] [PATCH 3/4] test/test-pipeline: " Bruce Richardson
2019-01-25 20:26 ` [dpdk-dev] [PATCH 4/4] test/bpf: move to examples folder Bruce Richardson
2019-01-25 20:30 ` [dpdk-dev] [PATCH 0/4] RFC: consolidate testing apps to app dir Bruce Richardson
2019-01-29 11:40 ` Thomas Monjalon
2019-01-29 11:52 ` Bruce Richardson
2019-02-19 14:53 ` [dpdk-dev] [PATCH v2 0/5] " Bruce Richardson
2019-02-19 14:53 ` [dpdk-dev] [PATCH v2 1/5] test/cmdline_test: move to app directory Bruce Richardson
2019-02-26 9:14 ` Thomas Monjalon
2019-02-26 10:00 ` Bruce Richardson
2019-02-26 11:24 ` Bruce Richardson
2019-02-26 12:20 ` Bruce Richardson
2019-02-19 14:53 ` [dpdk-dev] [PATCH v2 2/5] test/test-acl: " Bruce Richardson
2019-02-19 14:53 ` [dpdk-dev] [PATCH v2 3/5] test/test-pipeline: " Bruce Richardson
2019-02-19 14:53 ` [dpdk-dev] [PATCH v2 4/5] test/bpf: move to examples folder Bruce Richardson
2019-02-20 9:35 ` Ananyev, Konstantin
2019-02-20 9:39 ` Bruce Richardson
2019-02-20 9:42 ` Ananyev, Konstantin
2019-02-20 10:35 ` Thomas Monjalon
2019-02-25 16:22 ` Ananyev, Konstantin
2019-02-19 14:53 ` [dpdk-dev] [PATCH v2 5/5] test/test: move to app folder Bruce Richardson
2019-02-20 11:47 ` Ferruh Yigit [this message]
2019-02-25 15:34 ` [dpdk-dev] [PATCH v2 0/5] consolidate testing apps to app dir Bruce Richardson
2019-02-26 12:18 ` [dpdk-dev] [PATCH v3 " Bruce Richardson
2019-02-26 12:18 ` [dpdk-dev] [PATCH v3 1/5] test/cmdline_test: move to app directory Bruce Richardson
2019-02-26 12:19 ` [dpdk-dev] [PATCH v3 2/5] test/test-acl: " Bruce Richardson
2019-02-26 12:27 ` Ananyev, Konstantin
2019-02-26 12:19 ` [dpdk-dev] [PATCH v3 3/5] test/test-pipeline: " Bruce Richardson
2019-02-26 12:19 ` [dpdk-dev] [PATCH v3 4/5] test/bpf: move to examples folder Bruce Richardson
2019-02-26 12:19 ` [dpdk-dev] [PATCH v3 5/5] test/test: move to app folder Bruce Richardson
2019-02-26 14:40 ` [dpdk-dev] [PATCH v3 0/5] consolidate testing apps to app dir Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=089a7d55-c827-d4a9-2820-a5a160d0e2a6@intel.com \
--to=ferruh.yigit@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).