DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Pei, Andy" <andy.pei@intel.com>
To: "Xia, Chenbo" <chenbo.xia@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
	"Cao, Gang" <gang.cao@intel.com>,
	"Liu, Changpeng" <changpeng.liu@intel.com>
Subject: RE: [PATCH v6 03/16] vhost: add vhost msg support
Date: Tue, 26 Apr 2022 08:55:32 +0000	[thread overview]
Message-ID: <08f0027681ff4583bf46a835a5e8c9ef@intel.com> (raw)
In-Reply-To: <SN6PR11MB35046DE1337F031A22E806E29CF89@SN6PR11MB3504.namprd11.prod.outlook.com>

HI Chenbo, 

Thanks for your reply.
My reply is inline.

> -----Original Message-----
> From: Xia, Chenbo <chenbo.xia@intel.com>
> Sent: Monday, April 25, 2022 8:42 PM
> To: Pei, Andy <andy.pei@intel.com>; dev@dpdk.org
> Cc: maxime.coquelin@redhat.com; Cao, Gang <gang.cao@intel.com>; Liu,
> Changpeng <changpeng.liu@intel.com>
> Subject: RE: [PATCH v6 03/16] vhost: add vhost msg support
> 
> Hi Andy,
> 
> > -----Original Message-----
> > From: Pei, Andy <andy.pei@intel.com>
> > Sent: Thursday, April 21, 2022 4:34 PM
> > To: dev@dpdk.org
> > Cc: Xia, Chenbo <chenbo.xia@intel.com>; maxime.coquelin@redhat.com;
> > Cao, Gang <gang.cao@intel.com>; Liu, Changpeng
> > <changpeng.liu@intel.com>
> > Subject: [PATCH v6 03/16] vhost: add vhost msg support
> >
> > Add support for VHOST_USER_GET_CONFIG and
> VHOST_USER_SET_CONFIG.
> > VHOST_USER_GET_CONFIG and VHOST_USER_SET_CONFIG message is only
> > supported by virtio blk VDPA device.
> >
> > Signed-off-by: Andy Pei <andy.pei@intel.com>
> > ---
> >  lib/vhost/vhost_user.c | 69
> > ++++++++++++++++++++++++++++++++++++++++++++++++++
> >  lib/vhost/vhost_user.h | 13 ++++++++++
> >  2 files changed, 82 insertions(+)
> >
> > diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c index
> > 1d39067..3780804 100644
> > --- a/lib/vhost/vhost_user.c
> > +++ b/lib/vhost/vhost_user.c
> > @@ -80,6 +80,8 @@
> >  	[VHOST_USER_NET_SET_MTU]  = "VHOST_USER_NET_SET_MTU",
> >  	[VHOST_USER_SET_SLAVE_REQ_FD]  =
> "VHOST_USER_SET_SLAVE_REQ_FD",
> >  	[VHOST_USER_IOTLB_MSG]  = "VHOST_USER_IOTLB_MSG",
> > +	[VHOST_USER_GET_CONFIG]  = "VHOST_USER_GET_CONFIG",
> > +	[VHOST_USER_SET_CONFIG]  = "VHOST_USER_SET_CONFIG",
> >  	[VHOST_USER_CRYPTO_CREATE_SESS] =
> "VHOST_USER_CRYPTO_CREATE_SESS",
> >  	[VHOST_USER_CRYPTO_CLOSE_SESS] =
> "VHOST_USER_CRYPTO_CLOSE_SESS",
> >  	[VHOST_USER_POSTCOPY_ADVISE]  =
> "VHOST_USER_POSTCOPY_ADVISE", @@
> > -2542,6 +2544,71 @@ static int is_vring_iotlb(struct virtio_net *dev,
> > }
> >
> >  static int
> > +vhost_user_get_config(struct virtio_net **pdev,
> > +			struct vhu_msg_context *ctx,
> > +			int main_fd __rte_unused)
> > +{
> > +	struct virtio_net *dev = *pdev;
> > +	struct rte_vdpa_device *vdpa_dev = dev->vdpa_dev;
> > +	int ret = 0;
> > +
> > +	if (vdpa_dev->ops->get_config) {
> > +		ret = vdpa_dev->ops->get_config(dev->vid,
> > +					   ctx->msg.payload.cfg.region,
> > +					   ctx->msg.payload.cfg.size);
> > +		if (ret != 0) {
> > +			ctx->msg.size = 0;
> > +			VHOST_LOG_CONFIG(ERR,
> > +					 "(%s) get_config() return error!\n",
> > +					 dev->ifname);
> > +		}
> > +	} else {
> > +		VHOST_LOG_CONFIG(ERR, "(%s) get_config() not
> supportted!\n",
> 
> Supported
> 
I will send out a new version to fix this.
> > +				 dev->ifname);
> > +	}
> > +
> > +	return RTE_VHOST_MSG_RESULT_REPLY;
> > +}
> > +
> > +static int
> > +vhost_user_set_config(struct virtio_net **pdev,
> > +			struct vhu_msg_context *ctx,
> > +			int main_fd __rte_unused)
> > +{
> > +	struct virtio_net *dev = *pdev;
> > +	struct rte_vdpa_device *vdpa_dev = dev->vdpa_dev;
> > +	int ret = 0;
> > +
> > +	if (ctx->msg.size != sizeof(struct vhost_user_config)) {
> 
> I think you should do sanity check on payload.cfg.size and make sure it's
> smaller than VHOST_USER_MAX_CONFIG_SIZE
> 
> and same check for offset
> 
I think payload.cfg.size can be smaller than or equal to VHOST_USER_MAX_CONFIG_SIZE.
payload.cfg.ofset can be smaller than or equal to VHOST_USER_MAX_CONFIG_SIZE as well

> > +		VHOST_LOG_CONFIG(ERR,
> > +			"(%s) invalid set config msg size: %"PRId32" != %d\n",
> > +			dev->ifname, ctx->msg.size,
> 
> Based on you will change the log too, payload.cfg.size is uint32_t, so PRId32 ->
> PRIu32
> 
> > +			(int)sizeof(struct vhost_user_config));
> 
> So this can be %u
> 
Sure.
> > +		goto OUT;
> > +	}
> > +
> > +	if (vdpa_dev->ops->set_config) {
> > +		ret = vdpa_dev->ops->set_config(dev->vid,
> > +			ctx->msg.payload.cfg.region,
> > +			ctx->msg.payload.cfg.offset,
> > +			ctx->msg.payload.cfg.size,
> > +			ctx->msg.payload.cfg.flags);
> > +		if (ret)
> > +			VHOST_LOG_CONFIG(ERR,
> > +					 "(%s) set_config() return error!\n",
> > +					 dev->ifname);
> > +	} else {
> > +		VHOST_LOG_CONFIG(ERR, "(%s) set_config() not
> supportted!\n",
> 
> Supported
> 
I will send out a new version to fix this.
> > +				 dev->ifname);
> > +	}
> > +
> > +	return RTE_VHOST_MSG_RESULT_OK;
> > +
> > +OUT:
> 
> Lower case looks better
> 
OK. I will send out a new version to fix this.
> > +	return RTE_VHOST_MSG_RESULT_ERR;
> > +}
> 
> Almost all handlers need check on expected fd num (this case is 0), so the
> above new handlers should also do that. Please refer to validate_msg_fds in
> other handlers.
> 
> BTW, you can wait for review for other patches and send new versions later.
> 
I will send out new patch after vhost: validate fds attached to messages from David Marchand is merged.
> Thanks,
> Chenbo
> 
> > +
> > +static int
> >  vhost_user_iotlb_msg(struct virtio_net **pdev,
> >  			struct vhu_msg_context *ctx,
> >  			int main_fd __rte_unused)
> > @@ -2782,6 +2849,8 @@ typedef int (*vhost_message_handler_t)(struct
> > virtio_net **pdev,
> >  	[VHOST_USER_NET_SET_MTU] = vhost_user_net_set_mtu,
> >  	[VHOST_USER_SET_SLAVE_REQ_FD] = vhost_user_set_req_fd,
> >  	[VHOST_USER_IOTLB_MSG] = vhost_user_iotlb_msg,
> > +	[VHOST_USER_GET_CONFIG] = vhost_user_get_config,
> > +	[VHOST_USER_SET_CONFIG] = vhost_user_set_config,
> >  	[VHOST_USER_POSTCOPY_ADVISE] =
> vhost_user_set_postcopy_advise,
> >  	[VHOST_USER_POSTCOPY_LISTEN] = vhost_user_set_postcopy_listen,
> >  	[VHOST_USER_POSTCOPY_END] = vhost_user_postcopy_end, diff --
> git
> > a/lib/vhost/vhost_user.h b/lib/vhost/vhost_user.h index
> > c946cc2..97cfb2f 100644
> > --- a/lib/vhost/vhost_user.h
> > +++ b/lib/vhost/vhost_user.h
> > @@ -50,6 +50,8 @@
> >  	VHOST_USER_NET_SET_MTU = 20,
> >  	VHOST_USER_SET_SLAVE_REQ_FD = 21,
> >  	VHOST_USER_IOTLB_MSG = 22,
> > +	VHOST_USER_GET_CONFIG = 24,
> > +	VHOST_USER_SET_CONFIG = 25,
> >  	VHOST_USER_CRYPTO_CREATE_SESS = 26,
> >  	VHOST_USER_CRYPTO_CLOSE_SESS = 27,
> >  	VHOST_USER_POSTCOPY_ADVISE = 28,
> > @@ -125,6 +127,16 @@
> >  	uint16_t queue_size;
> >  } VhostUserInflight;
> >
> > +#define VHOST_USER_MAX_CONFIG_SIZE		256
> > +
> > +/** Get/set config msg payload */
> > +struct vhost_user_config {
> > +	uint32_t offset;
> > +	uint32_t size;
> > +	uint32_t flags;
> > +	uint8_t region[VHOST_USER_MAX_CONFIG_SIZE];
> > +};
> > +
> >  typedef struct VhostUserMsg {
> >  	union {
> >  		uint32_t master; /* a VhostUserRequest value */ @@ -148,6
> +160,7 @@
> >  		VhostUserCryptoSessionParam crypto_session;
> >  		VhostUserVringArea area;
> >  		VhostUserInflight inflight;
> > +		struct vhost_user_config cfg;
> >  	} payload;
> >  	/* Nothing should be added after the payload */  } __rte_packed
> > VhostUserMsg;
> > --
> > 1.8.3.1
> 


  reply	other threads:[~2022-04-26  8:55 UTC|newest]

Thread overview: 263+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-25  6:47 [PATCH 00/15] add virtio_blk device support to vdpa/ifc Andy Pei
2022-01-25  6:47 ` [PATCH 01/15] vdpa/ifc: add support for virtio blk device Andy Pei
2022-01-25  9:37   ` [PATCH v2 00/15] add virtio_blk device support to vdpa/ifc Andy Pei
2022-01-25  9:37     ` [PATCH v2 01/15] vdpa/ifc: add support for virtio blk device Andy Pei
2022-01-25  9:37     ` [PATCH v2 02/15] vhost: add vdpa ops for " Andy Pei
2022-01-25  9:37     ` [PATCH v2 03/15] vdpa/ifc: add blk ops for ifc device Andy Pei
2022-01-25  9:37     ` [PATCH v2 04/15] vdpa/ifc: add vdpa interrupt for blk device Andy Pei
2022-01-25  9:37     ` [PATCH v2 05/15] vdpa/ifc: add blk dev sw live migration Andy Pei
2022-01-25  9:37     ` [PATCH v2 06/15] example/vdpa:add vdpa blk support in example Andy Pei
2022-01-25  9:37     ` [PATCH v2 07/15] usertools: add support for virtio blk device Andy Pei
2022-01-25  9:37     ` [PATCH v2 08/15] vdpa/ifc: set_vring_state op is mandatory, add set_vring_state for " Andy Pei
2022-01-25  9:37     ` [PATCH v2 09/15] vdpa/ifc: add some log at VDPA launch before qemu connect Andy Pei
2022-01-25  9:37     ` [PATCH v2 10/15] vdpa/ifc: read virtio max_queues from hardware Andy Pei
2022-01-25  9:37     ` [PATCH v2 11/15] vdpa: add config space change interrupt register and handle for virtio_blk Andy Pei
2022-01-25  9:37     ` [PATCH v2 12/15] vdpa/ifc: add is_blk flag to ifcvf_hw, and init is_blk during probe Andy Pei
2022-01-25  9:37     ` [PATCH v2 13/15] vdpa/ifc/base: for blk device, live migration register is different from net device Andy Pei
2022-01-25  9:37     ` [PATCH v2 14/15] vdpa/ifc: make sure hardware last_avail_idx and last_used_idx is the same when blk device pause Andy Pei
2022-01-25  9:37     ` [PATCH v2 15/15] vhost: make sure each queue callfd is configured Andy Pei
2022-01-27  7:13       ` Xia, Chenbo
2022-01-29  3:11         ` Pei, Andy
2022-01-29  3:03   ` [PATCH v3 00/15] add virtio_blk device support to vdpa/ifc Andy Pei
2022-01-29  3:03     ` [PATCH v3 01/15] vdpa/ifc: add support for virtio blk device Andy Pei
2022-03-22  8:57       ` Maxime Coquelin
2022-01-29  3:03     ` [PATCH v3 02/15] vhost: add vdpa ops for " Andy Pei
2022-03-22  9:12       ` Maxime Coquelin
2022-01-29  3:03     ` [PATCH v3 03/15] vdpa/ifc: add blk ops for ifc device Andy Pei
2022-03-22  9:58       ` Maxime Coquelin
2022-01-29  3:03     ` [PATCH v3 04/15] vdpa/ifc: add vdpa interrupt for blk device Andy Pei
2022-03-22 10:04       ` Maxime Coquelin
2022-03-23  7:07         ` Pei, Andy
2022-03-23  7:42           ` Pei, Andy
2022-01-29  3:03     ` [PATCH v3 05/15] vdpa/ifc: add blk dev sw live migration Andy Pei
2022-03-22 11:10       ` Maxime Coquelin
2022-03-23  9:08         ` Pei, Andy
2022-01-29  3:03     ` [PATCH v3 06/15] example/vdpa:add vdpa blk support in example Andy Pei
2022-03-22 11:29       ` Maxime Coquelin
2022-03-23  9:31         ` Pei, Andy
2022-01-29  3:03     ` [PATCH v3 07/15] usertools: add support for virtio blk device Andy Pei
2022-01-29  3:03     ` [PATCH v3 08/15] vdpa/ifc: set_vring_state op is mandatory, add set_vring_state for " Andy Pei
2022-01-29  3:03     ` [PATCH v3 09/15] vdpa/ifc: add some log at VDPA launch before qemu connect Andy Pei
2022-01-29  3:03     ` [PATCH v3 10/15] vdpa/ifc: read virtio max_queues from hardware Andy Pei
2022-01-29  3:03     ` [PATCH v3 11/15] vdpa: add config space change interrupt register and handle for virtio_blk Andy Pei
2022-01-29  3:03     ` [PATCH v3 12/15] vdpa/ifc: add is_blk flag to ifcvf_hw, and init is_blk during probe Andy Pei
2022-01-29  3:03     ` [PATCH v3 13/15] vdpa/ifc/base: for blk device, live migration register is different from net device Andy Pei
2022-01-29  3:03     ` [PATCH v3 14/15] vdpa/ifc: make sure hardware last_avail_idx and last_used_idx are the same when blk device pause Andy Pei
2022-01-29  3:03     ` [PATCH v3 15/15] vhost: make sure each queue callfd is configured Andy Pei
2022-03-27 14:51   ` [PATCH v4 00/16] add virtio_blk device support to vdpa/ifc Andy Pei
2022-03-27 14:51     ` [PATCH v4 01/16] vdpa/ifc: add support for virtio blk device Andy Pei
2022-03-27 14:51     ` [PATCH v4 02/16] vhost: add vdpa ops for " Andy Pei
2022-03-27 14:51     ` [PATCH v4 03/16] vhost: add support for VHOST_USER_GET_CONFIG and VHOST_USER_SET_CONFIG Andy Pei
2022-03-27 14:51     ` [PATCH v4 04/16] vdpa/ifc: add blk ops for ifc device Andy Pei
2022-03-27 14:51     ` [PATCH v4 05/16] vdpa/ifc: add vdpa interrupt for blk device Andy Pei
2022-03-27 14:51     ` [PATCH v4 06/16] vdpa/ifc: add block device SW live-migration Andy Pei
2022-03-27 14:51     ` [PATCH v4 07/16] example/vdpa:add vdpa blk support in example Andy Pei
2022-03-27 14:51     ` [PATCH v4 08/16] usertools: add support for virtio blk device Andy Pei
2022-03-27 20:01       ` Stephen Hemminger
2022-03-27 14:51     ` [PATCH v4 09/16] vdpa/ifc: set_vring_state op is mandatory, add set_vring_state for " Andy Pei
2022-03-27 14:51     ` [PATCH v4 10/16] vdpa/ifc: add some log at VDPA lauch before qemu connect Andy Pei
2022-03-27 14:51     ` [PATCH v4 11/16] vdpa/ifc: read virtio max_queues from hardware Andy Pei
2022-03-27 14:51     ` [PATCH v4 12/16] vdpa: add config space change interrupt register and handle for virtio_blk Andy Pei
2022-03-27 14:51     ` [PATCH v4 13/16] vdpa/ifc: add is_blk flag to ifcvf_hw, and init is_blk during probe Andy Pei
2022-03-27 14:51     ` [PATCH v4 14/16] vdpa/ifc/base: for blk device, live migration register is different from net device Andy Pei
2022-03-27 14:51     ` [PATCH v4 15/16] vdpa/ifc: make sure hardware last_avail_idx and last_used_idx is the same when blk device pause Andy Pei
2022-03-27 14:51     ` [PATCH v4 16/16] vhost: make sure each queue callfd is configured Andy Pei
2022-03-28  7:17   ` [PATCH v5 00/16] add virtio_blk device support to vdpa/ifc Andy Pei
2022-03-28  7:17     ` [PATCH v5 01/16] vdpa/ifc: add support for virtio blk device Andy Pei
2022-03-28  7:17     ` [PATCH v5 02/16] vhost: add vdpa ops for " Andy Pei
2022-03-28  7:17     ` [PATCH v5 03/16] vhost: add support for VHOST_USER_GET_CONFIG and VHOST_USER_SET_CONFIG Andy Pei
2022-04-20 13:53       ` Xia, Chenbo
2022-04-21  8:05         ` Pei, Andy
2022-03-28  7:17     ` [PATCH v5 04/16] vdpa/ifc: add blk ops for ifc device Andy Pei
2022-03-28  7:17     ` [PATCH v5 05/16] vdpa/ifc: add vdpa interrupt for blk device Andy Pei
2022-03-28  7:17     ` [PATCH v5 06/16] vdpa/ifc: add block device SW live-migration Andy Pei
2022-03-28  7:17     ` [PATCH v5 07/16] example/vdpa:add vdpa blk support in example Andy Pei
2022-03-28  7:17     ` [PATCH v5 08/16] usertools: add support for virtio blk device Andy Pei
2022-03-28  7:17     ` [PATCH v5 09/16] vdpa/ifc: set_vring_state op is mandatory, add set_vring_state for " Andy Pei
2022-03-28  7:17     ` [PATCH v5 10/16] vdpa/ifc: add some log at VDPA launch before qemu connect Andy Pei
2022-03-28  7:17     ` [PATCH v5 11/16] vdpa/ifc: read virtio max_queues from hardware Andy Pei
2022-03-28  7:17     ` [PATCH v5 12/16] vdpa: add config space change interrupt register and handle for virtio_blk Andy Pei
2022-03-28  7:17     ` [PATCH v5 13/16] vdpa/ifc: add is_blk flag to ifcvf_hw, and init is_blk during probe Andy Pei
2022-03-28  7:17     ` [PATCH v5 14/16] vdpa/ifc/base: for blk device, live migration register is different from net device Andy Pei
2022-03-28  7:17     ` [PATCH v5 15/16] vdpa/ifc: make sure hardware last_avail_idx and last_used_idx is the same when blk device pause Andy Pei
2022-03-28  7:17     ` [PATCH v5 16/16] vhost: make sure each queue callfd is configured Andy Pei
2022-04-21  8:33   ` [PATCH v6 00/16] add virtio_blk device support to vdpa/ifc Andy Pei
2022-04-21  8:33     ` [PATCH v6 01/16] vdpa/ifc: add support for virtio blk device Andy Pei
2022-04-21  8:33     ` [PATCH v6 02/16] vhost: add vDPA ops for " Andy Pei
2022-04-21  8:33     ` [PATCH v6 03/16] vhost: add vhost msg support Andy Pei
2022-04-25 12:42       ` Xia, Chenbo
2022-04-26  8:55         ` Pei, Andy [this message]
2022-04-26  9:17           ` Xia, Chenbo
2022-04-27  4:12             ` Pei, Andy
2022-04-25 13:04       ` David Marchand
2022-04-26  8:08         ` Pei, Andy
2022-04-21  8:33     ` [PATCH v6 04/16] vdpa/ifc: add blk ops for ifc device Andy Pei
2022-04-21  8:33     ` [PATCH v6 05/16] vdpa/ifc: add vDPA interrupt for blk device Andy Pei
2022-04-25 12:58       ` Xia, Chenbo
2022-04-26  9:56         ` Pei, Andy
2022-04-21  8:33     ` [PATCH v6 06/16] vdpa/ifc: add block device SW live-migration Andy Pei
2022-04-25 13:10       ` Xia, Chenbo
2022-04-26 10:07         ` Pei, Andy
2022-04-21  8:33     ` [PATCH v6 07/16] examples/vdpa: add vDPA blk support in example Andy Pei
2022-04-25 13:38       ` Xia, Chenbo
2022-04-27  4:11         ` Pei, Andy
2022-04-21  8:33     ` [PATCH v6 08/16] usertools: add support for virtio blk device Andy Pei
2022-04-25 13:53       ` Xia, Chenbo
2022-04-26  4:13         ` Pei, Andy
2022-04-21  8:33     ` [PATCH v6 09/16] vdpa/ifc: add set vring state for " Andy Pei
2022-04-21  8:33     ` [PATCH v6 10/16] vdpa/ifc: add some log at vDPA launch before qemu connect Andy Pei
2022-04-21  8:33     ` [PATCH v6 11/16] vdpa/ifc: read virtio max queues from hardware Andy Pei
2022-04-21  8:33     ` [PATCH v6 12/16] vdpa/ifc: add interrupt and handle for virtio blk Andy Pei
2022-04-21  8:33     ` [PATCH v6 13/16] vdpa/ifc: add is blk flag to ifcvf HW struct Andy Pei
2022-04-21  8:33     ` [PATCH v6 14/16] vdpa/ifc/base: access correct register for blk device Andy Pei
2022-04-21  8:33     ` [PATCH v6 15/16] vdpa/ifc: blk device pause without no inflight IO Andy Pei
2022-04-21  8:33     ` [PATCH v6 16/16] vhost: make sure each queue callfd is configured Andy Pei
2022-04-27  8:29   ` [PATCH v7 00/18] add virtio_blk device support to vdpa/ifc Andy Pei
2022-04-27  8:29     ` [PATCH v7 01/18] vdpa/ifc: add support for virtio blk device Andy Pei
2022-04-27  8:29     ` [PATCH v7 02/18] vhost: add vDPA ops for " Andy Pei
2022-04-27  8:29     ` [PATCH v7 03/18] vhost: add vhost msg support Andy Pei
2022-05-11 14:24       ` Xia, Chenbo
2022-05-12  3:50         ` Pei, Andy
2022-04-27  8:29     ` [PATCH v7 04/18] vdpa/ifc: add blk ops for ifc device Andy Pei
2022-04-27  8:29     ` [PATCH v7 05/18] vdpa/ifc: add vDPA interrupt for blk device Andy Pei
2022-05-11 14:35       ` Xia, Chenbo
2022-05-12  3:49         ` Pei, Andy
2022-04-27  8:29     ` [PATCH v7 06/18] vdpa/ifc: add block device SW live-migration Andy Pei
2022-05-12 12:55       ` Xia, Chenbo
2022-05-13  3:32         ` Pei, Andy
2022-04-27  8:29     ` [PATCH v7 07/18] vhost: add API to get vDPA device type Andy Pei
2022-05-12 13:14       ` Xia, Chenbo
2022-05-13  4:15         ` Pei, Andy
2022-04-27  8:29     ` [PATCH v7 08/18] vdpa/ifc: add get device type ops to ifc driver Andy Pei
2022-05-12 13:21       ` Xia, Chenbo
2022-05-12 13:40         ` Xia, Chenbo
2022-05-13  7:38           ` Pei, Andy
2022-04-27  8:29     ` [PATCH v7 09/18] examples/vdpa: add vDPA blk support in example Andy Pei
2022-05-12 13:34       ` Xia, Chenbo
2022-05-13  8:16         ` Pei, Andy
2022-04-27  8:29     ` [PATCH v7 10/18] usertools: add support for virtio blk device Andy Pei
2022-04-27  8:29     ` [PATCH v7 11/18] vdpa/ifc: add set vring state for " Andy Pei
2022-05-12 13:44       ` Xia, Chenbo
2022-04-27  8:30     ` [PATCH v7 12/18] vdpa/ifc: add some log at vDPA launch before qemu connect Andy Pei
2022-05-12 13:53       ` Xia, Chenbo
2022-05-13  8:34         ` Pei, Andy
2022-05-13  8:40           ` Xia, Chenbo
2022-05-13 15:37           ` Stephen Hemminger
2022-05-16  1:03             ` Pei, Andy
2022-04-27  8:30     ` [PATCH v7 13/18] vdpa/ifc: read virtio max queues from hardware Andy Pei
2022-05-12 13:55       ` Xia, Chenbo
2022-05-13  8:58         ` Pei, Andy
2022-04-27  8:30     ` [PATCH v7 14/18] vdpa/ifc: add interrupt and handle for virtio blk Andy Pei
2022-05-13  2:52       ` Xia, Chenbo
2022-05-13 10:10         ` Pei, Andy
2022-04-27  8:30     ` [PATCH v7 15/18] vdpa/ifc: add is blk flag to ifcvf HW struct Andy Pei
2022-05-13  2:55       ` Xia, Chenbo
2022-05-16  3:05         ` Pei, Andy
2022-04-27  8:30     ` [PATCH v7 16/18] vdpa/ifc/base: access correct register for blk device Andy Pei
2022-05-13  2:57       ` Xia, Chenbo
2022-05-16  4:19         ` Pei, Andy
2022-04-27  8:30     ` [PATCH v7 17/18] vdpa/ifc: blk device pause without no inflight IO Andy Pei
2022-05-13  2:59       ` Xia, Chenbo
2022-05-16  4:20         ` Pei, Andy
2022-04-27  8:30     ` [PATCH v7 18/18] vhost: make sure each queue callfd is configured Andy Pei
2022-05-13  3:10       ` Xia, Chenbo
2022-05-18 12:13   ` [PATCH v8 00/13] add virtio_blk device support to vdpa/ifc Andy Pei
2022-05-18 12:13     ` [PATCH v8 01/13] vdpa/ifc: add support for virtio blk device Andy Pei
2022-05-23  3:41       ` Xia, Chenbo
2022-05-23  4:33         ` Pei, Andy
2022-05-18 12:13     ` [PATCH v8 02/13] vhost: add vDPA ops for " Andy Pei
2022-05-23  3:46       ` Xia, Chenbo
2022-05-23  4:38         ` Pei, Andy
2022-05-18 12:13     ` [PATCH v8 03/13] vhost: add vhost msg support for get/set config Andy Pei
2022-05-23  3:54       ` Xia, Chenbo
2022-05-23  4:49         ` Pei, Andy
2022-05-18 12:13     ` [PATCH v8 04/13] vdpa/ifc: add blk ops for ifc device Andy Pei
2022-05-23  4:07       ` Xia, Chenbo
2022-05-23  5:04         ` Pei, Andy
2022-05-18 12:13     ` [PATCH v8 05/13] vdpa/ifc: add vDPA interrupt relay for blk device Andy Pei
2022-05-23  4:10       ` Xia, Chenbo
2022-05-18 12:13     ` [PATCH v8 06/13] vdpa/ifc: add block device SW live-migration Andy Pei
2022-05-23  5:25       ` Xia, Chenbo
2022-05-23  5:31         ` Pei, Andy
2022-05-18 12:13     ` [PATCH v8 07/13] vhost: add API to get vDPA device type Andy Pei
2022-05-23  7:26       ` Xia, Chenbo
2022-05-23  8:23         ` Pei, Andy
2022-05-18 12:13     ` [PATCH v8 08/13] vdpa/ifc: add get device type ops to ifc driver Andy Pei
2022-05-23  7:30       ` Xia, Chenbo
2022-05-23  8:31         ` Pei, Andy
2022-05-18 12:13     ` [PATCH v8 09/13] examples/vdpa: add add virtio blk support Andy Pei
2022-05-23  7:40       ` Xia, Chenbo
2022-05-23  8:38         ` Pei, Andy
2022-05-18 12:13     ` [PATCH v8 10/13] usertools: add support for virtio blk device Andy Pei
2022-05-23  7:43       ` Xia, Chenbo
2022-05-23  8:49         ` Pei, Andy
2022-05-18 12:13     ` [PATCH v8 11/13] vdpa/ifc: add log for config space of virtio blk Andy Pei
2022-05-23  7:46       ` Xia, Chenbo
2022-05-18 12:13     ` [PATCH v8 12/13] vdpa/ifc: add interrupt handling for config space Andy Pei
2022-05-23  7:54       ` Xia, Chenbo
2022-05-18 12:13     ` [PATCH v8 13/13] vdpa/ifc/base: access correct register for blk device Andy Pei
2022-05-23  7:55       ` Xia, Chenbo
2022-05-23  9:03         ` Pei, Andy
2022-05-23  9:35   ` [PATCH v9 00/13] add virtio_blk device support to vdpa/ifc Andy Pei
2022-05-23  9:35     ` [PATCH v9 01/13] vdpa/ifc: add support for virtio blk device Andy Pei
2022-05-24  2:37       ` Xia, Chenbo
2022-05-23  9:35     ` [PATCH v9 02/13] vhost: add vDPA ops for " Andy Pei
2022-05-24  2:38       ` Xia, Chenbo
2022-05-23  9:35     ` [PATCH v9 03/13] vhost: add vhost msg support for get/set config Andy Pei
2022-05-24  2:52       ` Xia, Chenbo
2022-05-24  3:24         ` Pei, Andy
2022-05-23  9:35     ` [PATCH v9 04/13] vdpa/ifc: add blk ops for ifc device Andy Pei
2022-05-24  2:55       ` Xia, Chenbo
2022-05-24  3:27         ` Pei, Andy
2022-05-23  9:35     ` [PATCH v9 05/13] vdpa/ifc: add vDPA interrupt relay for blk device Andy Pei
2022-05-24  2:58       ` Xia, Chenbo
2022-05-23  9:35     ` [PATCH v9 06/13] vdpa/ifc: add block device SW live-migration Andy Pei
2022-05-24  3:00       ` Xia, Chenbo
2022-05-23  9:35     ` [PATCH v9 07/13] vhost: add API to get vDPA device type Andy Pei
2022-05-24  3:01       ` Xia, Chenbo
2022-05-23  9:35     ` [PATCH v9 08/13] vdpa/ifc: add get device type ops to ifc driver Andy Pei
2022-05-24  3:02       ` Xia, Chenbo
2022-05-23  9:35     ` [PATCH v9 09/13] examples/vdpa: add virtio blk support Andy Pei
2022-05-24  3:03       ` Xia, Chenbo
2022-05-23  9:35     ` [PATCH v9 10/13] usertools: add support for virtio blk device Andy Pei
2022-05-24  3:05       ` Xia, Chenbo
2022-05-23  9:35     ` [PATCH v9 11/13] vdpa/ifc: add log for config space of virtio blk Andy Pei
2022-05-24  3:06       ` Xia, Chenbo
2022-05-23  9:35     ` [PATCH v9 12/13] vdpa/ifc: add interrupt handling for config space Andy Pei
2022-05-24  3:09       ` Xia, Chenbo
2022-05-23  9:35     ` [PATCH v9 13/13] vdpa/ifc/base: access correct register for blk device Andy Pei
2022-05-24  3:10       ` Xia, Chenbo
2022-05-24  3:11         ` Pei, Andy
2022-05-24  2:48   ` [PATCH v10 00/13] add virtio_blk device support to vdpa/ifc Andy Pei
2022-05-24  2:48     ` [PATCH v10 01/13] vdpa/ifc: add support for virtio blk device Andy Pei
2022-05-24  2:48     ` [PATCH v10 02/13] vhost: add vDPA ops for " Andy Pei
2022-05-24  2:48     ` [PATCH v10 03/13] vhost: add vhost msg support for get/set config Andy Pei
2022-05-24  3:49       ` Xia, Chenbo
2022-05-24  2:48     ` [PATCH v10 04/13] vdpa/ifc: add blk ops for ifc device Andy Pei
2022-05-24  6:28       ` Xia, Chenbo
2022-05-24  6:30         ` Pei, Andy
2022-05-24  2:48     ` [PATCH v10 05/13] vdpa/ifc: add vDPA interrupt relay for blk device Andy Pei
2022-05-24  2:48     ` [PATCH v10 06/13] vdpa/ifc: add block device SW live-migration Andy Pei
2022-05-24  2:48     ` [PATCH v10 07/13] vhost: add API to get vDPA device type Andy Pei
2022-05-24  2:48     ` [PATCH v10 08/13] vdpa/ifc: add get device type ops to ifc driver Andy Pei
2022-05-24  2:48     ` [PATCH v10 09/13] examples/vdpa: add virtio blk support Andy Pei
2022-05-24  2:48     ` [PATCH v10 10/13] usertools: add support for virtio blk device Andy Pei
2022-05-24  2:48     ` [PATCH v10 11/13] vdpa/ifc: add log for config space of virtio blk Andy Pei
2022-05-24  2:48     ` [PATCH v10 12/13] vdpa/ifc: add interrupt handling for config space Andy Pei
2022-05-24  2:48     ` [PATCH v10 13/13] vdpa/ifc/base: access correct register for blk device Andy Pei
2022-06-01 10:10     ` [PATCH v10 00/13] add virtio_blk device support to vdpa/ifc Maxime Coquelin
2022-06-01 13:57       ` Pei, Andy
2022-01-25  6:47 ` [PATCH 02/15] vhost: add vdpa ops for blk device Andy Pei
2022-01-25  6:47 ` [PATCH 03/15] vdpa/ifc: add blk ops for ifc device Andy Pei
2022-01-25  6:47 ` [PATCH 04/15] vdpa/ifc: add vdpa interrupt for blk device Andy Pei
2022-01-25  6:47 ` [PATCH 05/15] vdpa/ifc: add blk dev sw live migration Andy Pei
2022-01-25  6:47 ` [PATCH 06/15] example/vdpa:add vdpa blk support in example Andy Pei
2022-01-25  6:47 ` [PATCH 07/15] usertools: add support for virtio blk device Andy Pei
2022-01-25  6:47 ` [PATCH 08/15] vdpa/ifc: set_vring_state op is mandatory, add set_vring_state for " Andy Pei
2022-01-25  6:47 ` [PATCH 09/15] vdpa/ifc: add some log at VDPA lauch before qemu connect Andy Pei
2022-01-25  6:47 ` [PATCH 10/15] vdpa/ifc: read virtio max_queues from hardware Andy Pei
2022-01-25  6:47 ` [PATCH 11/15] vdpa: add config space change interrupt register and handle for virtio_blk Andy Pei
2022-01-25  6:47 ` [PATCH 12/15] vdpa/ifc: add is_blk flag to ifcvf_hw, and init is_blk during probe Andy Pei
2022-01-25  6:47 ` [PATCH 13/15] vdpa/ifc/base: for blk device, live migration register is different from net device Andy Pei
2022-01-25  6:47 ` [PATCH 14/15] vdpa/ifc: make sure hardware last_avail_idx and last_used_idx is the same when blk device pause Andy Pei
2022-01-25  6:47 ` [PATCH 15/15] vhost: make sure each queue callfd is configured Andy Pei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=08f0027681ff4583bf46a835a5e8c9ef@intel.com \
    --to=andy.pei@intel.com \
    --cc=changpeng.liu@intel.com \
    --cc=chenbo.xia@intel.com \
    --cc=dev@dpdk.org \
    --cc=gang.cao@intel.com \
    --cc=maxime.coquelin@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).