From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>,
"viveksharma@marvell.com" <viveksharma@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "intoviveksharma@gmail.com" <intoviveksharma@gmail.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: support QinQ strip offload
Date: Mon, 22 Jul 2019 15:26:56 +0100 [thread overview]
Message-ID: <092c4b9c-a04a-3a3a-a677-049058251296@intel.com> (raw)
In-Reply-To: <8CEF83825BEC744B83065625E567D7C260DD2C48@IRSMSX108.ger.corp.intel.com>
On 7/22/2019 1:04 PM, Iremonger, Bernard wrote:
> Hi Ferruh,
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit
>> Sent: Friday, July 19, 2019 5:53 PM
>> To: viveksharma@marvell.com; dev@dpdk.org
>> Cc: intoviveksharma@gmail.com
>> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: support QinQ strip offload
>>
>> On 7/17/2019 8:45 AM, viveksharma@marvell.com wrote:
>>> From: Vivek Sharma <viveksharma@marvell.com>
>>>
>>> Support QinQ strip RX offload configuration through testpmd command
>>> line and boot time arguments.
>>
>> For the testpmd command part, unfortunately there are two set of
>> commands for same purpose, the new ones are (lets both port and queue
>> level):
>> "port config <port_id> rx_offload ..."
>> "port (port_id) rxq (queue_id) rx_offload ..."
>> "port config (port_id) tx_offload ..."
>> "port (port_id) txq (queue_id) tx_offload ..."
>>
>> These are better implementation comparing the old one:
>> "port config all ..."
>>
>> Would you mind sending a patch to remove "port config all ..." variant of
>> setting offloads?
>> And you can make your changes to the new commands above.
>
> Is it ok to remove "port config all ..." commands as they may be in use by the community?
Since there is a command that replaces the removed functionality I think it is OK.
Also I am not sure what level of backward compatibility we should provide for
testpmd commands.
>
>
>> For the application argument, ``--enable-hw-vlan-extend``, instead of adding
>> a parameter of each offload argument, (and event it is not clear if it is only for
>> Rx or Tx), have a "--rx-offloads" argument and feed the list via this, like:
>> "--rx-ofloads=disable-crc-strip,enable-rx-timestamp"
>>
>>
>>
>> And lastly for the "vlan set ..." update, I think "qinq" was already defined but
>> it was calling 'vlan_extend_set()', now you are changing it and making it call
>> 'rx_vlan_qinq_strip_set()', I think this is OK, but can you please update the
>> 'cmd_help_long_parsed()' accordingly?
>
> 'vlan_extend_set()' and 'rx_vlan_qinq_strip_set()' are different commands.
> vlan_extend_set() is for adding the second vlan and rx_vlan_qinq_strip_set() is for removing the second vlan.
yes they are different, I think nobody said they are same.
What is the concern here, can you please detail more?
>
>
>> And in original 'cmd_help_long_parsed()' for 'vlan set ...", it doesn't need to
>> have separate lines for "strip, filter & qinq", can you please merge them, and
>> later the 'extend' one?
>> Than change needs to be documented on "testpmd_funcs.rst"
>>
>>
>> And as a last thing, can you please send this as multiple patches:
>> 1) Command line change for setting qinq offload
>> 2) Application argument change
>> 3) "vlan set " related changes
>>
>>>
>>> Signed-off-by: Vivek Sharma <viveksharma@marvell.com>
>>
>
> Regards,
>
> Bernard
>
next prev parent reply other threads:[~2019-07-22 14:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 7:45 viveksharma
2019-07-17 13:49 ` Iremonger, Bernard
2019-07-19 16:53 ` Ferruh Yigit
2019-07-22 12:04 ` Iremonger, Bernard
2019-07-22 14:26 ` Ferruh Yigit [this message]
2019-07-22 14:55 ` Iremonger, Bernard
2019-07-22 15:40 ` Ferruh Yigit
2019-07-22 17:03 ` Iremonger, Bernard
2019-07-22 17:16 ` Ferruh Yigit
2019-07-23 9:07 ` Iremonger, Bernard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=092c4b9c-a04a-3a3a-a677-049058251296@intel.com \
--to=ferruh.yigit@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=intoviveksharma@gmail.com \
--cc=viveksharma@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).