From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Ian Stokes <ian.stokes@intel.com>, <dev@dpdk.org>
Cc: <stephen@networkplumber.org>
Subject: Re: [dpdk-dev] [RFC 1/6] ethdev: add min/max MTU to device info
Date: Mon, 25 Feb 2019 10:40:30 +0300 [thread overview]
Message-ID: <095ee887-0fcf-a5ad-ef8e-435e4b812ed9@solarflare.com> (raw)
In-Reply-To: <1550678275-4959-2-git-send-email-ian.stokes@intel.com>
On 2/20/19 6:57 PM, Ian Stokes wrote:
> From: Stephen Hemminger <stephen@networkplumber.org>
>
> This addresses the usability issue raised by OVS at DPDK Userspace
> summit. It adds general min/max mtu into device info. For compatiablity,
> and to save space, it fits in a hole in existing structure.
>
> The initial version sets max mtu to normal Ethernet, it is up to
> PMD to set larger value if it supports Jumbo frames.
>
> Also remove the deprecation notice introduced in 18.11 regarding this
> change.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> Signed-off-by: Ian Stokes <ian.stokes@intel.com>
> ---
[...]
> diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
> index 0d192a24b..f089af94d 100644
> --- a/lib/librte_ethdev/rte_ethdev.c
> +++ b/lib/librte_ethdev/rte_ethdev.c
> @@ -2527,6 +2527,8 @@ rte_eth_dev_info_get(uint16_t port_id, struct rte_eth_dev_info *dev_info)
> dev_info->rx_desc_lim = lim;
> dev_info->tx_desc_lim = lim;
> dev_info->device = dev->device;
> + dev_info->min_mtu = ETHER_MIN_MTU;
> + dev_info->max_mtu = ETHER_MTU;
I think it should be set to UINT16_MAX to avoid breakage of jumbo frame
support just after the patch. When all in tree drivers are updated, it
can be
set to ETHER_MTU, but it should in with UINT16_MAX value.
with above issue fixed
Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
next prev parent reply other threads:[~2019-02-25 7:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 15:57 [dpdk-dev] [RFC 0/6] " Ian Stokes
2019-02-20 15:57 ` [dpdk-dev] [RFC 1/6] " Ian Stokes
2019-02-25 7:40 ` Andrew Rybchenko [this message]
2019-02-27 21:48 ` Ian Stokes
2019-02-20 15:57 ` [dpdk-dev] [RFC 2/6] net/i40e: set min and max MTU for i40e devices Ian Stokes
2019-02-20 15:57 ` [dpdk-dev] [RFC 3/6] net/i40e: set min and max MTU for i40e VF devices Ian Stokes
2019-02-20 15:57 ` [dpdk-dev] [RFC 4/6] net/ixgbe: set min and max MTU for ixgbe devices Ian Stokes
2019-02-20 15:57 ` [dpdk-dev] [RFC 5/6] net/ixgbe: set min and max MTU for ixgbe VF devices Ian Stokes
2019-02-20 15:57 ` [dpdk-dev] [RFC 6/6] net/e1000: set min and max MTU for igb devices Ian Stokes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=095ee887-0fcf-a5ad-ef8e-435e4b812ed9@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ian.stokes@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).