From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Nikolay Nikolaev <nicknickolaev@gmail.com>,
maxime.coquelin@redhat.com, tiwei.bie@intel.com,
zhihong.wang@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v5 4/5] vhost: unify message handling function signature
Date: Mon, 24 Sep 2018 16:54:44 +0100 [thread overview]
Message-ID: <09c0daa0-7718-1bd2-93ce-2aa091e52466@intel.com> (raw)
In-Reply-To: <153780249865.17494.6292437035663379898.stgit@T460>
On 24-Sep-18 4:21 PM, Nikolay Nikolaev wrote:
> Each vhost-user message handling function will return an int result
> which is described in the new enum vh_result: error, OK and reply.
> All functions will now have two arguments, virtio_net double pointer
> and VhostUserMsg pointer.
>
> Signed-off-by: Nikolay Nikolaev <nicknickolaev@gmail.com>
> ---
<snip>
> get_blk_size(int fd)
> {
> @@ -127,27 +137,31 @@ vhost_backend_cleanup(struct virtio_net *dev)
> * the device hasn't been initialised.
> */
> static int
> -vhost_user_set_owner(void)
> +vhost_user_set_owner(struct virtio_net **pdev __rte_unused,
> + VhostUserMsg * msg __rte_unused)
Missed a few instances of using a typedef in this patch.
--
Thanks,
Anatoly
next prev parent reply other threads:[~2018-09-24 15:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-24 15:21 [dpdk-dev] [PATCH v5 0/5] vhost_user.c code cleanup Nikolay Nikolaev
2018-09-24 15:21 ` [dpdk-dev] [PATCH v5 1/5] vhost: unify struct VhostUserMsg usage Nikolay Nikolaev
2018-09-24 15:21 ` [dpdk-dev] [PATCH v5 2/5] vhost: make message handling functions prepare the reply Nikolay Nikolaev
2018-09-24 15:21 ` [dpdk-dev] [PATCH v5 3/5] vhost: handle unsupported message types in functions Nikolay Nikolaev
2018-09-24 15:21 ` [dpdk-dev] [PATCH v5 4/5] vhost: unify message handling function signature Nikolay Nikolaev
2018-09-24 15:54 ` Burakov, Anatoly [this message]
2018-09-24 15:21 ` [dpdk-dev] [PATCH v5 5/5] vhost: message handling implemented as a callback array Nikolay Nikolaev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09c0daa0-7718-1bd2-93ce-2aa091e52466@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=nicknickolaev@gmail.com \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).