From: "Xu, Rosen" <rosen.xu@intel.com>
To: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Singh, Jasvinder" <jasvinder.singh@intel.com>,
"jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] lib/librte_ethdev: expand queue threshold size of RED parameters
Date: Tue, 9 Oct 2018 00:02:17 +0000 [thread overview]
Message-ID: <0E78D399C70DA940A335608C6ED296D73A2DA3B9@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891268E7D5F9F@IRSMSX107.ger.corp.intel.com>
> -----Original Message-----
> From: Dumitrescu, Cristian
> Sent: Tuesday, October 09, 2018 0:00
> To: Xu, Rosen <rosen.xu@intel.com>; dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Singh, Jasvinder
> <jasvinder.singh@intel.com>; jerin.jacob@caviumnetworks.com; Yigit,
> Ferruh <ferruh.yigit@intel.com>
> Subject: RE: [PATCH] lib/librte_ethdev: expand queue threshold size of RED
> parameters
>
>
>
> > -----Original Message-----
> > From: Xu, Rosen
> > Sent: Thursday, August 16, 2018 2:14 AM
> > To: dev@dpdk.org
> > Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Lu, Wenzhuo
> > <wenzhuo.lu@intel.com>; Singh, Jasvinder <jasvinder.singh@intel.com>;
> > jerin.jacob@caviumnetworks.com; Xu, Rosen <rosen.xu@intel.com>; Yigit,
> > Ferruh <ferruh.yigit@intel.com>
> > Subject: [PATCH] lib/librte_ethdev: expand queue threshold size of RED
> > parameters
> >
> > There's very commonly that more than 4G DDR memory in NIC for HQoS,
> so
> > right now the queue threshold size of RED needs to expand to uint64_t.
> > This patch fixes it.
> >
> > Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> > ---
> > lib/librte_ethdev/rte_tm.h | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/lib/librte_ethdev/rte_tm.h b/lib/librte_ethdev/rte_tm.h
> > index 955f02f..646ef38 100644
> > --- a/lib/librte_ethdev/rte_tm.h
> > +++ b/lib/librte_ethdev/rte_tm.h
> > @@ -831,10 +831,10 @@ enum rte_tm_cman_mode {
> > */
> > struct rte_tm_red_params {
> > /** Minimum queue threshold */
> > - uint32_t min_th;
> > + uint64_t min_th;
> >
> > /** Maximum queue threshold */
> > - uint32_t max_th;
> > + uint64_t max_th;
> >
> > /** Inverse of packet marking probability maximum value (maxp), i.e.
> > * maxp_inv = 1 / maxp
> > --
> > 1.8.3.1
>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>
> Applied to next-qos tree, thanks!
Okay, thanks a lot Cristian.
What means nex-qos tree? 18.11?
prev parent reply other threads:[~2018-10-09 0:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 1:14 Rosen Xu
2018-08-16 8:51 ` Dumitrescu, Cristian
2018-10-08 15:59 ` Dumitrescu, Cristian
2018-10-09 0:02 ` Xu, Rosen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0E78D399C70DA940A335608C6ED296D73A2DA3B9@SHSMSX104.ccr.corp.intel.com \
--to=rosen.xu@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jasvinder.singh@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).