From: "John Daley (johndale)" <johndale@cisco.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/enic: fix MAC address add and remove
Date: Fri, 27 Jan 2017 19:04:57 +0000 [thread overview]
Message-ID: <0a23266508ef4e008cc575b320b19f07@XCH-RCD-007.cisco.com> (raw)
In-Reply-To: <2cb850e4-9bb7-327d-e380-c2ff6883d75e@intel.com>
> -----Original Message-----
> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
> Sent: Friday, January 27, 2017 3:07 AM
> To: John Daley (johndale) <johndale@cisco.com>
> Cc: dev@dpdk.org
> Subject: Re: [PATCH] net/enic: fix MAC address add and remove
>
> On 1/26/2017 8:12 PM, John Daley wrote:
> > The mac_addr_add callback function was simply replacing the primary
> > MAC address instead of adding new ones and the mac_addr_remove
> > callback would only remove the primary MAC form the adapter. Fix the
> > functions to add or remove new address. Allow up to 64 MAC addresses
> per port.
> >
> > Fixes: fefed3d1e62c ("enic: new driver")
> >
> > Signed-off-by: John Daley <johndale@cisco.com>
> > Reviewed-by: Nelson Escobar <neescoba@cisco.com>
>
> Applied to dpdk-next-net/master, thanks.
>
> (Since it is controversial that if this patch is a fix or implementing a missing
> feature (allow up to 64 MAC), I am getting patch as it is, but not CC'ed to
> stable tree, please shout if you disagree.)
That's fine to not put it on stable. Thank you for applying.
-john
prev parent reply other threads:[~2017-01-27 19:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 20:12 John Daley
2017-01-27 11:06 ` Ferruh Yigit
2017-01-27 19:04 ` John Daley (johndale) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a23266508ef4e008cc575b320b19f07@XCH-RCD-007.cisco.com \
--to=johndale@cisco.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).