DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Jakub Grajciar <jgrajcia@cisco.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v5] net/memif: zero-copy slave
Date: Fri, 4 Oct 2019 14:23:55 +0100	[thread overview]
Message-ID: <0a3d8d8a-c66b-4015-3c63-6b14ee350651@intel.com> (raw)
In-Reply-To: <20190822081833.11203-1-jgrajcia@cisco.com>

On 8/22/2019 9:18 AM, Jakub Grajciar wrote:
> Zero-copy slave support for memif PMD.
> Slave interface exposes DPDK memory to
> master interface. Only single file segments
> are supported (EAL option --single-file-segments).
> 
> Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
> ---
>  doc/guides/nics/memif.rst                     |  42 +-
>  drivers/net/memif/Makefile                    |   1 +
>  drivers/net/memif/memif_socket.c              |  64 +--
>  drivers/net/memif/meson.build                 |   1 +
>  drivers/net/memif/rte_eth_memif.c             | 449 +++++++++++++++++-
>  drivers/net/memif/rte_eth_memif.h             |  11 +-
>  lib/librte_eal/common/eal_common_mcfg.c       |   7 +
>  .../common/include/rte_eal_memconfig.h        |  10 +
>  lib/librte_eal/rte_eal_version.map            |   1 +
>  9 files changed, 513 insertions(+), 73 deletions(-)
> 
> V2:
> - fix coding style
> 
> V3:
> - fix compilation issues
> 
> V4:
> - don't move existing code
> - add new EAL API rte_mcfg_get_single_file_segments,
>   mem_config is now private, this api returns
>   single_file_segments parameter value
> 
> V5:
> - explain single file segments limitation
> - add zero-copy slave example

Overall looks good, but I had to test this by manually modifying the PMD for the
bind() error.

I am for first fixing the PMD bind() issue before getting this patch, fyi.

  reply	other threads:[~2019-10-04 13:24 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-09  8:22 [dpdk-dev] [PATCH v4] " Jakub Grajciar
2019-07-10 15:06 ` Ferruh Yigit
2019-07-23 12:35   ` Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)
2019-08-22  8:18 ` [dpdk-dev] [PATCH v5] " Jakub Grajciar
2019-10-04 13:23   ` Ferruh Yigit [this message]
2019-10-15 16:59     ` Ferruh Yigit
2019-10-17 11:52       ` Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)
2019-10-17 16:04         ` Ferruh Yigit
2019-10-17 16:45           ` Ferruh Yigit
2019-10-21 16:07             ` Ferruh Yigit
2019-10-25 16:44   ` Yigit, Ferruh
2019-10-29 14:28     ` David Marchand
2019-10-30 10:17       ` Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco)
2019-10-30 10:25         ` David Marchand
2019-11-04 11:03   ` [dpdk-dev] [PATCH v6] " Jakub Grajciar
2019-11-11 15:21     ` Ferruh Yigit
2019-11-11 15:24       ` Thomas Monjalon
2019-11-12 12:55         ` Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco)
2019-11-11 15:49       ` David Marchand
2019-11-15 16:55         ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0a3d8d8a-c66b-4015-3c63-6b14ee350651@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=jgrajcia@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).