From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Jiawen Wu <jiawenwu@trustnetic.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 00/37] net: add txgbe PMD part 2
Date: Wed, 11 Nov 2020 16:09:22 +0000 [thread overview]
Message-ID: <0aa27492-dcf1-a21c-f330-bee14b3d3bfc@intel.com> (raw)
In-Reply-To: <45280e07-d371-875d-feeb-1e26c90ce126@intel.com>
On 11/11/2020 4:00 PM, Ferruh Yigit wrote:
> On 11/11/2020 6:48 AM, Jiawen Wu wrote:
>> This patch adds the rest of txgbe PMD for its PF part.
>> Support include flow API, traffic manager, macsec and ipsec.
>>
>> v2:
>> - Rebase on next-net
>>
>> Jiawen Wu (37):
>> net/txgbe: add ntuple filter init and uninit
>> net/txgbe: support ntuple filter add and delete
>> net/txgbe: add ntuple parse rule
>> net/txgbe: support ntuple filter remove operaion
>> net/txgbe: support ethertype filter add and delete
>> net/txgbe: add ethertype parse rule
>> net/txgbe: support syn filter add and delete
>> net/txgbe: add syn filter parse rule
>> net/txgbe: add L2 tunnel filter init and uninit
>> net/txgbe: config L2 tunnel filter with e-tag
>> net/txgbe: support L2 tunnel filter add and delete
>> net/txgbe: add L2 tunnel filter parse rule
>> net/txgbe: add FDIR filter init and uninit
>> net/txgbe: configure FDIR filter
>> net/txgbe: support FDIR add and delete operations
>> net/txgbe: add FDIR parse normal rule
>> net/txgbe: add FDIR parse tunnel rule
>> net/txgbe: add FDIR restore operation
>> net/txgbe: add RSS filter parse rule
>> net/txgbe: add RSS filter restore operation
>> net/txgbe: add filter list init and uninit
>> net/txgbe: add generic flow API
>> net/txgbe: add flow API create function
>> net/txgbe: add flow API destroy function
>> net/txgbe: add flow API flush function
>> net/txgbe: support UDP tunnel port add and delete
>> net/txgbe: add TM configuration init and uninit
>> net/txgbe: add TM capabilities get operation
>> net/txgbe: support TM shaper profile add and delete
>> net/txgbe: support TM node add and delete
>> net/txgbe: add TM hierarchy commit
>> net/txgbe: add macsec setting
>> net/txgbe: add IPsec context creation
>> net/txgbe: add security session create operation
>> net/txgbe: support security session destroy
>> net/txgbe: add security offload in Rx and Tx process
>> net/txgbe: add security type in flow action
>
> Hi Jiawen,
>
> There are multiple build errors on patch by patch build, can you please check
> it, the expectation is after each commit build and functionality shouldn't be
> broken.
>
> I put some comments to the patches, with a change request how to construct the
> patchset.
>
> All these new features are not documented in the driver documentation, it can be
> documented with more details.
>
> And the patchset is loaded, it has many new features, it is up to you but
> instead of adding all to -rc4, I suggest postponing this set to next release and
> use longer time for better implementation.
>
> Thanks
> ferruh
>
Btw, there is some code against coding convention, and following checkpatch
warnings, can you please check them too?
./devtools/checkpatches.sh -n37
### net/txgbe: support ntuple filter add and delete
WARNING:TYPO_SPELLING: 'ponter' may be misspelled - perhaps 'pointer'?
#94: FILE: drivers/net/txgbe/txgbe_ethdev.c:3574:
+ * filter: ponter to the filter that will be added.
total: 0 errors, 1 warnings, 0 checks, 352 lines checked
### net/txgbe: add ntuple parse rule
WARNING:TYPO_SPELLING: 'asumption' may be misspelled - perhaps 'assumption'?
#90: FILE: drivers/net/txgbe/txgbe_flow.c:63:
+ * Please aware there's an asumption for all the parsers.
total: 0 errors, 1 warnings, 0 checks, 543 lines checked
### net/txgbe: support ntuple filter remove operaion
WARNING:TYPO_SPELLING: 'operaion' may be misspelled - perhaps 'operation'?
#4:
Subject: [PATCH] net/txgbe: support ntuple filter remove operaion
total: 0 errors, 1 warnings, 0 checks, 25 lines checked
### net/txgbe: add generic flow API
WARNING:TYPO_SPELLING: 'checkes' may be misspelled - perhaps 'checks'?
#100: FILE: drivers/net/txgbe/txgbe_flow.c:2634:
+ * It only checkes the format. Don't guarantee the rule can be programmed into
total: 0 errors, 1 warnings, 0 checks, 123 lines checked
### net/txgbe: add macsec setting
WARNING:TYPO_SPELLING: 'suuport' may be misspelled - perhaps 'support'?
#7:
Add macsec offload suuport.
total: 0 errors, 1 warnings, 0 checks, 174 lines checked
WARNING:REPEATED_WORD: Possible repeated word: 'crypto'
#344: FILE: drivers/net/txgbe/txgbe_ipsec.h:42:
+/** inline crypto crypto private session structure */
total: 0 errors, 1 warnings, 2 checks, 355 lines checked
### net/txgbe: support security session destroy
WARNING:REPEATED_WORD: Possible repeated word: 'table'
#62: FILE: drivers/net/txgbe/txgbe_ipsec.c:244:
+ /* Disable and clear Rx SPI and key table table entryes*/
total: 0 errors, 1 warnings, 0 checks, 212 lines checked
prev parent reply other threads:[~2020-11-11 16:09 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 6:48 Jiawen Wu
2020-11-11 6:49 ` [dpdk-dev] [PATCH v2 01/37] net/txgbe: add ntuple filter init and uninit Jiawen Wu
2020-11-11 6:49 ` [dpdk-dev] [PATCH v2 02/37] net/txgbe: support ntuple filter add and delete Jiawen Wu
2020-11-11 6:49 ` [dpdk-dev] [PATCH v2 03/37] net/txgbe: add ntuple parse rule Jiawen Wu
2020-11-11 16:06 ` Ferruh Yigit
2020-11-11 6:49 ` [dpdk-dev] [PATCH v2 04/37] net/txgbe: support ntuple filter remove operaion Jiawen Wu
2020-11-11 6:49 ` [dpdk-dev] [PATCH v2 05/37] net/txgbe: support ethertype filter add and delete Jiawen Wu
2020-11-11 6:49 ` [dpdk-dev] [PATCH v2 06/37] net/txgbe: add ethertype parse rule Jiawen Wu
2020-11-11 16:02 ` Ferruh Yigit
2020-11-11 16:04 ` Ferruh Yigit
2020-11-12 1:57 ` Wang, Haiyue
2020-11-11 6:49 ` [dpdk-dev] [PATCH v2 07/37] net/txgbe: support syn filter add and delete Jiawen Wu
2020-11-11 6:49 ` [dpdk-dev] [PATCH v2 08/37] net/txgbe: add syn filter parse rule Jiawen Wu
2020-11-11 6:49 ` [dpdk-dev] [PATCH v2 09/37] net/txgbe: add L2 tunnel filter init and uninit Jiawen Wu
2020-11-11 6:49 ` [dpdk-dev] [PATCH v2 10/37] net/txgbe: config L2 tunnel filter with e-tag Jiawen Wu
2020-11-11 6:49 ` [dpdk-dev] [PATCH v2 11/37] net/txgbe: support L2 tunnel filter add and delete Jiawen Wu
2020-11-11 6:49 ` [dpdk-dev] [PATCH v2 12/37] net/txgbe: add L2 tunnel filter parse rule Jiawen Wu
2020-11-11 16:10 ` Ferruh Yigit
2020-11-11 6:49 ` [dpdk-dev] [PATCH v2 13/37] net/txgbe: add FDIR filter init and uninit Jiawen Wu
2020-11-11 6:49 ` [dpdk-dev] [PATCH v2 14/37] net/txgbe: configure FDIR filter Jiawen Wu
2020-11-11 6:49 ` [dpdk-dev] [PATCH v2 15/37] net/txgbe: support FDIR add and delete operations Jiawen Wu
2020-11-11 6:49 ` [dpdk-dev] [PATCH v2 16/37] net/txgbe: add FDIR parse normal rule Jiawen Wu
2020-11-11 6:49 ` [dpdk-dev] [PATCH v2 17/37] net/txgbe: add FDIR parse tunnel rule Jiawen Wu
2020-11-11 6:49 ` [dpdk-dev] [PATCH v2 18/37] net/txgbe: add FDIR restore operation Jiawen Wu
2020-11-11 6:49 ` [dpdk-dev] [PATCH v2 19/37] net/txgbe: add RSS filter parse rule Jiawen Wu
2020-11-11 6:49 ` [dpdk-dev] [PATCH v2 20/37] net/txgbe: add RSS filter restore operation Jiawen Wu
2020-11-11 6:49 ` [dpdk-dev] [PATCH v2 21/37] net/txgbe: add filter list init and uninit Jiawen Wu
2020-11-11 16:10 ` Ferruh Yigit
2020-11-11 6:49 ` [dpdk-dev] [PATCH v2 22/37] net/txgbe: add generic flow API Jiawen Wu
2020-11-11 6:49 ` [dpdk-dev] [PATCH v2 23/37] net/txgbe: add flow API create function Jiawen Wu
2020-11-11 16:11 ` Ferruh Yigit
2020-11-11 6:49 ` [dpdk-dev] [PATCH v2 24/37] net/txgbe: add flow API destroy function Jiawen Wu
2020-11-11 6:49 ` [dpdk-dev] [PATCH v2 25/37] net/txgbe: add flow API flush function Jiawen Wu
2020-11-11 6:49 ` [dpdk-dev] [PATCH v2 26/37] net/txgbe: support UDP tunnel port add and delete Jiawen Wu
2020-11-11 6:49 ` [dpdk-dev] [PATCH v2 27/37] net/txgbe: add TM configuration init and uninit Jiawen Wu
2020-11-11 6:49 ` [dpdk-dev] [PATCH v2 28/37] net/txgbe: add TM capabilities get operation Jiawen Wu
2020-11-11 6:49 ` [dpdk-dev] [PATCH v2 29/37] net/txgbe: support TM shaper profile add and delete Jiawen Wu
2020-11-11 6:49 ` [dpdk-dev] [PATCH v2 30/37] net/txgbe: support TM node " Jiawen Wu
2020-11-11 6:49 ` [dpdk-dev] [PATCH v2 31/37] net/txgbe: add TM hierarchy commit Jiawen Wu
2020-11-11 6:49 ` [dpdk-dev] [PATCH v2 32/37] net/txgbe: add macsec setting Jiawen Wu
2020-11-11 16:13 ` Ferruh Yigit
2020-11-11 6:49 ` [dpdk-dev] [PATCH v2 33/37] net/txgbe: add IPsec context creation Jiawen Wu
2020-11-11 6:49 ` [dpdk-dev] [PATCH v2 34/37] net/txgbe: add security session create operation Jiawen Wu
2020-11-11 6:49 ` [dpdk-dev] [PATCH v2 35/37] net/txgbe: support security session destroy Jiawen Wu
2020-11-11 6:49 ` [dpdk-dev] [PATCH v2 36/37] net/txgbe: add security offload in Rx and Tx process Jiawen Wu
2020-11-11 6:49 ` [dpdk-dev] [PATCH v2 37/37] net/txgbe: add security type in flow action Jiawen Wu
2020-11-11 16:00 ` [dpdk-dev] [PATCH v2 00/37] net: add txgbe PMD part 2 Ferruh Yigit
2020-11-11 16:09 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0aa27492-dcf1-a21c-f330-bee14b3d3bfc@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=jiawenwu@trustnetic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).