From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Chas Williams <3chas3@gmail.com>, dev@dpdk.org, olivier.matz@6wind.com
Cc: stable@dpdk.org, Chas Williams <chas3@att.com>,
Andrew Rybchenko <arybchenko@solarflare.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net: fix Tx VLAN flag for offload emulation
Date: Mon, 1 Apr 2019 21:17:16 +0100 [thread overview]
Message-ID: <0b0a8300-a111-5fc1-3d84-d63988b356b6@intel.com> (raw)
In-Reply-To: <9b0d3a56-4941-dfb4-5702-fb09e913cf96@gmail.com>
On 3/26/2019 6:01 PM, Chas Williams wrote:
>
>
> On 3/26/19 12:50 PM, Ferruh Yigit wrote:
>> On 3/25/2019 3:05 PM, Chas Williams wrote:
>>> From: Bill Hong <bhong@brocade.com>
>>>
>>> A PMD might use rte_vlan_insert to implement Tx VLAN offload. Typically
>>> the PMD will insert the VLAN header in the transmit path and then attempt
>>> to send the packets. If this fails, the packets are returned to
>>> the application which may attempt to send these packets again. If the
>>> PKT_TX_VLAN flag is not cleared, the transmit path may attempt to insert
>>> the VLAN header again.
>>>
>>> Fixes: 47aa48b969f8 ("net: fix stripped VLAN flag for offload emulation");
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Bill Hong <bhong@brocade.com>
>>> Signed-off-by: Chas Williams <chas3@att.com>
>>> ---
>>> lib/librte_net/rte_ether.h | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h
>>> index c2c5e249f..e0d831113 100644
>>> --- a/lib/librte_net/rte_ether.h
>>> +++ b/lib/librte_net/rte_ether.h
>>> @@ -408,7 +408,7 @@ static inline int rte_vlan_insert(struct rte_mbuf **m)
>>> vh = (struct vlan_hdr *) (nh + 1);
>>> vh->vlan_tci = rte_cpu_to_be_16((*m)->vlan_tci);
>>>
>>> - (*m)->ol_flags &= ~PKT_RX_VLAN_STRIPPED;
>>> + (*m)->ol_flags &= ~(PKT_RX_VLAN_STRIPPED | PKT_TX_VLAN);
>>
>> Hi Chas,
>>
>> Looks reasonable, AFAIK, PKT_TX_VLAN flag means 'mbuf->vlan_tci' has valid value
>> and a request from application to driver to insert VLAN information.
>> After successful insertion flag can be removed.
>>
>> But in mbuf header, flags documented as:
>> PKT_TX_VLAN: TX packet is a 802.1q VLAN packet.
>> PKT_TX_QINQ: TX packet with double VLAN inserted.
Hi Olivier,
Any comment on them, should they be fixed?
>
> Note the usage slightly below:
>
> /**
> * Bitmask of all supported packet Tx offload features flags,
> * which can be set for packet.
> */
> #define PKT_TX_OFFLOAD_MASK ( \
> PKT_TX_OUTER_IPV6 | \
> PKT_TX_OUTER_IPV4 | \
> PKT_TX_OUTER_IP_CKSUM | \
> PKT_TX_VLAN_PKT | \
>
> So this implies that PKT_TX_VLAN_PKT (which is PKT_TX_VLAN's old name)
> is an offload feature, not that the actual packet has an 802.1q header
> (offloaded or otherwise).
>
> The same seems to apply for PKT_TX_QINQ.
Agree, I just would like to confirm, so lgtm:
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
>> Hi Oliver,
>>
>> Is above comments correct, or I am missing something J
>>
>>
>> Also here cleaning 'PKT_RX_VLAN_STRIPPED' looks like to say 'vlan' information
>> is not stripped but in the packet data, but 'RX' in this context can be
>> confusing, should we have a more generic 'PKT_VLAN_STRIPPED' ?
>>
next prev parent reply other threads:[~2019-04-01 20:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 15:05 [dpdk-stable] " Chas Williams
2019-03-26 16:50 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
2019-03-26 18:01 ` Chas Williams
2019-04-01 20:17 ` Ferruh Yigit [this message]
2019-04-04 17:07 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b0a8300-a111-5fc1-3d84-d63988b356b6@intel.com \
--to=ferruh.yigit@intel.com \
--cc=3chas3@gmail.com \
--cc=arybchenko@solarflare.com \
--cc=chas3@att.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).