From: Akhil Goyal <akhil.goyal@nxp.com>
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>,
<thomas@monjalon.net>, <jerin.jacob@caviumnetworks.com>,
<hemant.agrawal@nxp.com>, <fiona.trahe@intel.com>,
<deepak.k.jain@intel.com>, <john.griffin@intel.com>,
<declan.doherty@intel.com>
Cc: <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] doc: announce API change in crypto driver allocation
Date: Thu, 3 Aug 2017 16:13:12 +0530 [thread overview]
Message-ID: <0b8b13ec-9989-f10e-bfa2-7415446361a5@nxp.com> (raw)
In-Reply-To: <20170803010236.17503-1-pablo.de.lara.guarch@intel.com>
On 8/3/2017 6:32 AM, Pablo de Lara wrote:
> rte_cryptodev_allocate_driver() function gets one parameter
> (rte_driver), as the cryptodev_driver structure is
> allocated inside the function with rte_malloc.
>
> This function is called from a constructor function,
> when crypto PMDs are registered.
> If malloc fails, there is no way to recover from it,
> so it is better to allocate this structure
> statically, in each PMD.
>
> Therefore, it is required to add an extra parameter in
> this function, to also get a pointer to this structure.
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index f6bd910..bd4aa89 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -69,3 +69,9 @@ Deprecation Notices
> be removed in 17.11:
>
> - ``rte_cryptodev_create_vdev``
> +
> +* cryptodev: the following function will have an extra parameter, passing a
> + statically allocated crypto driver structure, instead of calling malloc,
> + in 17.11:
> +
> + - ``rte_cryptodev_allocate_driver``
>
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
next prev parent reply other threads:[~2017-08-03 10:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-03 1:02 Pablo de Lara
2017-08-03 10:39 ` Mcnamara, John
2017-08-03 10:43 ` Akhil Goyal [this message]
2017-08-08 10:21 ` Thomas Monjalon
2017-08-03 14:14 ` Jain, Deepak K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b8b13ec-9989-f10e-bfa2-7415446361a5@nxp.com \
--to=akhil.goyal@nxp.com \
--cc=declan.doherty@intel.com \
--cc=deepak.k.jain@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=john.griffin@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).