From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Reshma Pattan <reshma.pattan@intel.com>,
thomas@monjalon.net, dev@dpdk.org
Cc: jananeex.m.parthasarathy@intel.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v2 08/10] autotest: add new test cases to autotest
Date: Fri, 13 Jul 2018 17:41:08 +0100 [thread overview]
Message-ID: <0bdc3a80-4c8c-ea03-c8b3-04ff15a285be@intel.com> (raw)
In-Reply-To: <1531498808-21940-9-git-send-email-reshma.pattan@intel.com>
On 13-Jul-18 5:20 PM, Reshma Pattan wrote:
> Autotest is enhanced with additional test cases
> being added to autotest_data.py
You're also removing PCI autotest - commit message needs to call this
out as well.
>
> Cc: stable@dpdk.org
>
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> Signed-off-by: Jananee Parthasarathy <jananeex.m.parthasarathy@intel.com>
> ---
> test/test/autotest_data.py | 370 ++++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 362 insertions(+), 8 deletions(-)
>
> diff --git a/test/test/autotest_data.py b/test/test/autotest_data.py
<snip>
> + {
> + "Name": "Dump_ring",
> + "Command": "dump_ring",
> + "Func": default_autotest,
> + "Report": None,
> + },
> + {
> + "Name": "Quit",
> + "Command": "quit",
> + "Func": default_autotest,
> + "Report": None,
> + },
Why is "quit" an autotest? If you want to test "quit" functionality, i
would suggest putting it at the end of non-parallel tests, to avoid
situation where test prematurely stops (for example, this will happen on
FreeBSD, where there's only one thread executing these tests).
But really, having it in this list is IMO dubious.
> + {
> + "Name": "Set rxtx mode",
> + "Command": "set_rxtx_mode",
> + "Func": default_autotest,
> + "Report": None,
> + },
> + {
> + "Name": "Set rxtx anchor",
> + "Command": "set_rxtx_anchor",
> + "Func": default_autotest,
> + "Report": None,
> + },
> + {
> + "Name": "Set rxtx sc",
> + "Command": "set_rxtx_sc",
> + "Func": default_autotest,
> + "Report": None,
> + },
> + {
> + "Name": "Event eth rx adapter autotest",
> + "Command": "event_eth_rx_adapter_autotest",
> + "Func": default_autotest,
> + "Report": None,
> + },
> + {
> + "Name": "Rawdev autotest",
> + "Command": "rawdev_autotest",
> + "Func": default_autotest,
> + "Report": None,
> + },
> + {
> + "Name": "Kvargs autotest",
> + "Command": "kvargs_autotest",
> + "Func": default_autotest,
> + "Report": None,
> + },
> + {
> + "Name": "Dump physmem",
> + "Command": "dump_physmem",
> + "Func": default_autotest,
> + "Report": None,
> + },
> + {
> + "Name": "Dump memzone",
> + "Command": "dump_memzone",
> + "Func": default_autotest,
> + "Report": None,
> + },
Here and in other "dump" autotests - do these dump tests work as
autotests? Default autotest function expects a "Test OK" at the end of
test, and i don't think dump autotests return that, so this will
(should?) cause a very long timeout and a test failure. These should
have "dump_autotest" as "Func" value - that function correctly parses
output of dump autotests (or, to be more accurate, it doesn't - as long
as test doesn't crash, it's considered to be successful :) ).
Also, for readability, we should move these dump tests together and have
all dump tests one after the other.
--
Thanks,
Anatoly
next prev parent reply other threads:[~2018-07-13 16:41 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1528404133.git.anatoly.burakov@intel.com>
2018-06-07 21:01 ` [dpdk-stable] [PATCH 1/7] autotest: fix printing Anatoly Burakov
2018-06-07 21:01 ` [dpdk-stable] [PATCH 2/7] autotest: fix invalid code on reports Anatoly Burakov
2018-06-07 21:01 ` [dpdk-stable] [PATCH 3/7] autotest: make autotest runner python 2/3 compliant Anatoly Burakov
2018-06-07 21:01 ` [dpdk-stable] [PATCH 4/7] autotest: visually separate different test categories Anatoly Burakov
2018-06-07 21:01 ` [dpdk-stable] [PATCH 5/7] autotest: improve filtering Anatoly Burakov
2018-07-13 16:19 ` [dpdk-stable] [PATCH v2 01/10] autotest: fix printing Reshma Pattan
2018-07-13 16:20 ` [dpdk-stable] [PATCH v2 02/10] autotest: fix invalid code on reports Reshma Pattan
2018-07-13 16:20 ` [dpdk-stable] [PATCH v2 03/10] autotest: make autotest runner python 2/3 compliant Reshma Pattan
2018-07-13 16:20 ` [dpdk-stable] [PATCH v2 04/10] autotest: visually separate different test categories Reshma Pattan
2018-07-13 16:20 ` [dpdk-stable] [PATCH v2 05/10] autotest: improve filtering Reshma Pattan
2018-07-13 16:20 ` [dpdk-stable] [PATCH v2 08/10] autotest: add new test cases to autotest Reshma Pattan
2018-07-13 16:41 ` Burakov, Anatoly [this message]
2018-07-16 13:29 ` Pattan, Reshma
2018-07-13 16:20 ` [dpdk-stable] [PATCH v2 09/10] autotest: update result for skipped test cases Reshma Pattan
2018-07-13 16:42 ` Burakov, Anatoly
2018-07-13 16:20 ` [dpdk-stable] [PATCH v2 10/10] mk: update make targets for classified testcases Reshma Pattan
2018-07-16 14:12 ` [dpdk-stable] [PATCH v3 1/9] autotest: fix printing Reshma Pattan
2018-07-16 14:12 ` [dpdk-stable] [PATCH v3 2/9] autotest: fix invalid code on reports Reshma Pattan
2018-07-16 14:12 ` [dpdk-stable] [PATCH v3 3/9] autotest: make autotest runner python 2/3 compliant Reshma Pattan
2018-07-16 14:12 ` [dpdk-stable] [PATCH v3 4/9] autotest: visually separate different test categories Reshma Pattan
2018-07-16 14:12 ` [dpdk-stable] [PATCH v3 5/9] autotest: improve filtering Reshma Pattan
2018-07-16 14:12 ` [dpdk-stable] [PATCH v3 7/9] autotest: properly parallelize unit tests Reshma Pattan
2018-07-16 14:12 ` [dpdk-stable] [PATCH v3 8/9] autotest: update autotest test case list Reshma Pattan
2018-07-16 15:16 ` Burakov, Anatoly
2018-07-17 9:18 ` Pattan, Reshma
2018-07-17 9:23 ` Burakov, Anatoly
2018-07-17 9:45 ` Pattan, Reshma
2018-07-17 10:10 ` Burakov, Anatoly
2018-07-16 14:12 ` [dpdk-stable] [PATCH v3 9/9] mk: update make targets for classified testcases Reshma Pattan
2018-07-17 10:39 ` [dpdk-stable] [PATCH v4 1/9] autotest: fix printing Reshma Pattan
2018-07-17 10:39 ` [dpdk-stable] [PATCH v4 2/9] autotest: fix invalid code on reports Reshma Pattan
2018-07-17 10:39 ` [dpdk-stable] [PATCH v4 3/9] autotest: make autotest runner python 2/3 compliant Reshma Pattan
2018-07-17 10:39 ` [dpdk-stable] [PATCH v4 4/9] autotest: visually separate different test categories Reshma Pattan
2018-07-17 10:39 ` [dpdk-stable] [PATCH v4 5/9] autotest: improve filtering Reshma Pattan
2018-07-17 10:39 ` [dpdk-stable] [PATCH v4 7/9] autotest: properly parallelize unit tests Reshma Pattan
2018-07-17 10:39 ` [dpdk-stable] [PATCH v4 8/9] autotest: update autotest test case list Reshma Pattan
2018-07-17 10:39 ` [dpdk-stable] [PATCH v4 9/9] mk: update make targets for classified testcases Reshma Pattan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bdc3a80-4c8c-ea03-c8b3-04ff15a285be@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=jananeex.m.parthasarathy@intel.com \
--cc=reshma.pattan@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).