From: "Doherty, Declan" <declan.doherty@intel.com>
To: Gowrishankar <gowrishankar.m@linux.vnet.ibm.com>, dev@dpdk.org
Cc: "Thomas Monjalon" <thomas@monjalon.net>,
"Gaëtan Rivet" <gaetan.rivet@6wind.com>
Subject: Re: [dpdk-dev] [PATCH v3] net/bonding: support bifurcated driver in eal cli using --vdev
Date: Mon, 2 Oct 2017 12:06:13 +0100 [thread overview]
Message-ID: <0c17c7cc-9e11-da22-c2b1-311b6f16b979@intel.com> (raw)
In-Reply-To: <502c45826dbbfd2bc3f4f743aeea87f159921ae9.1505929849.git.gowrishankar.m@linux.vnet.ibm.com>
On 20/09/2017 7:04 PM, Gowrishankar wrote:
> From: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
>
> At present, creating bonding devices using --vdev is broken for PMD like
> mlx5 as it is neither UIO nor VFIO based and hence PMD driver is unknown
> to find_port_id_by_pci_addr(), as below.
>
> testpmd <EAL args> --vdev 'net_bonding0,mode=1,slave=<PCI>,socket_id=0'
>
> PMD: bond_ethdev_parse_slave_port_kvarg(150) - Invalid slave port value
> (<PCI ID>) specified
> EAL: Failed to parse slave ports for bonded device net_bonding0
>
> This patch fixes parsing PCI ID from bonding device params by verifying
> it in RTE PCI bus, rather than checking dev->kdrv.
>
> Fixes: eac901ce ("ethdev: decouple from PCI device")
> Signed-off-by: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
> ---
> v3:
> - adapt rte_bus API (with suggestions from Declan and Gaëtan)
>
...
>
Acked-by: Declan Doherty <declan.doherty@intel.com>
next prev parent reply other threads:[~2017-10-02 11:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 10:49 [dpdk-dev] [PATCH] " Gowrishankar
2017-06-15 13:54 ` Ferruh Yigit
2017-06-16 14:34 ` Thomas Monjalon
2017-07-04 11:57 ` [dpdk-dev] [PATCH v2] " Gowrishankar
2017-07-07 15:38 ` Declan Doherty
2017-07-10 6:32 ` gowrishankar muthukrishnan
2017-07-31 14:34 ` Gaëtan Rivet
2017-09-05 9:13 ` Thomas Monjalon
2017-09-06 8:59 ` gowrishankar muthukrishnan
2017-10-02 8:41 ` [dpdk-dev] [Suspected-Phishing]Re: " Raslan Darawsheh
2017-10-02 8:44 ` gowrishankar muthukrishnan
2017-10-03 8:38 ` [dpdk-dev] [Suspected-Phishing]Re: " Raslan Darawsheh
2017-09-20 18:04 ` [dpdk-dev] [PATCH v3] " Gowrishankar
2017-10-02 11:06 ` Doherty, Declan [this message]
2017-10-02 23:32 ` Ferruh Yigit
2017-10-02 12:09 ` Gaëtan Rivet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c17c7cc-9e11-da22-c2b1-311b6f16b979@intel.com \
--to=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=gowrishankar.m@linux.vnet.ibm.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).