From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>,
Yong Wang <wang.yong19@zte.com.cn>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix division by 0 error
Date: Thu, 29 Jun 2017 12:14:52 +0100 [thread overview]
Message-ID: <0c5aebf8-0fc0-122e-3977-cdfc39c825fc@intel.com> (raw)
In-Reply-To: <9BB6961774997848B5B42BEC655768F810DB5C73@SHSMSX103.ccr.corp.intel.com>
On 6/29/2017 6:18 AM, Wu, Jingjing wrote:
>
>
>> -----Original Message-----
>> From: Yong Wang [mailto:wang.yong19@zte.com.cn]
>> Sent: Friday, June 23, 2017 6:58 PM
>> To: Wu, Jingjing <jingjing.wu@intel.com>
>> Cc: dev@dpdk.org; Yong Wang <wang.yong19@zte.com.cn>
>> Subject: [PATCH v2] net/i40e: fix division by 0 error
>>
>> In function i40e_vsi_config_tc_queue_mapping(), if 'enabled_tcmap' is 0,
>> 'total_tc' might be 0. Then 'total_tc' might be used in a division by 0 in
>> "qpnum_per_tc = i40e_align_floor(vsi->nb_qps / total_tc)". Fix it by changing
>> 'total_tc' from 0 to 1 just as func
>> i40e_vsi_update_queue_mapping() does.
>>
>> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
>
>
> Acked-by: Jingjing Wu <jingjing.wu@intel.com>
>
Fixes: 4861cde46116 ("i40e: new poll mode driver")
Applied to dpdk-next-net/master, thanks.
(Adding braces to for loop not required and not related the patch,
removed from patch)
prev parent reply other threads:[~2017-06-29 11:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-23 10:57 Yong Wang
2017-06-29 5:18 ` Wu, Jingjing
2017-06-29 11:14 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c5aebf8-0fc0-122e-3977-cdfc39c825fc@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=wang.yong19@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).