From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Mauricio Vasquez B <mauricio.vasquez@polito.it>,
bruce.richardson@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] pmd_ring: fix coverity issue
Date: Tue, 1 Nov 2016 14:17:50 +0000 [thread overview]
Message-ID: <0c7bc9f5-decd-5fc1-6601-a457fee319dc@intel.com> (raw)
In-Reply-To: <1477972113-2600-1-git-send-email-mauricio.vasquez@polito.it>
Hi Mauricio,
On 11/1/2016 3:48 AM, Mauricio Vasquez B wrote:
> internals->data will never be NULL, so the check is not necessary.
>
> Fixes: d082c0395bf6 ("ring: fix memory leak when detaching")
> Coverity issue: 137873
>
> Signed-off-by: Mauricio Vasquez B <mauricio.vasquez@polito.it>
> ---
Thank you for the patch.
But "fix coverity issue" is not very descriptive title on its own.
Can you please describe what is really done in the patch, perhaps
something like:
"net/ring: remove unnecessary NULL check" ?
Thanks,
ferruh
next prev parent reply other threads:[~2016-11-01 14:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 3:48 Mauricio Vasquez B
2016-11-01 14:17 ` Ferruh Yigit [this message]
2016-11-01 19:55 ` [dpdk-dev] [PATCH v2] net/ring: remove unnecessary NULL check Mauricio Vasquez B
2016-11-02 11:38 ` Ferruh Yigit
2016-11-02 12:49 ` Fulvio Risso
2016-11-02 13:15 ` Ferruh Yigit
2016-11-02 13:50 ` Mauricio Vasquez
2016-11-02 13:46 ` [dpdk-dev] [PATCH v3] " Mauricio Vasquez B
2016-11-02 14:05 ` Ferruh Yigit
2016-11-07 13:08 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c7bc9f5-decd-5fc1-6601-a457fee319dc@intel.com \
--to=ferruh.yigit@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=mauricio.vasquez@polito.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).