From: Ilya Maximets <i.maximets@samsung.com>
To: Tiwei Bie <tiwei.bie@intel.com>,
maxime.coquelin@redhat.com, zhihong.wang@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [3/4] net/virtio: use virtio barrier in packed ring
Date: Wed, 23 Jan 2019 18:52:30 +0300 [thread overview]
Message-ID: <0cae3258-1004-4a93-a124-e8c92be7aaa1@samsung.com> (raw)
In-Reply-To: <20190122170143.5650-4-tiwei.bie@intel.com>
On 22.01.2019 20:01, Tiwei Bie wrote:
> Always use the virtio variants which support the platform
> memory ordering.
>
> Fixes: 9230ab8d7913 ("net/virtio: support platform memory ordering")
>
> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> ---
Thanks.
For some reason rte_smp_* barriers used directly here instead of virtio_*.
So, I missed them while rebasing on top of packed rings.
Acked-by: Ilya Maximets <i.maximets@samsung.com>
> drivers/net/virtio/virtio_rxtx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c
> index ebb86ef70..cc476b898 100644
> --- a/drivers/net/virtio/virtio_rxtx.c
> +++ b/drivers/net/virtio/virtio_rxtx.c
> @@ -425,7 +425,7 @@ virtqueue_enqueue_recv_refill_packed(struct virtqueue *vq,
> vq->vq_desc_head_idx = dxp->next;
> if (vq->vq_desc_head_idx == VQ_RING_DESC_CHAIN_END)
> vq->vq_desc_tail_idx = vq->vq_desc_head_idx;
> - rte_smp_wmb();
> + virtio_wmb(hw->weak_barriers);
> start_dp[idx].flags = flags;
> if (++vq->vq_avail_idx >= vq->vq_nentries) {
> vq->vq_avail_idx -= vq->vq_nentries;
> @@ -687,7 +687,7 @@ virtqueue_enqueue_xmit_packed(struct virtnet_tx *txvq, struct rte_mbuf *cookie,
>
> vq->vq_avail_idx = idx;
>
> - rte_smp_wmb();
> + virtio_wmb(vq->hw->weak_barriers);
> head_dp->flags = head_flags;
> }
>
>
next prev parent reply other threads:[~2019-01-23 15:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 17:01 [dpdk-dev] [PATCH 0/4] Virtio fixes Tiwei Bie
2019-01-22 17:01 ` [dpdk-dev] [PATCH 1/4] net/virtio: fix the control vq support Tiwei Bie
[not found] ` <CGME20190123130903eucas1p2730776e71039a79024dd7602b5dcad7d@eucas1p2.samsung.com>
2019-01-23 13:09 ` [dpdk-dev] [1/4] " Ilya Maximets
[not found] ` <CGME20190123163323eucas1p1baaec2c637cdc656ab9b26dbfd455bae@eucas1p1.samsung.com>
2019-01-23 16:33 ` Ilya Maximets
2019-01-23 22:02 ` Maxime Coquelin
2019-01-23 22:03 ` [dpdk-dev] [PATCH 1/4] " Maxime Coquelin
2019-01-22 17:01 ` [dpdk-dev] [PATCH 2/4] net/virtio-user: " Tiwei Bie
2019-01-23 22:07 ` Maxime Coquelin
2019-01-22 17:01 ` [dpdk-dev] [PATCH 3/4] net/virtio: use virtio barrier in packed ring Tiwei Bie
[not found] ` <CGME20190123155232eucas1p28bdd3a5c220452b81e21e48c19f3e5a7@eucas1p2.samsung.com>
2019-01-23 15:52 ` Ilya Maximets [this message]
2019-01-23 22:09 ` Maxime Coquelin
2019-01-22 17:01 ` [dpdk-dev] [PATCH 4/4] net/virtio-user: fix used ring update in cvq handling Tiwei Bie
2019-01-23 22:08 ` Maxime Coquelin
2019-01-23 22:25 ` [dpdk-dev] [PATCH 0/4] Virtio fixes Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0cae3258-1004-4a93-a124-e8c92be7aaa1@samsung.com \
--to=i.maximets@samsung.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).