From: Ferruh Yigit <ferruh.yigit@xilinx.com>
To: Chaoyong He <chaoyong.he@corigine.com>, <dev@dpdk.org>
Cc: <oss-drivers@corigine.com>, <niklas.soderlund@corigine.com>,
Heinrich Kuhn <heinrich.kuhn@corigine.com>
Subject: Re: [PATCH v7 09/12] net/nfp: add flower ctrl VNIC rxtx logic
Date: Mon, 5 Sep 2022 16:42:34 +0100 [thread overview]
Message-ID: <0cf388a3-4a09-cba3-db36-06844267b1ba@xilinx.com> (raw)
In-Reply-To: <1660299750-10668-10-git-send-email-chaoyong.he@corigine.com>
On 8/12/2022 11:22 AM, Chaoyong He wrote:
> Adds a Rx and Tx function for the ctrl VNIC. The logic is mostly
> identical to the normal Rx and Tx functionality of the NFP PMD.
>
> Make use of the ctrl VNIC service logic to service the ctrl VNIC Rx
> path.
>
> Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
> Signed-off-by: Heinrich Kuhn <heinrich.kuhn@corigine.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
<...>
> +uint16_t
> +nfp_flower_ctrl_vnic_xmit(struct nfp_app_flower *app_flower,
> + struct rte_mbuf *mbuf)
> +{
> + uint16_t cnt = 0;
> + uint64_t dma_addr;
> + uint32_t free_descs;
> + struct rte_mbuf **lmbuf;
> + struct nfp_net_txq *txq;
> + struct nfp_net_hw *ctrl_hw;
> + struct rte_eth_dev *ctrl_dev;
> + struct nfp_net_nfd3_tx_desc *txds;
> +
> + ctrl_hw = app_flower->ctrl_hw;
> + ctrl_dev = ctrl_hw->eth_dev;
> +
> + /* Flower ctrl vNIC only has a single tx queue */
> + txq = ctrl_dev->data->tx_queues[0];
> + if (unlikely(txq == NULL)) {
> + /*
> + * DPDK just checks the queue is lower than max queues
> + * enabled. But the queue needs to be configured
> + */
> + PMD_TX_LOG(ERROR, "ctrl dev TX Bad queue");
There is no log type 'RTE_LOG_ERROR', which cause build error, it should
be 'ERR'.
> + goto xmit_end;
> + }
> +
> + txds = &txq->txds[txq->wr_p];
> + txds->vals[0] = 0;
> + txds->vals[1] = 0;
> + txds->vals[2] = 0;
> + txds->vals[3] = 0;
> +
> + if (nfp_net_nfd3_txq_full(txq))
> + nfp_net_tx_free_bufs(txq);
> +
> + free_descs = nfp_net_nfd3_free_tx_desc(txq);
> + if (unlikely(free_descs == 0)) {
> + PMD_TX_LOG(ERROR, "ctrl dev no free descs");
ditto.
next prev parent reply other threads:[~2022-09-05 15:42 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 10:22 [PATCH v7 00/12] preparation for the rte_flow offload of nfp PMD Chaoyong He
2022-08-12 10:22 ` [PATCH v7 01/12] net/nfp: move app specific attributes to own struct Chaoyong He
2022-09-05 15:38 ` Ferruh Yigit
2022-09-06 9:20 ` Chaoyong He
2022-09-06 9:35 ` Ferruh Yigit
2022-08-12 10:22 ` [PATCH v7 02/12] net/nfp: simplify initialization and remove dead code Chaoyong He
2022-08-12 10:22 ` [PATCH v7 03/12] net/nfp: move app specific init logic to own function Chaoyong He
2022-09-05 15:38 ` Ferruh Yigit
2022-09-06 8:29 ` Chaoyong He
2022-09-06 9:47 ` Ferruh Yigit
2022-08-12 10:22 ` [PATCH v7 04/12] net/nfp: add initial flower firmware support Chaoyong He
2022-09-05 15:39 ` Ferruh Yigit
2022-09-07 8:22 ` Chaoyong He
2022-09-07 13:24 ` Ferruh Yigit
2022-08-12 10:22 ` [PATCH v7 05/12] net/nfp: add flower PF setup and mempool init logic Chaoyong He
2022-09-05 15:42 ` Ferruh Yigit
2022-09-06 8:45 ` Chaoyong He
2022-09-06 10:18 ` Ferruh Yigit
2022-08-12 10:22 ` [PATCH v7 06/12] net/nfp: add flower PF related routines Chaoyong He
2022-08-12 10:22 ` [PATCH v7 07/12] net/nfp: add flower ctrl VNIC related logics Chaoyong He
2022-08-12 10:22 ` [PATCH v7 08/12] net/nfp: move common rxtx function for flower use Chaoyong He
2022-08-12 10:22 ` [PATCH v7 09/12] net/nfp: add flower ctrl VNIC rxtx logic Chaoyong He
2022-09-05 15:42 ` Ferruh Yigit [this message]
2022-08-12 10:22 ` [PATCH v7 10/12] net/nfp: add flower representor framework Chaoyong He
2022-08-12 10:22 ` [PATCH v7 11/12] net/nfp: move rxtx function to header file Chaoyong He
2022-08-12 10:22 ` [PATCH v7 12/12] net/nfp: add flower PF rxtx logic Chaoyong He
2022-09-01 22:10 ` [PATCH v7 00/12] preparation for the rte_flow offload of nfp PMD Niklas Söderlund
2022-09-05 15:40 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0cf388a3-4a09-cba3-db36-06844267b1ba@xilinx.com \
--to=ferruh.yigit@xilinx.com \
--cc=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=heinrich.kuhn@corigine.com \
--cc=niklas.soderlund@corigine.com \
--cc=oss-drivers@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).