From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: David Marchand <david.marchand@redhat.com>,
dev@dpdk.org, Nicolas Chautru <nicolas.chautru@intel.com>
Subject: Re: [PATCH 1/2] baseband/acc: fix logtypes register
Date: Fri, 12 Jan 2024 15:05:41 +0100 [thread overview]
Message-ID: <0d2fdd8a-d583-448b-96e9-81e1e0525252@redhat.com> (raw)
In-Reply-To: <20231218154307.1507322-1-david.marchand@redhat.com>
On 12/18/23 16:43, David Marchand wrote:
> This library was calling RTE_LOG_REGISTER_DEFAULT twice, which means that
> all logs for both acc100 and vrb drivers would be emitted for
> pmd.baseband.acc logtype.
>
> It seems the intent was to have dedicated logtypes per driver, so
> register one for each with a suffix.
>
> Fixes: c2d93488c7c3 ("baseband/acc200: introduce ACC200")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> drivers/baseband/acc/rte_acc100_pmd.c | 4 ++--
> drivers/baseband/acc/rte_vrb_pmd.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c
> index 292537e24d..b837f7d7cd 100644
> --- a/drivers/baseband/acc/rte_acc100_pmd.c
> +++ b/drivers/baseband/acc/rte_acc100_pmd.c
> @@ -27,9 +27,9 @@
> #endif
>
> #ifdef RTE_LIBRTE_BBDEV_DEBUG
> -RTE_LOG_REGISTER_DEFAULT(acc100_logtype, DEBUG);
> +RTE_LOG_REGISTER_SUFFIX(acc100_logtype, acc100, DEBUG);
> #else
> -RTE_LOG_REGISTER_DEFAULT(acc100_logtype, NOTICE);
> +RTE_LOG_REGISTER_SUFFIX(acc100_logtype, acc100, NOTICE);
> #endif
>
> /* Calculate the offset of the enqueue register */
> diff --git a/drivers/baseband/acc/rte_vrb_pmd.c b/drivers/baseband/acc/rte_vrb_pmd.c
> index 686e086a5c..6a89f9d4b3 100644
> --- a/drivers/baseband/acc/rte_vrb_pmd.c
> +++ b/drivers/baseband/acc/rte_vrb_pmd.c
> @@ -22,9 +22,9 @@
> #include "vrb_pmd.h"
>
> #ifdef RTE_LIBRTE_BBDEV_DEBUG
> -RTE_LOG_REGISTER_DEFAULT(vrb_logtype, DEBUG);
> +RTE_LOG_REGISTER_SUFFIX(vrb_logtype, vrb, DEBUG);
> #else
> -RTE_LOG_REGISTER_DEFAULT(vrb_logtype, NOTICE);
> +RTE_LOG_REGISTER_SUFFIX(vrb_logtype, vrb, NOTICE);
> #endif
>
> /* Calculate the offset of the enqueue register. */
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
next prev parent reply other threads:[~2024-01-12 14:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 15:43 David Marchand
2023-12-18 15:43 ` [PATCH 2/2] baseband/acc: fix common logs David Marchand
2023-12-18 16:36 ` Stephen Hemminger
2024-01-12 14:07 ` Maxime Coquelin
2024-02-07 9:19 ` Maxime Coquelin
2023-12-18 16:36 ` [PATCH 1/2] baseband/acc: fix logtypes register Stephen Hemminger
2024-01-12 14:05 ` Maxime Coquelin [this message]
2024-02-07 9:18 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d2fdd8a-d583-448b-96e9-81e1e0525252@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=nicolas.chautru@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).