From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Chaoyong He <chaoyong.he@corigine.com>, dev@dpdk.org
Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com,
Peng Zhang <peng.zhang@corigine.com>,
stable@dpdk.org
Subject: Re: [PATCH v2] net/nfp: advertise no support for keeping flow rules
Date: Fri, 10 Feb 2023 20:28:54 +0000 [thread overview]
Message-ID: <0d366cd7-a22e-51cf-935c-ddfcf6a20c5f@amd.com> (raw)
In-Reply-To: <20230203015926.5235-1-chaoyong.he@corigine.com>
On 2/3/2023 1:59 AM, Chaoyong He wrote:
> From: Peng Zhang <peng.zhang@corigine.com>
>
> Explicitly clear the RTE_ETH_DEV_CAPA_FLOW_RULE_KEEP capability
> bit to match behavior of other PMDs. This was missed when first
> adding flow support for the NFP PMD.
>
> Fixes: 30ecce522732 ("net/nfp: support flow API")
> Cc: chaoyong.he@corigine.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Peng Zhang <peng.zhang@corigine.com>
> Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
> ---
> v2:
> * Fix the wrongly 'Reviewed-by' tag.
> ---
> drivers/net/nfp/nfp_common.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/nfp/nfp_common.c b/drivers/net/nfp/nfp_common.c
> index 71711bfa22..5c191b01ef 100644
> --- a/drivers/net/nfp/nfp_common.c
> +++ b/drivers/net/nfp/nfp_common.c
> @@ -794,6 +794,7 @@ nfp_net_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
> dev_info->speed_capa = RTE_ETH_LINK_SPEED_1G | RTE_ETH_LINK_SPEED_10G |
> RTE_ETH_LINK_SPEED_25G | RTE_ETH_LINK_SPEED_40G |
> RTE_ETH_LINK_SPEED_50G | RTE_ETH_LINK_SPEED_100G;
> + dev_info->dev_capa &= ~RTE_ETH_DEV_CAPA_FLOW_RULE_KEEP;
>
> return 0;
> }
Nack
Above code has no impact, it has been added to drivers to highlight this
feature to driver maintainers.
This feature is added to ethdev layer and requires driver support, but
driver maintainer may miss that this feature exists at all. With above
change driver maintainer can chose to remove that line meaning they are
aware but not prefer to support this feature or properly add support it.
For your case, no need to add it explicitly, if driver doesn't support
RTE_ETH_DEV_CAPA_FLOW_RULE_KEEP, no action is needed.
prev parent reply other threads:[~2023-02-10 20:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 1:36 [PATCH] " Chaoyong He
2023-02-03 1:59 ` [PATCH v2] " Chaoyong He
2023-02-10 20:28 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d366cd7-a22e-51cf-935c-ddfcf6a20c5f@amd.com \
--to=ferruh.yigit@amd.com \
--cc=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=niklas.soderlund@corigine.com \
--cc=oss-drivers@corigine.com \
--cc=peng.zhang@corigine.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).