From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Tiwei Bie <tiwei.bie@intel.com>
Cc: dev@dpdk.org, zhihong.wang@intel.com
Subject: Re: [dpdk-dev] [PATCH] vhost: log Virtio and Vhost-user negotiated features
Date: Fri, 21 Jun 2019 09:30:12 +0200 [thread overview]
Message-ID: <0dab583a-ecb6-4f85-8b4f-d53c94debb0f@redhat.com> (raw)
In-Reply-To: <20190621045148.GA29479@___>
On 6/21/19 6:51 AM, Tiwei Bie wrote:
> On Thu, Jun 20, 2019 at 10:07:12PM +0200, Maxime Coquelin wrote:
>> Having this info logged by default when analysing bug reports
>> has proved to be useful.
>>
>> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>> ---
>> lib/librte_vhost/vhost_user.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
>> index c9e29ece8..370864865 100644
>> --- a/lib/librte_vhost/vhost_user.c
>> +++ b/lib/librte_vhost/vhost_user.c
>> @@ -284,6 +284,8 @@ vhost_user_set_features(struct virtio_net **pdev, struct VhostUserMsg *msg,
>> } else {
>> dev->vhost_hlen = sizeof(struct virtio_net_hdr);
>> }
>> + RTE_LOG(INFO, VHOST_CONFIG,
>> + "Negotiated Virtio features: 0x%" PRIx64 "\n", dev->features);
>
> Might be better to use lowercase for "Negotiated", and we will
> get more consistent messages like this:
>
> VHOST_CONFIG: new vhost user connection is 278
> VHOST_CONFIG: new device, handle is 0
> VHOST_CONFIG: read message VHOST_USER_SET_OWNER
> VHOST_CONFIG: read message VHOST_USER_GET_FEATURES
> VHOST_CONFIG: read message VHOST_USER_SET_VRING_CALL
> VHOST_CONFIG: vring call idx:0 file:279
> VHOST_CONFIG: read message VHOST_USER_SET_VRING_CALL
> VHOST_CONFIG: vring call idx:1 file:280
> VHOST_CONFIG: read message VHOST_USER_SET_FEATURES
> VHOST_CONFIG: negotiated Virtio features: 0xd10008000
> VHOST_CONFIG: read message VHOST_USER_SET_MEM_TABLE
> VHOST_CONFIG: guest memory region 0, size: 0x20000000
> ......
>
> instead of:
>
> VHOST_CONFIG: new vhost user connection is 278
> VHOST_CONFIG: new device, handle is 0
> VHOST_CONFIG: read message VHOST_USER_SET_OWNER
> VHOST_CONFIG: read message VHOST_USER_GET_FEATURES
> VHOST_CONFIG: read message VHOST_USER_SET_VRING_CALL
> VHOST_CONFIG: vring call idx:0 file:279
> VHOST_CONFIG: read message VHOST_USER_SET_VRING_CALL
> VHOST_CONFIG: vring call idx:1 file:280
> VHOST_CONFIG: read message VHOST_USER_SET_FEATURES
> VHOST_CONFIG: Negotiated Virtio features: 0xd10008000
> VHOST_CONFIG: read message VHOST_USER_SET_MEM_TABLE
> VHOST_CONFIG: guest memory region 0, size: 0x20000000
> ......
>
Right, I'll fix it while applying.
>> VHOST_LOG_DEBUG(VHOST_CONFIG,
>> "(%d) mergeable RX buffers %s, virtio 1 %s\n",
>> dev->vid,
>> @@ -1406,6 +1408,9 @@ vhost_user_set_protocol_features(struct virtio_net **pdev,
>> }
>>
>> dev->protocol_features = protocol_features;
>> + RTE_LOG(INFO, VHOST_CONFIG,
>> + "Negotiated Vhost-user protocol features: 0x%" PRIx64 "\n",
>> + dev->protocol_features);
>
> Ditto.
>
> Other than that,
> Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>
Thanks,
Maxime
> Thanks,
> Tiwei
>
>>
>> return RTE_VHOST_MSG_RESULT_OK;
>> }
>> --
>> 2.21.0
>>
next prev parent reply other threads:[~2019-06-21 7:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 20:07 Maxime Coquelin
2019-06-21 4:51 ` Tiwei Bie
2019-06-21 7:30 ` Maxime Coquelin [this message]
2019-07-05 9:01 ` Tiwei Bie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0dab583a-ecb6-4f85-8b4f-d53c94debb0f@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).