DPDK patches and discussions
 help / color / mirror / Atom feed

From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Matan Azrad <matan@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "835703180@qq.com" <835703180@qq.com>,
	"NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>
Subject: Re: [PATCH] vdpa/mlx5: return correct error code after rte_intr_instance_alloc failed
Date: Wed, 22 Jun 2022 10:11:53 +0200	[thread overview]
Message-ID: <0dfe8a28-869b-1454-8fec-7634e7a87f8d@redhat.com> (raw)
In-Reply-To: <DM4PR12MB53897408E81AFCDC9838E42FDFB29@DM4PR12MB5389.namprd12.prod.outlook.com>

Hi Matan,

On 6/22/22 10:03, Matan Azrad wrote:
> Hi
> 
> I put here again the comment the putted on another version of this commit.
> 
> I saw it is already integrated but still not in master.
> 
> But please look.

Thanks for the heads-up, I missed your initial comment.

> From: Maxime Coquelin
>> Hi newsky647,
>>
>> On 6/12/22 16:09, 835703180@qq.com wrote:
>>> From: newsky647 <835703180@qq.com>
>>>
>>> After function rte_intr_instance_alloc failed, we should return ENOMEM
>>> for error code.
>>>
>>> Fixes: 5fe068bf7a2 ("vdpa/mlx5: reuse resources in reconfiguration")
>>>
>>> Signed-off-by: newsky647 <835703180@qq.com>
>>> ---
>>>    drivers/vdpa/mlx5/mlx5_vdpa_event.c | 1 +
>>>    1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_event.c
>>> b/drivers/vdpa/mlx5/mlx5_vdpa_event.c
>>> index 7167a98db0..6223afaae8 100644
>>> --- a/drivers/vdpa/mlx5/mlx5_vdpa_event.c
>>> +++ b/drivers/vdpa/mlx5/mlx5_vdpa_event.c
>>> @@ -395,6 +395,7 @@ mlx5_vdpa_err_event_setup(struct mlx5_vdpa_priv
>> *priv)
>>>                rte_intr_instance_alloc(RTE_INTR_INSTANCE_F_SHARED);
>>>        if (priv->err_intr_handle == NULL) {
>>>                DRV_LOG(ERR, "Fail to allocate intr_handle");
>>> +             rte_errno = ENOMEM;
> 
> Shouldn't rte_intr_instance_alloc set it?

I think it makes sense, Thomas could you drop the patch while pulling my
branch? Or do you prefer I remove it directly from my tree?

Shiqi, can you send a new version of the patch taking Matan comment into
account?

Thanks,
Maxime

>>>                goto error;
>>>        }
>>>        if (rte_intr_fd_set(priv->err_intr_handle, priv->err_chnl->fd))
>>
>> The patch looks good to me, but I would need your real name for the sign-off.
>>
>> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>>
>> Thanks,
>> Maxime
> 

next prev parent reply	other threads:[~2022-06-22  8:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-12 14:09 835703180
2022-06-14  9:43 ` Maxime Coquelin
2022-06-14 13:36   ` [PATCH V2] " 835703180
2022-06-14 13:50     ` Maxime Coquelin
2022-06-14 13:48   ` 835703180
2022-06-15  7:47     ` Matan Azrad
2022-06-22  8:03   ` [PATCH] " Matan Azrad
2022-06-22  8:11     ` Maxime Coquelin [this message]
2022-06-22  8:46       ` Thomas Monjalon
2022-06-22  8:46         ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0dfe8a28-869b-1454-8fec-7634e7a87f8d@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=835703180@qq.com \
    --cc=dev@dpdk.org \
    --cc=matan@nvidia.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).