From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Simei Su <simei.su@intel.com>, qi.z.zhang@intel.com
Cc: dev@dpdk.org, junfeng.guo@intel.com, yahui.cao@intel.com,
xiao.zhang@intel.com
Subject: Re: [dpdk-dev] [PATCH v1 2/2] app/testpmd: support extended RSS offload types
Date: Tue, 17 Nov 2020 13:11:49 +0000 [thread overview]
Message-ID: <0ea0b0ff-bff8-c565-af35-4df838b61b5f@intel.com> (raw)
In-Reply-To: <20201116053238.440870-3-simei.su@intel.com>
On 11/16/2020 5:32 AM, Simei Su wrote:
> This patch adds testpmd cmdline support for eCPRI.
>
> Signed-off-by: Simei Su <simei.su@intel.com>
> ---
> app/test-pmd/cmdline.c | 9 ++++++---
> app/test-pmd/config.c | 3 ++-
> 2 files changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index 5e2881e..e5f3462 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -2164,7 +2164,8 @@ cmd_config_rss_parsed(void *parsed_result,
> rss_conf.rss_hf = ETH_RSS_ETH | ETH_RSS_VLAN | ETH_RSS_IP |
> ETH_RSS_TCP | ETH_RSS_UDP | ETH_RSS_SCTP |
> ETH_RSS_L2_PAYLOAD | ETH_RSS_L2TPV3 | ETH_RSS_ESP |
> - ETH_RSS_AH | ETH_RSS_PFCP | ETH_RSS_GTPU;
> + ETH_RSS_AH | ETH_RSS_PFCP | ETH_RSS_GTPU |
> + ETH_RSS_ECPRI;
> else if (!strcmp(res->value, "eth"))
> rss_conf.rss_hf = ETH_RSS_ETH;
> else if (!strcmp(res->value, "vlan"))
> @@ -2223,6 +2224,8 @@ cmd_config_rss_parsed(void *parsed_result,
> rss_conf.rss_hf = ETH_RSS_PPPOE;
> else if (!strcmp(res->value, "gtpu"))
> rss_conf.rss_hf = ETH_RSS_GTPU;
> + else if (!strcmp(res->value, "ecpri"))
> + rss_conf.rss_hf = ETH_RSS_ECPRI;
> else if (!strcmp(res->value, "none"))
> rss_conf.rss_hf = 0;
> else if (!strcmp(res->value, "level-default")) {
Can you please update 'cmd_config_rss.help_str' to add the 'ecpri'?
Also please update 'cmd_help_long_parsed()', "port config all rss ..." cmd to
add the 'ecpri'.
And please update the documentation
(doc/guides/testpmd_app_ug/testpmd_funcs.rst), add 'ecpri' to the section "port
config - RSS"
next prev parent reply other threads:[~2020-11-17 13:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 5:32 [dpdk-dev] [PATCH v1 0/2] extend " Simei Su
2020-11-16 5:32 ` [dpdk-dev] [PATCH v1 1/2] ethdev: add eCPRI " Simei Su
2020-11-17 13:06 ` Ferruh Yigit
2020-11-16 5:32 ` [dpdk-dev] [PATCH v1 2/2] app/testpmd: support extended " Simei Su
2020-11-17 13:11 ` Ferruh Yigit [this message]
2020-11-18 1:34 ` [dpdk-dev] [PATCH v2 0/2] extend " Simei Su
2020-11-18 1:34 ` [dpdk-dev] [PATCH v2 1/2] ethdev: add eCPRI " Simei Su
2020-11-18 1:34 ` [dpdk-dev] [PATCH v2 2/2] app/testpmd: support extended " Simei Su
2020-11-18 12:55 ` Ferruh Yigit
2020-11-18 12:56 ` [dpdk-dev] [PATCH v2 0/2] extend " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ea0b0ff-bff8-c565-af35-4df838b61b5f@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=junfeng.guo@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=simei.su@intel.com \
--cc=xiao.zhang@intel.com \
--cc=yahui.cao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).