From: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
To: dev@dpdk.org
Cc: Yongseok Koh <yskoh@mellanox.com>,
Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: [dpdk-dev] [PATCH 1/3] net/mlx5: fix flow priority for queue action
Date: Mon, 23 Oct 2017 11:44:59 +0200 [thread overview]
Message-ID: <0ea336c48401bec6674749d7d857094889c20cae.1508750504.git.nelio.laranjeiro@6wind.com> (raw)
In-Reply-To: <cover.1508750504.git.nelio.laranjeiro@6wind.com>
In-Reply-To: <cover.1508750504.git.nelio.laranjeiro@6wind.com>
Priority is wrongly configured when the action is queue, using the Ethernet
layer priority instead of the most specific layer found.
Fixes: 8086cf08b2f0 ("net/mlx5: handle RSS hash configuration in RSS flow")
Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Acked-by: Yongseok Koh <yskoh@mellanox.com>
---
drivers/net/mlx5/mlx5_flow.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 2b6380fb9..440bda9a1 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -1172,8 +1172,18 @@ priv_flow_convert(struct priv *priv,
* Last step. Complete missing specification to reach the RSS
* configuration.
*/
- if (parser->queues_n > 1)
+ if (parser->queues_n > 1) {
priv_flow_convert_finalise(priv, parser);
+ } else if (!parser->drop) {
+ /*
+ * Action queue have their priority overridden with
+ * Ethernet priority, this priority needs to be adjusted to
+ * their most specific layer priority.
+ */
+ parser->queue[HASH_RXQ_ETH].ibv_attr->priority =
+ attr->priority +
+ hash_rxq_init[parser->layer].flow_priority;
+ }
exit_free:
/* Only verification is expected, all resources should be released. */
if (!parser->create) {
--
2.11.0
next prev parent reply other threads:[~2017-10-23 9:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 12:09 [dpdk-dev] [PATCH 1/2] " Nelio Laranjeiro
2017-10-13 12:09 ` [dpdk-dev] [PATCH 2/2] app/testpmd: fix RSS structure initialisation Nelio Laranjeiro
2017-10-20 19:46 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2017-10-23 9:44 ` [dpdk-dev] [PATCH 0/3] net/mlx5: bugfixes Nelio Laranjeiro
2017-10-23 11:17 ` [dpdk-dev] [PATCH v3 0/3] net/mlx5: bug fixes Nelio Laranjeiro
2017-10-23 21:30 ` Ferruh Yigit
2017-10-23 11:17 ` [dpdk-dev] [PATCH v3 1/3] net/mlx5: fix flow priority for queue action Nelio Laranjeiro
2017-10-23 11:17 ` [dpdk-dev] [PATCH v3 2/3] app/testpmd: fix RSS structure initialisation Nelio Laranjeiro
2017-10-23 11:17 ` [dpdk-dev] [PATCH v3 3/3] net/mlx5: fix RSS hash update Nelio Laranjeiro
2017-10-23 18:54 ` Yongseok Koh
2017-10-23 9:44 ` Nelio Laranjeiro [this message]
2017-10-23 9:45 ` [dpdk-dev] [PATCH 2/3] app/testpmd: fix RSS structure initialisation Nelio Laranjeiro
2017-10-23 9:45 ` [dpdk-dev] [PATCH 3/3] net/mlx5: fix RSS hash update Nelio Laranjeiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ea336c48401bec6674749d7d857094889c20cae.1508750504.git.nelio.laranjeiro@6wind.com \
--to=nelio.laranjeiro@6wind.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).